Age | Commit message (Collapse) | Author |
|
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|
|
|
|
|
Altered specs that click capitalised New Snippet button
Applied review feedback missed in Changes `.no-comment` `opactiy: 0.5` to `opacity: .5`
Added `.btn-wide-on-xs` and applied to snippet buttons
|
|
|
|
|
|
|
|
|
|
'19957-write-tests-for-adding-comments-for-different-line-types-in-diff' into 'master'"
This reverts merge request !5417
|
|
'19957-write-tests-for-adding-comments-for-different-line-types-in-diff' into 'master'
Add rspec feature tests for the diff notes feature.
## What are the relevant issue numbers?
Closes #19957.
See merge request !5417
|
|
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
|
|
|
|
|
|
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
|
|
The issue was fixed in 2ba5e62. The spec is going in separately just
so the fix could go in as soon as possible.
|
|
This reverts merge request !5290
|
|
This reverts merge request !4970
|
|
Revert "Optimistic locking for Issue and Merge Requests"
The migration to add `lock_version` in !5146 to every issue and merge request takes too long on GitLab.com since it has to add a default value of 0 to every row. Unfortunately, Rails 4.2 doesn't work properly if the value is left as `nil`; anything using optimistic locking cannot be edited.
This bug was fixed in Rails 5.0 via this commit: https://github.com/rails/rails/commit/13772bfa49325a8dc26410d2dcb555665a320f92. I suggest we revert this change for now, and when we upgrade to Rails 5.0 we can reintroduce this feature.
See merge request !5245
|
|
GL dropdowns in issuable form
## What does this MR do?
Changed all the issuable dropdown menus over to user GL dropdowns. This brings the dropdowns to be inline with the issuable filter dropdowns and allows for labels to be created whilst creating/editing an issuable.
## What are the relevant issue numbers?
Closes #12574
## Screenshots (if relevant)
See merge request !4970
|
|
This reverts commit c39356998b1850f3dc26fe0b987cb419c1d1afb4.
|
|
|
|
|
|
With the option to expand and collapse individual diffs, these aren't
needed any more.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
|
|
Workhorse to serve raw diffs
Fixes (partially) #13999
Dependent on: gitlab-org/gitlab-workhorse!45
See merge request !4130
|
|
The buttons were rarely used and added at least 1 query each on every page load.
|
|
|
|
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
|
|
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
|
|
|
|
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
|
|
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|
Mostly replaces several Spinach tests with RSpec Feature tests.
|
|
|
|
Mutliple label filter
Fixes #989
See merge request !3438
|
|
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|
|
|
Updated UI for new merge request
Closes #2540
![Screen_Shot_2016-03-29_at_12.53.18](/uploads/426e603675171f0dc4e0af83c7762eba/Screen_Shot_2016-03-29_at_12.53.18.png)
![Screen_Shot_2016-03-29_at_12.53.13](/uploads/645ad7955acfb9f7693245fcc048ee49/Screen_Shot_2016-03-29_at_12.53.13.png)
See merge request !3228
|
|
This reverts merge request !3494
|
|
|
|
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
|
|
These tests would check if the "This project is empty" banner would
contain SSH clone URLs. Oddly enough this should have never passed (as
far as I can tell) as SSH clone URLs in this banner are _only_ displayed
if the current user has at least 1 SSH key attached. Since the tests
never seem to create any they never should have passed, yet somehow they
did. To solve this the Spinach tests in question now ensure at least 1
SSH key is present.
|
|
|
|
before the search field is focused
|