Welcome to mirror list, hosted at ThFree Co, Russian Federation.

gitlab.com/gitlab-org/gitlab-foss.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-02-03Merge branch '25624-anticipate-obstacles-to-removing-turbolinks' into 'master' Jacob Schatz
Remove Turbolinks Closes #25624 See merge request !8570
2017-02-03Fix broken testsFilipa Lacerda
Rename Build to Job Replace "Builds" by "Jobs" and fix broken specs Replace "Builds" by "Jobs" Fix broken spinach test Fix broken test Remove `˙` at the beginning of the file Fix broken spinach test Fix broken tests Changes after review
2017-02-02Find .merge-request instead of sleep in MR search spec.Bryce Johnson
2017-02-02Remove turbolinks.Bryce Johnson
2017-01-31Move Dashboard shortcuts specs from Spinah to RSpecRémy Coutable
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-01-30Added labels empty state and priority label empty stateLuke "Jared" Bennett
Fixed delete labels not working Review changes
2017-01-28Present TODO's list without grouping by projectOswaldo Ferreira
2017-01-26Merge branch 'rs-empty_project-for-associations' into 'master' Rémy Coutable
Factories with a project association use `:empty_project` by default See merge request !8770
2017-01-25Use a project factory with a repository where necessaryRobert Speicher
2017-01-25Fix race conditions for AuthorizedProjectsWorkerYorick Peterse
There were two cases that could be problematic: 1. Because sometimes AuthorizedProjectsWorker would be scheduled in a transaction it was possible for a job to run/complete before a COMMIT; resulting in it either producing an error, or producing no new data. 2. When scheduling jobs the code would not wait until completion. This could lead to a user creating a project and then immediately trying to push to it. Usually this will work fine, but given enough load it might take a few seconds before a user has access. The first one is problematic, the second one is mostly just annoying (but annoying enough to warrant a solution). This commit changes two things to deal with this: 1. Sidekiq scheduling now takes places after a COMMIT, this is ensured by scheduling using Rails' after_commit hook instead of doing so in an arbitrary method. 2. When scheduling jobs the calling thread now waits for all jobs to complete. Solution 2 requires tracking of job completions. Sidekiq provides a way to find a job by its ID, but this involves scanning over the entire queue; something that is very in-efficient for large queues. As such a more efficient solution is necessary. There are two main Gems that can do this in a more efficient manner: * sidekiq-status * sidekiq_status No, this is not a joke. Both Gems do a similar thing (but slightly different), and the only difference in their name is a dash vs an underscore. Both Gems however provide far more than just checking if a job has been completed, and both have their problems. sidekiq-status does not appear to be actively maintained, with the last release being in 2015. It also has some issues during testing as API calls are not stubbed in any way. sidekiq_status on the other hand does not appear to be very popular, and introduces a similar amount of code. Because of this I opted to write a simple home grown solution. After all, all we need is storing a job ID somewhere so we can efficiently look it up; we don't need extra web UIs (as provided by sidekiq-status) or complex APIs to update progress, etc. This is where Gitlab::SidekiqStatus comes in handy. This namespace contains some code used for tracking, removing, and looking up job IDs; all without having to scan over an entire queue. Data is removed explicitly, but also expires automatically just in case. Using this API we can now schedule jobs in a fork-join like manner: we schedule the jobs in Sidekiq, process them in parallel, then wait for completion. By using Sidekiq we can leverage all the benefits such as being able to scale across multiple cores and hosts, retrying failed jobs, etc. The one downside is that we need to make sure we can deal with unexpected increases in job processing timings. To deal with this the class Gitlab::JobWaiter (used for waiting for jobs to complete) will only wait a number of seconds (30 by default). Once this timeout is reached it will simply return. For GitLab.com almost all AuthorizedProjectWorker jobs complete in seconds, only very rarely do we spike to job timings of around a minute. These in turn seem to be the result of external factors (e.g. deploys), in which case a user is most likely not able to use the system anyway. In short, this new solution should ensure that jobs are processed properly and that in almost all cases a user has access to their resources whenever they need to have access.
2017-01-20Merge branch '26138-combine-webhooks-and-services-settings-pages' into 'master' Rémy Coutable
Moved the webhooks and services gear options to a single one called integrations See merge request !8380
2017-01-19Merge branch ↵Fatih Acet
'24032-changed-visibility-level-to-public-but-project-is-not-public' into 'master' Update project visibility level ui to use dropdowns Closes #24296, #24123, and #24032 See merge request !7645
2017-01-19Fixed more testsJose Ivan Vargas
2017-01-19Fixed spinach feature tests for the services and hooks controllersJose Ivan Vargas
Added a test for the integrations controller
2017-01-18Remove repository trait from factories that don't need it in featuresRobert Speicher
2017-01-18Add the `:repository` trait to `:project` factories in Cucumber stepsRobert Speicher
2017-01-16Merge branch 'move-admin-groups-spinach-test-to-rspec' into 'master' Rémy Coutable
Move admin groups spinach tests to rspec See merge request !8313
2017-01-13Merge branch 'move-dashboard-help-spinach-to-rspec' into 'master' Rémy Coutable
Move dashboard help spinach test to rspec See merge request !8436
2017-01-13Merge branch 'move-dashboard-group-spinach-to-rspec' into 'master' Rémy Coutable
Move dashboard group spinach test to rspec See merge request !8434
2017-01-13Merge branch 'move-dashboard-archived-projects-spinach-to-rspec' into 'master' Rémy Coutable
Move dashboard archived projects spinach tests to rspec See merge request !8431
2017-01-13Merge branch 'move-dashboard-activetab-spinach-to-rspec' into 'master' Rémy Coutable
Move dashboard active tab spinach test to rspec See merge request !8423
2017-01-13Merge branch 'move-admin-users-spinach-tests-to-rspec' into 'master' Rémy Coutable
Move admin users spinach tests to rspec See merge request !8395
2017-01-10Fix spinach testsClement Ho
2017-01-06Merge branch '25985-combine-members-and-groups-settings-pages' into 'master' Alfredo Sumaran
Moved the members and groups to single option called members Closes #25985 See merge request !8281
2017-01-04Move dashboard help spinach test to rspecSemyon Pupkov
https://gitlab.com/gitlab-org/gitlab-ce/issues/23036
2017-01-04Move dashboard group spinach test to rspecSemyon Pupkov
https://gitlab.com/gitlab-org/gitlab-ce/issues/23036
2017-01-04Move dashboard archived projects spinach tests to rspecSemyon Pupkov
https://gitlab.com/gitlab-org/gitlab-ce/issues/23036
2017-01-03Move dashboard active tab spinach test to rspecSemyon Pupkov
https://gitlab.com/gitlab-org/gitlab-ce/issues/23036
2017-01-03Fixed more rspec tests as well as spinach featuresJose Ivan Vargas
2017-01-03Move admin deploy keys spinach to rspecSemyon Pupkov
2017-01-02Move admin users spinach tests to rspecSemyon Pupkov
https://gitlab.com/gitlab-org/gitlab-ce/issues/23036
2016-12-27Merge branch 'feature/1376-allow-write-access-deploy-keys' into 'master' Douwe Maan
Allow to add deploy keys with write-access Closes #1376 See merge request !7383
2016-12-26Move admin groups spinach tests to rspecSemyon Pupkov
https://gitlab.com/gitlab-org/gitlab-ce/issues/23036
2016-12-21Changes after reviewFilipa Lacerda
Fix broken test Remove spinach tests for the builds tab
2016-12-20Merge remote-tracking branch 'upstream/master' into ↵Lin Jen-Shin
feature/1376-allow-write-access-deploy-keys * upstream/master: (538 commits) Reject blank environment vcariables in Gitlab::Git::RevList Add online terminal documentation Add changelog entry Add terminal UI and controller actions Fix specs Even out padding on plus button in breadcrumb menu Update font size of detail page header to 14px Update CHANGELOG.md for 8.13.10 Update CHANGELOG.md for 8.14.5 Fix Route#rename_children behavior Remove inline-block styling from status Add terminals to the Kubernetes deployment service Add a ReactiveCaching concern for use in the KubernetesService Add xterm.js 2.1.0 and a wrapper class to the asset pipeline Remove unnecessary hidden svg elements for icons. Fix consistent typo in environment.js Use a block to insert extra check for authenticate_build! Align milestone column header with count number Add Wiki import to BB importer Make CI badge hitboxes better match container ...
2016-12-20Merge branch 'move-admin-projects-spinach-tests-to-rspec' into 'master' Rémy Coutable
Move admin projects spinach tests to RSpec Part of https://gitlab.com/gitlab-org/gitlab-ce/issues/23036 See merge request !8174
2016-12-20Merge branch 'zj-kamil-slack-slash-commands' into 'master' Grzegorz Bizon
Slack slash commands ## What does this MR do? Implement Slack Slash Commands by utilizing generalized Mattermost presenter to fulfill Slack requirements. ## Why was this MR needed? We want to expose Slack Slash Commands as a first-class service. ## What are the relevant issue numbers? Supersedes !8007 Closes #22182 See merge request !8126
2016-12-20Fix specsKamil Trzcinski
2016-12-19Merge branch 'move-admin-appearance-feature-to-rspec' into 'master' Rémy Coutable
Move Admin Appearance spinach feature to RSpec Part of #23036 See merge request !8063
2016-12-19Move admin broadcast messages spinach feature to rspecjurre
2016-12-19Move Admin Appearance spinach feature to rspecjurre
2016-12-19Merge branch 'move-admin-label-spinach-test-to-rspec' into 'master' Rémy Coutable
Move admin labels spinach test to RSpec Part of #23036 See merge request !8166
2016-12-19Improve after feedbackKamil Trzcinski
2016-12-19Move admin projects spinach tests to rspecSemyon Pupkov
https://gitlab.com/gitlab-org/gitlab-ce/issues/23036
2016-12-19Move admin labels spinach test to rspecSemyon Pupkov
https://gitlab.com/gitlab-org/gitlab-ce/issues/23036
2016-12-19Merge branch 'move-admin-application-spinach-test-to-rspec' into 'master' Rémy Coutable
Move admin application spinach test to RSpec Part of #23036 See merge request !8140
2016-12-17Move admin application spinach test to rspecSemyon Pupkov
https://gitlab.com/gitlab-org/gitlab-ce/issues/23036
2016-12-17Move admin deploy keys spinach test to rspecSemyon Pupkov
https://gitlab.com/gitlab-org/gitlab-ce/issues/23036
2016-12-15Merge branch 'move-admin-active-tab-spinach-tests-to-rspec' into 'master' Rémy Coutable
Move admin active tab spinach tests to RSpec See merge request !8037
2016-12-15Merge branch 'jej-24637-move-issue-visible_to_user-to-finder' into 'security' Sean McGivern
Issue#visible_to_user moved to IssuesFinder Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/24637. See merge request !2039