| Age | Commit message (Collapse) | Author |
|---|
|
|
|
|
|
|
|
|
|
Todo done clicking is kind of unusable.
Closes #25465
See merge request !8691
|
|
The Done button will change to an Undo button and the line item will be greyed out.
Bold links will be unbolded.
The user can undo the task by clicking the Undo button.
|
|
Make pipeline retry take stages order into account
Closes #27431, #23710, and #26551
See merge request !9021
|
|
Move dashboard issues spinach test to Rspec
See merge request !8955
|
|
* master: (313 commits)
Allow slashes in slash command arguments
Add API endpoint to get all milestone merge requests
remove trailing comma
Restore pagination to admin abuse reports
replace deprecated NoErrorsPlugin with NoEmitOnErrorsPlugin
only compress assets in production
Reduce number of pipelines created to test pagination
add CHANGELOG.md entry for !8761
prevent diff unfolding link from appearing for deleted files
fix build failures
only show diff unfolding link if there are more lines to show
fix typo in node section
Only yield valid references in ReferenceFilter.references_in
Cache js selectors; fix css
move "Install node modules" step before "Migrate DB" within update process
Renders pagination again for pipelines table
update migration docs for 8.17 to include minimum node version
Add CHANGELOG file
Fix positioning of top scroll button
Remove comments in migration
...
|
|
|
|
|
|
https://gitlab.com/gitlab-org/gitlab-ce/issues/23036
|
|
Move 'User Snippets' Spinach feature to Rspec
See merge request !8574
|
|
# Conflicts:
# db/schema.rb
|
|
Remove Turbolinks
Closes #25624
See merge request !8570
|
|
|
|
Rename Build to Job
Replace "Builds" by "Jobs" and fix broken specs
Replace "Builds" by "Jobs"
Fix broken spinach test
Fix broken test
Remove `˙` at the beginning of the file
Fix broken spinach test
Fix broken tests
Changes after review
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
1. PagesController is used to show all domains and general overview of Pages
2. PagesDomainsController is used to manage pages domains
|
|
|
|
|
|
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|
Fixed delete labels not working
Review changes
|
|
|
|
Factories with a project association use `:empty_project` by default
See merge request !8770
|
|
|
|
There were two cases that could be problematic:
1. Because sometimes AuthorizedProjectsWorker would be scheduled in a
transaction it was possible for a job to run/complete before a
COMMIT; resulting in it either producing an error, or producing no
new data.
2. When scheduling jobs the code would not wait until completion. This
could lead to a user creating a project and then immediately trying
to push to it. Usually this will work fine, but given enough load it
might take a few seconds before a user has access.
The first one is problematic, the second one is mostly just annoying
(but annoying enough to warrant a solution).
This commit changes two things to deal with this:
1. Sidekiq scheduling now takes places after a COMMIT, this is ensured
by scheduling using Rails' after_commit hook instead of doing so in
an arbitrary method.
2. When scheduling jobs the calling thread now waits for all jobs to
complete.
Solution 2 requires tracking of job completions. Sidekiq provides a way
to find a job by its ID, but this involves scanning over the entire
queue; something that is very in-efficient for large queues. As such a
more efficient solution is necessary. There are two main Gems that can
do this in a more efficient manner:
* sidekiq-status
* sidekiq_status
No, this is not a joke. Both Gems do a similar thing (but slightly
different), and the only difference in their name is a dash vs an
underscore. Both Gems however provide far more than just checking if a
job has been completed, and both have their problems. sidekiq-status
does not appear to be actively maintained, with the last release being
in 2015. It also has some issues during testing as API calls are not
stubbed in any way. sidekiq_status on the other hand does not appear to
be very popular, and introduces a similar amount of code.
Because of this I opted to write a simple home grown solution. After
all, all we need is storing a job ID somewhere so we can efficiently
look it up; we don't need extra web UIs (as provided by sidekiq-status)
or complex APIs to update progress, etc.
This is where Gitlab::SidekiqStatus comes in handy. This namespace
contains some code used for tracking, removing, and looking up job IDs;
all without having to scan over an entire queue. Data is removed
explicitly, but also expires automatically just in case.
Using this API we can now schedule jobs in a fork-join like manner: we
schedule the jobs in Sidekiq, process them in parallel, then wait for
completion. By using Sidekiq we can leverage all the benefits such as
being able to scale across multiple cores and hosts, retrying failed
jobs, etc.
The one downside is that we need to make sure we can deal with
unexpected increases in job processing timings. To deal with this the
class Gitlab::JobWaiter (used for waiting for jobs to complete) will
only wait a number of seconds (30 by default). Once this timeout is
reached it will simply return.
For GitLab.com almost all AuthorizedProjectWorker jobs complete in
seconds, only very rarely do we spike to job timings of around a minute.
These in turn seem to be the result of external factors (e.g. deploys),
in which case a user is most likely not able to use the system anyway.
In short, this new solution should ensure that jobs are processed
properly and that in almost all cases a user has access to their
resources whenever they need to have access.
|
|
Moved the webhooks and services gear options to a single one called integrations
See merge request !8380
|
|
'24032-changed-visibility-level-to-public-but-project-is-not-public' into 'master'
Update project visibility level ui to use dropdowns
Closes #24296, #24123, and #24032
See merge request !7645
|
|
|
|
Added a test for the integrations controller
|
|
|
|
|
|
This commit moves the `snippets/user.feature` Spinach test to a
Rspec feature, as part of deprecating the Spinach test suite.
- Remove Spinach discover snippets feature and steps
- Add Rspec feature test
|
|
Move admin groups spinach tests to rspec
See merge request !8313
|
|
Move dashboard help spinach test to rspec
See merge request !8436
|
|
Move dashboard group spinach test to rspec
See merge request !8434
|
|
Move dashboard archived projects spinach tests to rspec
See merge request !8431
|
|
Move dashboard active tab spinach test to rspec
See merge request !8423
|
|
Move admin users spinach tests to rspec
See merge request !8395
|
|
|
|
Moved the members and groups to single option called members
Closes #25985
See merge request !8281
|
|
https://gitlab.com/gitlab-org/gitlab-ce/issues/23036
|
