| Age | Commit message (Collapse) | Author |
|---|
|
|
|
|
|
|
|
|
|
This moves the development favicon name in Gitlab::Favicon to a separate
method, allowing EE to redefine it to return a custom favicon.
|
|
|
|
Even if it doesn’t save lines of code, since people will tend to use
code they’ve seen. And `SafeRequestStore` is safer since you
don’t have to remember to check `RequestStore.active?`.
|
|
|
|
with CORS
|
|
See https://gitlab.com/gitlab-org/gitlab-ce/issues/47677 for more information
|
|
|
|
probably due to recent changes in `UploadsController`.
|
|
|
|
the ci status icons are generated client side, wo we don't need the
static files anymore.
|
|
the initial reason for this change was that graphicsmagick does not
support writing to ico files. this fact lead to a chain of changes:
1. use png instead of ico (browser support is good enough)
2. render the overlays on the client using the canvas API. this way we
only need to store the original favion and generate the overlay versions
dynamically.
this change also enables (next step) to simplify the handling of the
stock favicons as well, as we don't need to generate all the versions
upfront.
|
|
this ways we can keep the `lib/gitlab/ci/status/*` classes to return the
bare favicon name as it was before.
also the favicon uploader versions are now have the same names as the
stock favicons (+ `favicon_` prefix), which makes working with the
status names easier.
|
|
|
|
Without the '?' at the end of the favicon url the custom favicon (i.e.
the favicons that are served through `UploadController`) are not shown
in the browser. It may have something to do with how `#send_file` /
`#send_data` set http headers. When serving the same icon file from the
public directory everything is fine.
|
|
|
|
|
