Age | Commit message (Collapse) | Author |
|
|
|
Prevents refspec as branch name, which would bypass branch protection
when used in conjunction with rebase.
HEAD seems to be a special case with lots of occurrence,
so it is considered valid for now.
Another special case is `refs/head/*`, which can be imported.
|
|
`Rugged::Reference.valid_name?` used in
`Gitlab::GitRefValidator.validate` fails on strings containing null
bytes because it uses `StringValueCStr()`. Per
https://silverhammermba.github.io/emberb/c/:
Ruby’s String kinda corresponds to C’s char*. The simplest macro is
StringValueCStr() which returns a null-terminated char* for a
String. The problem here is that a Ruby String might contain nulls - in
which case StringValueCStr() will raise an ArgumentError!
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/54466
|
|
|
|
|
|
Closes #38817
|
|
|
|
Signed-off-by: Matthieu Tardy <matthieu.tardy@gmail.com>
|
|
Closes #3311
|
|
|
|
This reverts commit b33d4bc2f1d26ee3526b9d7f530f468a9d5b5a5e.
|
|
This reverts commit 0b1084a4538bc46684c8620410988d3b1093e7ab.
|
|
It pollutes the test output too much.
|
|
Add specs for GitRefValidator
|