| Age | Commit message (Collapse) | Author |
|---|
|
allow_bypass_two_factor configration dose not work with saml provider
|
|
This reverts merge request !31826
|
|
|
|
This also restructures how and where the configuration for
Snowplow lives.
|
|
Fix N+1 Gitaly calls in /api/v4/projects/:id/issues
See merge request gitlab-org/gitlab-ce!32171
|
|
The `GraphQL::Function` has been deprecated in
favor of resolvers.
|
|
|
|
Code Review Usage Ping for Create SMAU
|
|
|
|
DB Load Balancing: Support SRV lookups
See merge request gitlab-org/gitlab-ce!32135
|
|
- Also add helper to undo rename_column_concurrently.
|
|
This is a follow-up from
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/31938.
In GitLab 9.0,
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/9661 removed the
`subscribed` flag from the API when the user requested a list of issues
or merge requests since calculating this value triggers extensive
Markdown processing.
In GitLab 12.0 via a4fbf39e, we accidentally reintroduced this
performance regression by changing `IssueBasic` to `Issue` in
`entities.rb`. This showed up as a Gitaly N+1 issue since the Markdown
processing would attempt to extract a commit if it detected a regex that
matched a commit.
We restore the prior behavior by once again removing the `subscribed`
flag for the bulk list of issues and merge requests and add a test to
ensure they aren't reintroduced.
Relates to https://gitlab.com/gitlab-org/gitlab-ce/issues/66202
|
|
- When renaming a column concurrently, drop any existing trigger before
attempting to create a new one.
When running migration specs multiple times (as it happens during
local development), the down method of previous migrations are called.
If any of the called methods contains a call to
rename_column_concurrently, a trigger will be created and not removed.
So, the next time a migration spec is run, if the same down method is
executed again, it will cause an error when attempting to create the
trigger (since it already exists). Dropping the trigger if it already
exists will prevent this problem.
|
|
Add to the service and migration both.
|
|
Resolve "Use Visual Review Tools NPM package"
See merge request gitlab-org/gitlab-ce!32159
|
|
Allow users to read pipelines for public projects
with public builds enabled without providing an access token.
|
|
- Introducting StageEvents to define the available events
- Define the event pairing rules, since some events are not compatible
- Express default Cycle Analytics stages with the event structure
|
|
Remove the visual review toolbar code
in favor of using the NPM package.
|
|
Adding gitaly feature flag for go implementation of get all lfs pointers
See merge request gitlab-org/gitlab-ce!31696
|
|
|
|
Add specs for new parameter and updated documentation as well.
|
|
Handle when server info doesn't have the storage in question
See merge request gitlab-org/gitlab-ce!32023
|
|
Eliminate Gitaly N+1 queries with notes API
See merge request gitlab-org/gitlab-ce!32089
|
|
|
|
CE: Update sort options for issues list
See merge request gitlab-org/gitlab-ce!31849
|
|
Add frozen_string_literal to lib part 2
See merge request gitlab-org/gitlab-ce!32094
|
|
Increase sort options for issues list from updated_at and create_at,
to include more options close to what is required in actual issue list
UI.
This helps us to use REST API for issues list with sorting capabilities
https://gitlab.com/gitlab-org/gitlab-ce/issues/57402
|
|
|
|
Similar to https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/31834,
we see that in https://gitlab.com/gitlab-org/gitlab-ce/issues/65957
there can be hundreds, even thousands, of Gitaly requests in the
`/api/:version/projects/:id/merge_requests/:noteable_id/notes` endpoint.
Previously, the API to retrieve notes generated hundreds of Gitaly calls
to determine whether a system note should be shown to the user. It did
this by:
1. Rendering the Markdown
2. Extracting cross-references from the Markdown
3. Issuing a Gitaly `FindCommit` RPC for every reference to validate
that the commit exists.
The last step is unnecessary because we don't need to display a commit
if the user doesn't have access to the project in the first place.
`RendersNotes#prepare_notes_for_rendering` is already used in
`MergeRequestsController`, which is why we don't see N+1 Gitaly calls
there. We use it here to optimize the note redaction process.
|
|
|
|
|
|
Root namespaces have storage statistics.
This commit allows namespace owners to get those stats via GraphQL
queries like the following one
{
namespace(fullPath: "a_namespace_path") {
rootStorageStatistics {
storageSize
repositorySize
lfsObjectsSize
buildArtifactsSize
packagesSize
wikiSize
}
}
}
|
|
|
|
|
|
feat: smime signed notification emails
See merge request gitlab-org/gitlab-ce!30644
|
|
'ee-2502-refactor-ee-app-assets-javascripts-approvals-components-approvers_select-vue-to-remove-approverusers' into 'master'
Add a new method to `Api.js`: `projectUsers`
See merge request gitlab-org/gitlab-ce!31801
|
|
|
|
Put cancelled job in DeadSet
See merge request gitlab-org/gitlab-ce!32070
|
|
Upgrade to gitaly 1.60.0 and uncomment get_commit_signatures feature flag
Closes #65991
See merge request gitlab-org/gitlab-ce!31981
|
|
This replicates Sidekiq behavior
of pushing dead job into DeadSet.
|
|
Ensure the evaluation of right-hand side expression always
results in the returning of an object or an empty String
|
|
Allow to interrupt running sidekiq jobs
See merge request gitlab-org/gitlab-ce!31818
|
|
Transform `CancelledError` into `JobRetry::Skip`
|
|
- Retry connection when it fails
- Properly shutdown daemon
- Stop monitor if the Exception is raised
- Properly guard exception handling
|
|
If we process message that is not designated to us
previously we would fire a separate Thread for that.
We don't need to do it. We can cheaply check if thread
is available, if it is, we can perform expensive operation
then.
|
|
This makes:
- very shallow `Middleware::Monitor` to only request tracking
of sidekiq jobs,
- `SidekiqStatus::Monitor` to be responsible to maintain persistent
connection to receive messages,
- `SidekiqStatus::Monitor` to always use structured logging
and instance variables
|
|
This adds a middleware to track all threads
for running jobs.
This makes sidekiq to watch for redis-delivered notifications.
This makes be able to send notification to interrupt
running sidekiq jobs.
This does not take into account any native code,
as `Thread.raise` generates exception once the control gets
back to Ruby.
The separate measure should be taken to interrupt gRPC, shellouts,
or anything else that escapes Ruby.
|
|
Adding, destroying and toggling emoji previously lacked services and
instead were performed through methods called on Awardable models.
This led to inconsistencies where relevant todos would be marked as done
only when emoji were awarded through our controllers, but not through
the API. Todos could also be marked as done when an emoji was being
removed.
Behaviour changes
- Awarding emoji through the API will now mark a relevant Todo as done
- Toggling an emoji off (destroying it) through our controllers will no
longer mark a relevant Todo as done
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/63372
|
|
- Added Gitlab::Ci::Config::Entry::Rules and Gitlab::Ci::Config::Entry::Rules:Rule
to handle lists of Rule objects to be evalauted for job inclusion
- Added `if:` and `changes:` as available Rules::Rule::Clause classes
- Added Rules handling logic to Seed::Build#included? with extra specs
- Use DisallowedKeysValidator to mutually exclude rules: from only:/except: on job config
|
|
Current `auth.log` uses `fullpath` and `ip`, while `api_json.log` uses
`remote_ip` and `path` for the same fields. Let's standardize these
namings to make it easier for people working with the data.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/66167
|
