| Age | Commit message (Collapse) | Author |
|---|
|
This is step one of resolving
https://gitlab.com/gitlab-org/gitlab-ce/issues/56838.
Here is what changed:
- Revert the security fix from bdee9e8412d.
- Do not leak repository information (tag name, commit) to guests in API
responses.
- Do not include links to source code in API responses for users that do
not have download_code access.
- Show Releases in sidebar for guests.
- Do not display links to source code under Assets for users that do not
have download_code access.
GET ':id/releases/:tag_name' still do not allow guests to access
releases. This is to prevent guessing tag existence.
|
|
Propagate DS_EXCLUDED_PATHS to dependency_scanning job,
and SAST_EXCLUDED_PATHS and SAST_BANDIT_EXCLUDED_PATHS to sast job.
This makes possible to excluded certains paths from SAST reports
and Dependency Scanning reports, respectively.
|
|
When creating a merge request for push options, there may be over 100
queries that are run to create a merge request. Even after we reduce the
number of queries by disabling the Sidekiq jobs, it appears we still
hover near this limit.
Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/11450
|
|
When this option is enabled, GitLab will create namespaces and service
accounts as usual. When disabled, GitLab wont create any project
specific kubernetes resources
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/56557
|
|
PackRefs is not an expensive gitaly call - we want to
call it more often (than as part of full `gc`) because
it helps to keep number of refs files small - too many
refs file may be a problem for deployments with
slow storage.
|
|
- Adds an endpoint on PipelinesController
- Adds a service that iterates over every build in a stage and
plays it.
- Includes 'play_manual' details on EntitySerializer
- Builds a new Stage state: PlayManual. An stage can take this status if
it has manual builds or an skipped, scheduled or manual status
- Includes FE modifications and specs
|
|
The new two-step Gitaly `Rebase` RPC yields the rebase commit SHA to the
client before proceeding with the rebase.
This avoids an issue where the rebase commit SHA was returned when the
RPC had fully completed, and in some cases this would be after the Rails
`post_receive` worker services had already run. In these situations,
the merge request did not yet have its rebase_commit_sha attribute set
introducing the possibility for bugs (such as previous approvals being
reset).
https://gitlab.com/gitlab-org/gitlab-ee/issues/5966
|
|
Resolve "Drop "projects"."ci_id" column"
Closes #27777
See merge request gitlab-org/gitlab-ce!27623
|
|
Include link to user and commit title.
Rearrange text
|
|
And remove Gitlab::Ci::Trace#deprecated_path as it relies on ci_id
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
|
|
Extends existing graphql's tracer with opentracing measurements. Because
it also adds Tracing::Graphql class (for opentracing), it also renames
Graphql::Tracing class to Graphql::GenericTracing to minimize confusion
with similar class names.
|
|
they are set
|
|
Make Gitlab::GlRepository#types an instance method
See merge request gitlab-org/gitlab-ce!27902
|
|
Updates the EnvironmentController#metrics_dashboard endpoint
to support a "dashboard" param, which can be used to specify
the filepath of a dashboard configuration from a project
repository. Dashboard configurations are expected to be
stored in .gitlab/dashboards/.
Updates dashboard post-processing steps to exclude custom
metrics, which should only display on the system dashboard.
|
|
feat: add option to define the Sentry Environment
See merge request gitlab-org/gitlab-ce!27091
|
|
Add client methods for FetchIntoObjectPool RPC
See merge request gitlab-org/gitlab-ce!27767
|
|
|
|
Gitaly's FetchIntoObjectPool RPC will idempotently fetch objects into an
object pool. If the pool doesn't exist, it will create an empty pool
before attempting the fetch. This change adds client code as well as
specs to cover this behavior.
|
|
Having this as an instance method makes it easier to override in the
prepended `EE` module.
If we try to override this method on the module itself, it would not
be overridden correctly, depending on the load order.
|
|
Use correct k8s namespace in Prometheus queries
See merge request gitlab-org/gitlab-ce!27812
|
|
|
|
|
|
Change comments to point to the new path of sidekiq-cluster
See merge request gitlab-org/gitlab-ce!27707
|
|
Use keyword args for databuilder push
See merge request gitlab-org/gitlab-ce!24088
|
|
|
|
'master'
Disallow read user scope to read project events
See merge request gitlab/gitlabhq!3067
|
|
In Rails 5, including `ActionView::Context` can have a significant and
hidden performance penalty because this module also includes
`ActionView::CompiledTemplates`. This means that any module that
includes ActionView::Context becomes a descendant of
`CompiledTemplates`.
When a partial is rendered for the first time, it runs
`ActionView::CompiledTemplates#module_eval`, which will evaluate a
string that defines a new method for that partial. For example, the
source of partial might be this string:
```
def _app_views_project_show_html_haml___12345(local_assigns, output)
"hello world"
end
```
When this string is evaluated, the Ruby interpreter will define the
method and clear the global method cache for all descendants of
`ActionView::CompiledTemplates`. Previous to this change, we
inadvertently made a number of modules fall into this category:
* GroupChildEntity
* NoteUserEntity
* Notify
* MergeRequestUserEntity
* AnalyticsCommitEntity
* CommitEntity
* UserEntity
* Kaminari::Helpers::Paginator
* CurrentUserEntity
* ActionView::Base
* ActionDispatch::DebugExceptions::DebugView
* MarkupHelper
* MergeRequestPresenter
After this change:
* Kaminari::Helpers::Paginator
* ActionView::Base
* ActionDispatch::DebugExceptions::DebugView
Each time a partial is rendered for the first time, all methods for
those modules will have to be redefined. This can exact a significant
performance penalty.
How bad is this penalty? Using the following benchmark script, we can
use DTrace to sample the Ruby interpreter:
```
Benchmark.bm do |x|
x.report do
1000.times do
ActionView::CompiledTemplates.module_eval("def testme\nend")
end
end
end
```
This revealed a 11x jump in the time spent in `core#define_method`
alone.
Rails 6 fixes this behavior by moving the `include CompiledTemplates`
into ActionView::Base so that including `ActionView::Context` doesn't
quietly affect other modules in this way.
Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/11198
|
|
Port changes for design management to CE
See merge request gitlab-org/gitlab-ce!27555
|
|
Before this commit the wrong namespace could have been used in
Prometheus queries for group-level installations.
|
|
Fix Profiler to work with Rails 5.1
Closes #61051
See merge request gitlab-org/gitlab-ce!27774
|
|
|
|
This ports the changes from
https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/10462/
to CE
|
|
`sidekiq-cluster` is moved from `bin/` to `ee/bin` in EE code. This
is a corresponding change in CE.
|
|
'60945-masked-variable-still-printed-in-log-output-on-gitlab-com' into 'master'
Resolve "Masked Variable still printed in log output on gitlab.com"
Closes #60945
See merge request gitlab-org/gitlab-ce!27768
|
|
Create dashboards endpoint & setup dashboard post-processing
Closes #60383
See merge request gitlab-org/gitlab-ce!27405
|
|
Ruby 5.1 now requires keyword arguments to pass along parameters and
headers for ActionDispatch::Integration::RequestHelpers.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/61051
|
|
This enables sending a chat message to Slack or Mattermost
upon a successful, failed, or canceled deployment
|
|
|
|
This new table will be used to store the external_dashboard_url which
allows users to add a link to their external dashboards (ex Grafana)
to the Metrics dashboard.
|
|
|
|
Fix #57351 - Add .NET Core YAML template
Closes #57351
See merge request gitlab-org/gitlab-ce!25604
|
|
Improve indent for cache paths
|
|
Improve indent and remove empty lines
|
|
|
|
Ensure that we only request blobs in one batch
Closes #60829
See merge request gitlab-org/gitlab-ce!27625
|
|
Get rid of the user_namespace API helper method
See merge request gitlab-org/gitlab-ce!27636
|
|
|
|
|
|
|
|
Updates the gitaly client to use path_bytes field instead of the
deprecated path field in list_last_commits_for_tree_response.
Also adds a test to guard against non-utf8 path data
|
