Age | Commit message (Collapse) | Author |
|
Fix no avatar not showing in user selection box
Closes #56268
See merge request gitlab-org/gitlab-ce!24346
|
|
|
|
Fix Bitbucket Server importer error handling
Closes #56154
See merge request gitlab-org/gitlab-ce!24343
|
|
Bump kubectl in Auto DevOps to 1.11.6
See merge request gitlab-org/gitlab-ce!24176
|
|
After upgrading to Ruby 2.5.3, we switched `URI.join` in favor of
`Gitlab::Utils.append_path`. However,
ActionController::Base.helpers.image_path can return a full URL if a CDN
host is present.
Rails provides a way to generate the full URL using the asset path, but
that doesn't appear to work because `request` is nil`.
Revert to the previous behavior to handle CDNs and relative URLs.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/56268
|
|
The importer would display a 500 error page if you attempted to import
using a non-existent DNS entry. This commit rescues known network issues
and consolidates them into
BitbucketServer::Connection::ConnectionError`. The previous error
handling in the paginator doesn't work because it returns a lazy
collection.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/56154
|
|
'master'
Improves restriction of multiple Kubernetes clusters via API
Closes #56110
See merge request gitlab-org/gitlab-ce!24251
|
|
We introduced releases_page feature flag.
Given this feature is deemed stable, we should remove
this flag before 19th.
|
|
Modifies authorize! method to accept a third param, and then use it in
combination with 'add_cluster' policy to appropriately restrict adding
multiple clusters
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/56110
|
|
|
|
'55628-artifacts-from-a-job-defined-after-a-parallel-job-are-not-downloaded' into 'master'
Resolve "Artifacts from a job defined after a `parallel` job are NOT downloaded"
Closes #55628
See merge request gitlab-org/gitlab-ce!24273
|
|
Use the latest major version that will support the current clusters on
GKE which is v1.10
|
|
|
|
|
|
|
|
Refactor artifact api endpoint
Closes #55445
See merge request gitlab-org/gitlab-ce!23582
|
|
Switch use of Rack::Request to ActionDispatch::Request
See merge request gitlab-org/gitlab-ce!24199
|
|
Backport of elastic-test-repos from EE
See merge request gitlab-org/gitlab-ce!24200
|
|
|
|
This reverts commit e65e184269bb27661c9a20658933e8482aa90b62, reversing
changes made to 646ba2418b630710edeaac94b57d08adf2771257.
|
|
Adjusts duplicated line when commenting on unfolded diff lines (in the bottom)
Closes #56051
See merge request gitlab-org/gitlab-ce!24201
|
|
|
|
Added feature to specify a custom Auto DevOps chart repository
Closes #55791
See merge request gitlab-org/gitlab-ce!24162
|
|
Useful for checking progress.
|
|
Import issues from CSV
Closes #49231
See merge request gitlab-org/gitlab-ce!23532
|
|
|
|
`project.latest_successful_builds_for(ref)` is being used to find a
single job all the time. This results into us having to call `find_by`
inside of the controller which violates our CodeReuse/ActiveRecord
rubocop rule.
Refactor `project.latest_successful_builds_for(ref)` to
`project.latest_successful_build_for(job_name, ref)` which will execute
the `find_by` inside of the model.
Also create `project.latest_successful_build_for!(job_name, ref)` which
raises an exception instead of returning nil.
|
|
Fix Bitbucket Server import only including first 25 pull requests
Closes #55914
See merge request gitlab-org/gitlab-ce!24178
|
|
Allow to include another project files
Closes #53903
See merge request gitlab-org/gitlab-ce!24101
|
|
This adds `project:, file:, ref:` specification support.
|
|
As mentioned in
https://gitlab.com/gitlab-org/gitlab-ee/issues/9035#note_129093444,
Rails 5 switched ActionDispatch::Request so that it no longer inherits
Rack::Request directly. A middleware that uses Rack::Request to
read the environment may see stale request parameters if
another middleware modifies the environment via ActionDispatch::Request.
To be safe, we should be using ActionDispatch::Request everywhere.
|
|
The change to paginate repos in
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/22825 caused the
paginator to stop after 25 pull requests because the limit was set to 25
if none was defined. To fix this, we should only stop if the limit has
actually been set and use the limit parameter to determine the maximum
number of items to process per page.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/55914
|
|
Add tests for the API and add a couple of tests
Add
revert
revert
|
|
Authorize against release not project
|
|
Load whole file in memory to simplify code
|
|
Also changes old calls to the service
|
|
Use BuildMetadata to store build configuration in JSONB form
See merge request gitlab-org/gitlab-ce!21499
|
|
Fix multipart attachments not uploading
Closes gitlab-ee#9035
See merge request gitlab-org/gitlab-ce!24170
|
|
Add API Support for Kubernetes integration
Closes #40473
See merge request gitlab-org/gitlab-ce!23922
|
|
Mixing and matching the use of Rack::Request and ActionDispatch::Request
in Rails 5 is bad, particularly if you have middleware that
manipulates or accesses environment variables.
`Gitlab::Middleware::Multipart` attempts to rewrite request parameters
to the proper values (e.g. replacing `data_file` with
`UploadedFile`). It does this by calling `Rack::Request#update_params`,
which essentially updates `env['rack.request.form_hash']`.
By changing to `ActionDispatch::Request`, the Go middleware was causing
the request parameters to be stored inside
`env['action_dispatch.request.request_parameters']`. Later calls to
`Rack::Request#update_params` would not have any effect because it would
attempt to update `env['rack.request.form_has']` instead of
`env['action_dispatch.request.request_parameters']`. As a result, the
controller still saw the old parameters.
Since the Go middleware appears to be using `ActionDispatch::Request`
for authorization methods, we can switch the multipart middleware to
use it too.
Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/9035
|
|
'4553-geo-hashed-storage-migration-failure-does-not-log-to-sentry-or-geo-log-well-ee' into 'master'
Backport of https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/8926
See merge request gitlab-org/gitlab-ce!24129
|
|
Adds the following initial CRUD endpoints for Clusters API:
- GET list of clusters
- GET specific cluster
- POST add existing cluster (mimic of "Add cluster")
- PUT update cluser
- DELETE destroy cluster
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/40473
|
|
|
|
Backport of https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/8926
|
|
Don't ignore conflicts in db/schema.rb
See merge request gitlab-org/gitlab-ce!24152
|
|
Expose `CI_API_V4_URL` CI/CD variable
Closes #54621
See merge request gitlab-org/gitlab-ce!23936
|
|
Include templates
Closes #53445
See merge request gitlab-org/gitlab-ce!23495
|
|
These are data columns that store runtime configuration
of build needed to execute it on runner and within pipeline.
The definition of this data is that once used, and when no longer
needed (due to retry capability) they can be freely removed.
They use `jsonb` on PostgreSQL, and `text` on MySQL (due to lacking
support for json datatype on old enough version).
|
|
It's not entirely clear to me why we were ignoring db/schema.rb in the
first place, but this should not be done now that we merge CE into EE
automatically. Doing so can lead to changes being thrown away in the
event of a conflict, which can then lead to EE pipelines failing.
|
|
Don't ingore the `gitlab.pot` in ee_compat_check
See merge request gitlab-org/gitlab-ce!24151
|