Age | Commit message (Collapse) | Author |
|
Fix for sidekiq metrics set cardinality growing unbounded
Closes #43424
See merge request gitlab-org/gitlab-ce!17235
|
|
|
|
|
|
|
|
Avoid slow File Lock checks when not used
Closes #43339
See merge request gitlab-org/gitlab-ce!17140
|
|
Resolve "Double closing system notes when closing issue with Merge Request"
Closes #32546 and #32564
See merge request gitlab-org/gitlab-ce!17035
|
|
The tracking issue if this causes problems is
https://gitlab.com/gitlab-org/gitaly/issues/1028
|
|
Fix squash rebase not working when diff contained encoded data
Closes gitlab-ee#4960
See merge request gitlab-org/gitlab-ce!17205
|
|
Also avoid double commit lookup during file lock check by reusing
memoized commits.
|
|
Fix Error 500 when viewing a commit with a GPG signature in Geo
Closes gitlab-ee#4825
See merge request gitlab-org/gitlab-ce!17207
|
|
into 'master'
Sanitize extra blank spaces used when uploading a SSH key
Closes #40552
See merge request gitlab-org/gitlab-ce!17138
|
|
Closes gitlab-org/gitlab-ee#4825
|
|
When the applied diff contains UTF-8 or some other encoded data, the diff
returned back from the git process may be in ASCII-8BIT format. Writing this
data to stdin may fail if the data because stdin expects this data to be in
UTF-8. By switching the output to binmode, we ensure that the diff will
always be written as-is.
Closes gitlab-org/gitlab-ee#4960
|
|
# modified: lib/gitlab/git/commit.rb
|
|
|
|
into 'master'
Resolve "Combine all rake based lints in one rake process in CI"
Closes #42050
See merge request gitlab-org/gitlab-ce!16732
|
|
|
|
|
|
Resolve "API endpoint for importing a project export"
Closes #41899
See merge request gitlab-org/gitlab-ce!17025
|
|
|
|
Set Asciidoctor outfilesuffix to default .adoc
Closes #43192 and #17602
See merge request gitlab-org/gitlab-ce!17125
|
|
Add documentation about how to provide a user to Gitlab::Profiler
See merge request gitlab-org/gitlab-ce!17169
|
|
Escape HTML entities in commit messages
Closes #42833
See merge request gitlab-org/gitlab-ce!17144
|
|
a user
|
|
|
|
'rd-43185-revert-sanitize-extra-blank-spaces-used-when-uploading-a-ssh-key' into 'master'"
This reverts commit e607fd796657afd214b8f25201919d3e33b3f35f.
|
|
|
|
|
|
Only check LFS integrity for first branch in push
Closes #41141
See merge request gitlab-org/gitlab-ce!17098
|
|
|
|
Without setting outfilesuffix Asciidoctor defaults to .html. When .html is used,
inter-document cross references do not work in Gitlab's repository / file renderer.
See more information from
http://asciidoctor.org/docs/user-manual/#navigating-between-source-files
and
http://asciidoctor.org/docs/user-manual/#inter-document-cross-references
|
|
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|
'39885-ensure-users-cannot-create-environments-with-leading-slashes' into 'master'
Resolve "Environment with starting slash in name causes error"
Closes #39885
See merge request gitlab-org/gitlab-ce!17071
|
|
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|
Resolve "Build Is Red: Admin > Users > Impersonation Tokens token creation allows creation of a token"
Closes gitlab-ee#4914
See merge request gitlab-org/gitlab-ce!17102
|
|
|
|
|
|
Respect description and visibility when creating project from template
Closes #42601
See merge request gitlab-org/gitlab-ce!16820
|
|
And use :migration tag to use deletion strategy, and to avoid caching tables, and to lock into a particular schema.
Attempting to fix intermittent spec errors `PG::UndefinedTable: ERROR: relation "public.untracked_files_for_uploads" does not exist`.
|
|
|
|
Allow including custom attributes in API responses
See merge request gitlab-org/gitlab-ce!16526
|
|
Add information about projects when searching in wiki_blobs, blobs, commits scopes
Closes #42934
See merge request gitlab-org/gitlab-ce!17095
|
|
API: Get refs for a particular commit
Closes #18014
See merge request gitlab-org/gitlab-ce!15026
|
|
|
|
|
|
Remove problematic LDAP::Person validation for new strategy
Closes #42412 and #42359
See merge request gitlab-org/gitlab-ce!16727
|
|
Remove Sentry reporting for query limiting
See merge request gitlab-org/gitlab-ce!17092
|
|
Using Sentry, while useful, poses two problems you have to choose from:
1. All errors are reported separately, making it easy to create issues
but also making it next to impossible to see other errors (due to the
sheer volume of threshold errors).
2. Errors can be grouped or merged together, reducing the noise. This
however also means it's (as far as I can tell) much harder to
automatically create GitLab issues from Sentry for the offending
controllers.
Since both solutions are terrible I decided to go with a third option:
not using Sentry for this at all. Instead we'll investigate using
Prometheus alerts and Grafana dashboards for this, which has the added
benefit of being able to more accurately measure the behaviour over
time.
Note that throwing errors in test environments is still enabled, and
whitelisting is still necessary to prevent that from happening (and that
in turn still requires that developers create issues).
|
|
Constructors shouldn't throw exceptions. We also learned that
different LDAP servers behave a bit unexpectedly sometimes -
returning attributes we didn't ask for, or returned attributes
with language subtypes.
|
|
|