Age | Commit message (Collapse) | Author |
|
`delete_all` doesn't support limit, so you'd need to subquery
that. And instead of subquerying with `where(id: query)`, it's better
to use an `INNER JOIN`. This method also works with MySQL, while
subquerying doesn't (without another layer of subquerying)
Reference:
https://stackoverflow.com/questions/17892762/mysql-this-version-of-mysql-doesnt-yet-support-limit-in-all-any-some-subqu/17892886#17892886
|
|
Fix rubocop Style/ZeroLengthPredicate
See merge request gitlab-org/gitlab-ce!21793
|
|
See merge request gitlab-org/gitlab-ce!21689
|
|
|
|
Add wrapper rake task to migrate all uploads to OS
Closes #51571
See merge request gitlab-org/gitlab-ce!21779
|
|
Remove EE-specific lines from Plan concerns
See merge request gitlab-org/gitlab-ce!21448
|
|
Add a rake task that will trigger gitlab:uploads:migrate rake task with
different possible arguments, one by one.
|
|
Respect the user commit email in more places
Closes #51564
See merge request gitlab-org/gitlab-ce!21773
|
|
|
|
Replace direct use of Gitlab::SQL::Union with a "from_union" method
Closes #51307
See merge request gitlab-org/gitlab-ce!21672
|
|
Add Gitaly diff stats RPC client
See merge request gitlab-org/gitlab-ce!21732
|
|
This adds a basic interface to fetch diff statistics given two SHAs.
It's a requirement for #49399 #20282 and #19232.
|
|
|
|
|
|
This commit adds the module `FromUnion`, which provides the class method
`from_union`. This simplifies the process of selecting data from the
result of a UNION, and reduces the likelihood of making mistakes. As a
result, instead of this:
union = Gitlab::SQL::Union.new([foo, bar])
Foo.from("(#{union.to_sql}) #{Foo.table_name}")
We can now write this instead:
Foo.from_union([foo, bar])
This commit also includes some changes to make this new setup work
properly. For example, a bug in Rails 4
(https://github.com/rails/rails/issues/24193) would break the use of
`from("sub-query-here").includes(:relation)` in certain cases. There was
also a CI query which appeared to repeat a lot of conditions from an
outer query on an inner query, which isn't necessary.
Finally, we include a RuboCop cop to ensure developers use this new
module, instead of using Gitlab::SQL::Union directly.
Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/51307
|
|
|
|
Support Kubernetes RBAC for GitLab Managed Apps for creating new clusters
Closes #29398
See merge request gitlab-org/gitlab-ce!21401
|
|
CE: Properly implement prepending for Concern
See merge request gitlab-org/gitlab-ce!21444
|
|
Fix object storage uploads not working with AWS v2
Closes gitlab-workhorse#181
See merge request gitlab-org/gitlab-ce!21731
|
|
Because we were passing query strings as symbols, the fog-aws storage
driver was omitting the uploadId and partNumber query strings
from the signature in multipart uploads. This fix makes AWS and Ceph work with
v2 signatures.
See: https://github.com/fog/fog-aws/blob/v3.0.0/lib/fog/aws/storage.rb#L733
Closes https://gitlab.com/gitlab-org/gitlab-workhorse/issues/181
|
|
commit using"
|
|
Feature: State filter for admin runners view
See merge request gitlab-org/gitlab-ce!19625
|
|
of ABAC/RBAC
This also solves the async nature of the automatic creation of default
service tokens for service accounts. It also makes explicit which
service account token we always use.
create cluster role binding only if the provider has legacy_abac
disabled.
|
|
Add create_secret to KubeClient
|
|
legacy_abac argument
Fix spec warning: removing `initialize' may cause serious problems
Actually verify that `service.create_cluster` is called with expected
request_body and other args
|
|
Add RuboCop cops to enforce code reusing rules
See merge request gitlab-org/gitlab-ce!21391
|
|
'42861-move-include-external-files-in-gitlab-ci-yml-from-starter-to-libre' into 'master'
Resolve "Move "include external files in .gitlab-ci.yml" from Starter to Libre"
Closes #42861
See merge request gitlab-org/gitlab-ce!21603
|
|
|
|
Remove Rugged and shell code from Gitlab::Git
Closes gitaly#1124
See merge request gitlab-org/gitlab-ce!21488
|
|
|
|
|
|
|
|
'51271-error-500-due-to-encoding-issues-when-when-attempting-to-access-issues-api' into 'master'
Resolve "Error 500 due to encoding issues when when attempting to access issues API"
Closes #51271
See merge request gitlab-org/gitlab-ce!21680
|
|
If doing a schema load, the post_migrations should also be marked as up,
even if SKIP_POST_DEPLOYMENT_MIGRATIONS was set, otherwise future
migration runs will be broken.
|
|
- utilize the 'out' method to output the 'fence_info',
which converts to utf8
- output 'sourcepos' again
|
|
|
|
Add ability to skip user email confirmation with API
Closes #50876
See merge request gitlab-org/gitlab-ce!21630
|
|
This whitelists all existing offenses for the various CodeReuse cops, of
which most are triggered by the CodeReuse/ActiveRecord cop.
|
|
|
|
|
|
|
|
|
|
However we still want to make ClassMethods work!
And we'll need to fix codes using the wrong include/prepend
along the way. There were a lot of misuses.
|
|
We should never be sloppy!
|
|
|
|
Resolve "Project export broken when avatar is set"
Closes #51318
See merge request gitlab-org/gitlab-ce!21649
|
|
|
|
|
|
This gives admins the ability to send a `skip_confirmation` flag in the
`POST /users/:id/email` API endpoint to skip the verification step and
assume the given e-mail address is verified.
Closes #50876
|
|
In a migration spec, a default ApplicationSetting object may fail to
create due to an unknown attribute and fall back to
FakeApplicationSetting. FakeApplicationSetting appears to be missing a
number of methods that are needed
(https://gitlab.com/gitlab-org/gitlab-ce/issues/47491). This commit adds
the ones needed to make an EE spec pass.
Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/7543
|