| Age | Commit message (Collapse) | Author |
|---|
|
This commit migrates events data in such a way that push events are
stored much more efficiently. This is done by creating a shadow table
called "events_for_migration", and a table called "push_event_payloads"
which is used for storing push data of push events. The background
migration in this commit will copy events from the "events" table into
the "events_for_migration" table, push events in will also have a row
created in "push_event_payloads".
This approach allows us to reclaim space in the next release by simply
swapping the "events" and "events_for_migration" tables, then dropping
the old events (now "events_for_migration") table.
The new table structure is also optimised for storage space, and does
not include the unused "title" column nor the "data" column (since this
data is moved to "push_event_payloads").
== Newly Created Events
Newly created events are inserted into both "events" and
"events_for_migration", both using the exact same primary key value. The
table "push_event_payloads" in turn has a foreign key to the _shadow_
table. This removes the need for recreating and validating the foreign
key after swapping the tables. Since the shadow table also has a foreign
key to "projects.id" we also don't have to worry about orphaned rows.
This approach however does require some additional storage as we're
duplicating a portion of the events data for at least 1 release. The
exact amount is hard to estimate, but for GitLab.com this is expected to
be between 10 and 20 GB at most. The background migration in this commit
deliberately does _not_ update the "events" table as doing so would put
a lot of pressure on PostgreSQL's auto vacuuming system.
== Supporting Both Old And New Events
Application code has also been adjusted to support push events using
both the old and new data formats. This is done by creating a PushEvent
class which extends the regular Event class. Using Rails' Single Table
Inheritance system we can ensure the right class is used for the right
data, which in this case is based on the value of `events.action`. To
support displaying old and new data at the same time the PushEvent class
re-defines a few methods of the Event class, falling back to their
original implementations for push events in the old format.
Once all existing events have been migrated the various push event
related methods can be removed from the Event model, and the calls to
`super` can be removed from the methods in the PushEvent model.
The UI and event atom feed have also been slightly changed to better
handle this new setup, fortunately only a few changes were necessary to
make this work.
== API Changes
The API only displays push data of events in the new format. Supporting
both formats in the API is a bit more difficult compared to the UI.
Since the old push data was not really well documented (apart from one
example that used an incorrect "action" nmae) I decided that supporting
both was not worth the effort, especially since events will be migrated
in a few days _and_ new events are created in the correct format.
|
|
Rename RPC 'Exists' to 'RepositoryExists'
See merge request !13277
|
|
Fix proxy config in Gitlab Pages nginx examples
See merge request !13375
|
|
Don't include anything to Kernel only because of tasks
Closes #36003
See merge request !13380
|
|
|
|
Enable the Layout/SpaceBeforeBlockBraces cop
See merge request !13413
|
|
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|
|
|
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|
Add rubocop-gitlab-security gem
See merge request !12177
|
|
Unset BUNDLE_GEMFILE when installing Gitaly
See merge request !13378
|
|
|
|
|
|
Incorporate Gitaly's CommitService.FindCommit RPC
Closes gitaly#402
See merge request !13094
|
|
Unfortunately rake doesn't have nested context,
everything just runs on a main rake object.
This is probably due to compatibility issue,
but anyway, we could just extend the object.
|
|
Raise encoding confidence threshold to 50
Closes #35098
See merge request !12990
|
|
|
|
Fix the /projects/:id/repository/commits endpoint to handle dots in the ref name…
Closes #15651
See merge request !13370
|
|
|
|
Restrict InlineJavaScript for haml_lint to dev and test environment
Closes omnibus-gitlab#2658
See merge request !13364
|
|
|
|
Fix the /projects/:id/repository/tags endpoint to handle dots in the tag name…
See merge request !13368
|
|
It is recommended that we set this to 50:
https://gitlab.com/gitlab-org/gitlab-ce/issues/35098#note_35036746
In this particular issue, the confidence was 42 for Shift JIS,
but in fact that's encoded in UTF-8 just with a single bad
character. In this case, we shouldn't try to treat it as Shift JIS,
but just treat it as UTF-8 and remove invalid bytes.
Treating it like Shift JIS would corrupt the whole data.
Unfortunately, the diff which would cause this could not be
disclosed therefore we can't use it as a test example.
|
|
name when the project full path contains a `/`
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|
name when the project full path contains a `/`
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|
'master'
Unset the `RUBYOPT` env variable before installing `gitaly-ruby`
Closes #35941 and #35967
See merge request !13313
|
|
|
|
* master: (86 commits)
Show all labels
33874 confidential issue redesign
Exclude merge_jid on Import/Export attribute configuration
Resolve "User dropdown in filtered search does not load avatar on `master`"
Re-add column locked_at on migration rollback
Group-level new issue & MR using previously selected project
[EE Backport] Update log audit event in omniauth_callbacks_controller.rb
more eagerly bail when the state is prevented
Move locked_at removal to post-deployment migration
Add class to other sidebars
Improve mobile sidebar
reduce iterations by keeping a count of remaining enablers
Store & use ConvDev percentages returned by Version app
Store MergeWorker JID on merge request, and clean up stuck merges
Backport changes in https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/2551 to CE
DRY up caching in AbstractReferenceFilter
Update CHANGELOG
Add CHANGELOG entry
Fix html structure Removes test for removed behavior
Port form back to use form_tag
...
|
|
|
|
This helps keep the abstraction layers simpler, and also keep the
interface of those methods consistent, in case of implementation
changes.
|
|
|
|
Resolve "Store MergeWorker JID on merge request, and clean up stuck merges"
Closes #31207
See merge request !13207
|
|
|
|
Migrate Repository#find_commits_by_message to Gitaly
Closes gitaly#443
See merge request !13268
|
|
Migrate Gitlab::Git::Repository#size to Gitaly
Closes gitaly#437
See merge request !13259
|
|
DeclarativePolicy: reduce iterations of the step set
See merge request !13352
|
|
* master: (177 commits)
Add changelog
Bump gitlab-shell version to 5.8.0 to fix Git for Windows 2.14
Make contextual sidebar collapsible
Fixed sidebar context header hover colors
Use correct `Environment`-class within `Gitlab` namespace
Remove gl.Activities from Commits page
Move `let` calls inside the `describe` block using them
Add `/assign me` alias support for assigning issuables to oneself
GRPC::Unavailable (< GRPC::BadStatus) is wrapped in a CommandError
Use `broken_storage` in the fs_shards_spec.
Eager load project creators for project dashboards
Memoize a user's personal projects count
Remove redundant query from User#recent_push
Improve checking if projects would be returned
Change spelling of gitlab-shell
Remove unused #tree-holder
Add custom linter for inline JavaScript to haml_lint
Rename user_can_admin? because it's more accurate
Synchronous zanata community contribution translation
Add Korean translation to i18n
...
|
|
Backport changes in https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/2551 to CE
Closes #21391
See merge request !13275
|
|
Add Gitlab::Git::Blob.batch method
See merge request !13225
|
|
|
|
rather than iterating the whole remaining step set with
.all?(&:prevent?)
|
|
Improve GitHub importer
Closes #27429
See merge request !12886
|
|
Allow projects to be started from a template
Closes #32420
See merge request !13108
|
|
Support group milestone references
Closes #34778
See merge request !13289
|
|
Set default options outside the raw_log method
See merge request !13346
|
|
https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/2551 to CE
|
|
We had a lot of copied and pasted code, when the different elements were very
small and easy to get wrong.
|
|
|
|
|
|
|
