Age | Commit message (Collapse) | Author |
|
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|
For the QA tests to use the new injection methods, we must require the
initializer and ensure that the "constantize" method is available.
|
|
|
|
Issue - https://gitlab.com/gitlab-org/quality/nightly/issues/127
|
|
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|
Remove test from quarantine
See merge request gitlab-org/gitlab-ce!31704
|
|
|
|
This pulls in fix for CVE-2019-5477, where usage of
Nokogiri::CSS::Tokenizer#load_file leads to potential command injection.
|
|
By defaulting to 3, there is unnecessary cost
involved
|
|
This reverts merge request !31379
|
|
Support X_if_ee methods for QA tests
See merge request gitlab-org/gitlab-ce!31379
|
|
For the QA tests to use the new injection methods, we must require the
initializer and ensure that the "constantize" method is available.
|
|
Fix push file size test
Closes gitlab-org/quality/nightly#113
See merge request gitlab-org/gitlab-ce!31321
|
|
|
|
And remove it from quarantine
|
|
Nodes spun up in Gcloud defaults to '3' nodes
This number can be a lot considering the QA
autodevops spec does not need this many nodes
|
|
QA spec for Auto DevOps should use 10GB GKE disk
See merge request gitlab-org/gitlab-ce!31266
|
|
This commit covers all the files that where changed in the
identically named branch on EE that is creating an elasticsearch
test case.
|
|
This was defaulting to 100GB according to
https://cloud.google.com/sdk/gcloud/reference/container/clusters/create#--disk-size
which is really not ideal since we haven't automated clean up per
https://gitlab.com/gitlab-org/gitlab-qa/issues/298
|
|
|
|
Move create group with mattermost spec to correct dir
See merge request gitlab-org/gitlab-ce!31173
|
|
All the changes done to files that are also inside CE and need to be
ported.
|
|
Many elements defined in the QA framework in ci_variable.rb
call elements and methods that are not framework specific.
Fix these issues, as well as use data-qa-selector s
|
|
|
|
|
|
CE port of "Fix spam in issue creation by making project private"
See merge request gitlab-org/gitlab-ce!30997
|
|
When used with a Hash, `.keys.include?` is bad because:
1. It performs a O(n) search instead of the efficient `.has_key?`
2. It clones all keys into separate array.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/64975
|
|
There should be no difference between jobs in package-and-qa.
Review apps should also be similar but there might be differences
if the runners have different resources.
|
|
CE port of EE branch qa-staging-61-fix-ee-project-templates-spec
See merge request gitlab-org/gitlab-ce!30835
|
|
|
|
|
|
|
|
|
|
|
|
Updates check_mentions_for_xss_spec to use admin token for creating the user
Closes gitlab-org/quality/staging#65
See merge request gitlab-org/gitlab-ce!30943
|
|
This is a first iteration to address the following issue:
https://gitlab.com/gitlab-org/quality/team-tasks/issues/168
Note: depends on
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/30945
|
|
Refactor collapse issue comments end-to-end test
See merge request gitlab-org/gitlab-ce!30902
|
|
|
|
This refactor:
- Moves the tests pre-conditions to a before blocks
- Creates an issue via the api for the second test to improve the
test suite performance
|
|
Better scope end-to-end test
See merge request gitlab-org/gitlab-ce!30897
|
|
Better scope another end-to-end test
See merge request gitlab-org/gitlab-ce!30896
|
|
To:
- Better separate scopes (pre-conditions on before, tests on it)
- Remove unnecessary expectation
- Replace other unnecessary expectations by page.assert_text
- Move variables closer to where they're used
|
|
Quarantine failing "rebase_merge_request_spec.rb"
See merge request gitlab-org/gitlab-ce!30933
|
|
Better scope end-to-end test
See merge request gitlab-org/gitlab-ce!30895
|
|
|
|
Refactor check mentions for xss test
See merge request gitlab-org/gitlab-ce!30914
|
|
The refactor consists in:
- Better scopping preconditions and the test definition
- Removing a variable that was being used in a single palce, and
use the string directly instead.
|
|
Move test pre-conditions to before block, and leave only the test
steps and verifications in the it block.
|
|
Move test pre-conditions to before block, remove unnecessary
expectation, and leave only the test steps and verifications
in the it block.
|
|
Move test pre-conditions to before block, and leave only the test
steps and verifications in the it block.
|