Age | Commit message (Collapse) | Author |
|
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|
|
|
|
|
|
|
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|
Also, play manual jobs once dependency jobs are done instead of polling
for the dependent jobs to be finished.
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|
Ensure that the cleanup starts right away.
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|
It seems the deploy function causes the job to fail if it doesn't
succeed. That wasn't the intent as we want to curl the Review App after
the deploy finished (even if it failed) because sometimes the Review App
is just a bit long to be ready.
This change wraps the Review App deployment with "set +e"/"set -e" to
ensure that the job doesn't fail right away if the deploy fails.
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|
Document ApplicationRecord / pluck_primary_key
Closes #59690
See merge request gitlab-org/gitlab-ce!26764
|
|
We also enable the rubocop that makes it mandatory
|
|
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|
DRYed the code
Changed new rules to warnings
Manual prettified and added stylelint rules
|
|
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|
Signed-off-by: Balasankar "Balu" C <balasankar@gitlab.com>
|
|
Signed-off-by: Balasankar "Balu" C <balasankar@gitlab.com>
|
|
|
|
Signed-off-by: Balasankar "Balu" C <balasankar@gitlab.com>
|
|
Instead of inserting a row after each example to an external database,
we save the CI profiling reports into the `rspec_profiling` directory
and insert the data in the update-tests-metadata CI stage. This should
make each spec run faster and also reduce the number of PostgreSQL
connections needed by concurrent CI builds.
`scripts/insert-rspec-profiling-data` also inserts one file at a time
via the PostgreSQL COPY command for faster inserts. The one side effect
is that the `created_at` and `updated_at` timestamps aren't available
since they aren't generated in the CSV.
Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/10154
|
|
This removes trailing commas from node scripts which previously
omitted them for compatiblity with node 6
|
|
This brings back some of the changes in
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/20339.
For users using Gitaly on top of NFS, accessing the Git data directly
via Rugged is more performant than Gitaly. This merge request introduces
the feature flag `rugged_find_commit` to activate Rugged paths.
There are also Rake tasks `gitlab:features:enable_rugged` and
`gitlab:features:disable_rugged` to enable/disable these feature
flags altogether.
Part of four Rugged changes identified in
https://gitlab.com/gitlab-org/gitlab-ce/issues/57317.
|
|
ChatOps used to be in the Ultimate tier.
|
|
* This will upload the sha of the docker image containing assets to
assist with building specific sha builds in the future.
* Addresses: https://gitlab.com/gitlab-org/release/framework/issues/51
|
|
This reverts commit 481938de847294018d202df13565c8dbc8a8ebc2.
|
|
* This will upload the sha of the docker image containing assets to
assist with building specific sha builds in the future.
* Addresses: gitlab-org/release/framework#51
|
|
this is to quickstart contributors who don't work daily on the codebase
|
|
Added stylelint to static-analysis
Updated yarn dependencies
CSS Fixes and rule adoptions of stylelint
Added stylelint-scss
Deduplicated yarn.lock to clear dependencies
|
|
"[[" Syntax is not supported on debian based systems.
|
|
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|
|
|
Also, pass GITLAB_VERSION and GITLAB_ASSETS_TAG to CNG triggered
pipelines.
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|
The function that retrieves the dependable job is pretty basic and
retrieves the first job found with the matching name, but this job can
be failed but then successfully retried. In that case, we would exit the
depending job even though the dependable job actually succeeded (the
second time). Let's simplify things, be optimistic and continue with the
depending job even if the dependable job fails.
That reverts to the original behavior.
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|
'55323-review-apps-use-2-replicas-for-the-tiller-deploy-deployment' into 'master'
[Review Apps] Use 2 replicas for the `tiller-deploy` Deployment
Closes #55323
See merge request gitlab-org/gitlab-ce!23806
|
|
Exit `wait_for_job_to_be_done` as error if the job fails
See merge request gitlab-org/gitlab-ce!23997
|
|
`--no-rdoc` and `--no-ri` have been deprecated since RubyGems 2.0:
https://github.com/rubygems/rubygems/blob/v2.0.0/History.txt#L43
They were finally removed in a recent release:
https://github.com/rubygems/rubygems/pull/2354
|
|
If a script is waiting for a job to be done and that job fails,
exit with an error status so that the script doesn't continue
with a prerequisite in an invalid state.
|
|
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|
Optionally compiling assets when needed for qa jobs proved
unworkable so instead we fall back on compiling them for
all qa jobs.
|
|
CE-EE parity for prepare_build script
See merge request gitlab-org/gitlab-ce!23819
|
|
|
|
This removes EE-only directives in favor of file existence checks.
|
|
The last usage of this variable was removed in
0ab6469187285368d9f64f9ec67dbbcfa3e5a901.
|
|
Signed-off-by: Rémy Coutable <remy@rymai.me>
|