Age | Commit message (Collapse) | Author | |
---|---|---|---|
2017-10-24 | correct the issues list count for label:none filter | Mike Greiling | |
2017-10-07 | Replaces `tag: true` into `:tag` in the specs | Jacopo | |
Replaces all the explicit include metadata syntax in the specs (tag: true) into the implicit one (:tag). Added a cop to prevent future errors and handle autocorrection. | |||
2017-09-23 | Improve list of sorting options | Vitaliy @blackst0ne Klachkov | |
2017-09-01 | Shorten the search input for "text with other filters" spec | Robert Speicher | |
The assignee wasn't important to the test, and shortening the query allowed us to avoid the "horizontal scroll" failure without having to stub the `sidebar_collapsed?` helper. | |||
2017-09-01 | Turns out that short name was important, who knew! | Robert Speicher | |
We now document that fact. | |||
2017-09-01 | Combine multiple `it` blocks in filter_issues_spec | Robert Speicher | |
2017-09-01 | Remove more redundant specs in filter_issues_spec | Robert Speicher | |
We were essentially testing "all of the filters" four times, so now we just do it once at the top level. | |||
2017-09-01 | Re-order top-level `let`s, so that labels are grouped | Robert Speicher | |
2017-09-01 | Remove unused select_search_at_index helper | Robert Speicher | |
2017-09-01 | Reduce duplication in RSS feed specs for filter_issues_spec | Robert Speicher | |
2017-09-01 | Remove the top-level closed issue from filter_issues_spec | Robert Speicher | |
2017-09-01 | Remove unused labels from filter_issues_spec | Robert Speicher | |
2017-09-01 | Reduce issues and milestones created in global filter_issues_spec setup | Robert Speicher | |
Three issues were only used in one test each, and one milestone with its accompanying issue were only used in one test, so we now scope those locally. | |||
2017-09-01 | Clean up the still-way-too-complex filter_issues_spec setup | Robert Speicher | |
Removes unnecessary `let!` usage since we explicitly access these in the `before. Re-uses `user2` as the author for issues we otherwise don't care about the author for, to avoid creating a new user in each one. Makes use of the `labeled_issue` factory to avoid assigning variables just so we can add labels to an issue. | |||
2017-09-01 | Remove an unnecessary issue creation | Robert Speicher | |
This seemed to only exist to increment an issue counter by 1. | |||
2017-09-01 | Remove unnecessary attributes from factories | Robert Speicher | |
2017-09-01 | Scope group creation to the specs that actually require it | Robert Speicher | |
Only one context tested group behavior, but we were performing group and membership creation on every example unnecessarily. | |||
2017-09-01 | Use a positive assertion for have_no_selector rather than the inverse | Robert Speicher | |
2017-09-01 | Remove unnecessary include from filter_issues_spec | Robert Speicher | |
2017-09-01 | Remove redundant specs from filter_issues_spec | Robert Speicher | |
While testing the various search tokens, we would add the token and a search term, then verify the correct issues were returned. Then we'd add a new token, search again, and verify again. Then another, and another. This was entirely redundant. If the search with higher specificity returned the same results as the search with lower specificity, we can be sure the lower specificity searches also worked without actually testing them. Because this entire spec performs very extensive setup, it's important to limit the number of times we perform that setup. | |||
2017-08-29 | spec updates | Phil Hughes | |
2017-08-29 | more spec fixes | Phil Hughes | |
2017-08-26 | Remove skipped examples in filtered issues feature spec | Robert Speicher | |
We perform a ton of expensive setup in this spec, via both `before` and `let!`. When we use `skip` inside an `it` block, rather than skipping the block entirely via `xit`, we still perform this expensive setup, only to do absolutely nothing with it, resulting in wasted time. Minutes, in this case. Further, these specs have been sitting in our test suite for about seven months now, so the likelihood of them being addressed soon seems low. | |||
2017-08-16 | Change find to within for detecting bad search specs | Clement Ho | |
2017-08-03 | Change all `:empty_project` to `:project` | Robert Speicher | |
2017-07-27 | Use `empty_project` where possible in spec/features/issues | Robert Speicher | |
2017-07-27 | Remove superfluous type defs in specs | Keifer Furzland | |
Signed-off-by: Rémy Coutable <remy@rymai.me> | |||
2017-07-05 | Create and use project path helpers that only need a project, no namespace | Douwe Maan | |
2017-06-29 | Clean up issuable lists | Taurie Davis | |
2017-06-07 | Use data attributes instead of class | Clement Ho | |
2017-06-06 | Fix rspec | Clement Ho | |
2017-06-02 | Style people in issuable search bar (!11402) | winh | |
2017-05-24 | atom links with rss token instead of private token | Alexis Reigel | |
2017-05-23 | Use wait_for_requests to wait all JS request | Oswaldo Ferreira | |
2017-05-04 | Fix eslint and rubocop | Clement Ho | |
2017-05-04 | Backport of multiple_assignees_feature [ci skip] | Valery Sizov | |
2017-04-26 | Add button to delete filters from filtered search bar | Clement Ho | |
2017-04-21 | Unnecessary "include WaitForAjax" and "include ApiHelpers" | Jacopo | |
Removed all the unnecessary include of `WaitForAjax` and `ApiHelpers` in the specs. Removed unnecessary usage of `api:true` | |||
2017-04-06 | Recent search history for issues | Eric Eastwood | |
Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/27262 | |||
2017-04-04 | Use `sign_in` instead of `login_as` when we're not testing login flow | Robert Speicher | |
This is a proof of concept for gitlab-org/gitlab-ce#30196. The actual login procedure is well-tested by `spec/features/login_spec.rb`, and we don't gain anything by also thoroughly testing it here, in our second-slowest feature spec. In fact, it only slows us down! So instead we use `sign_in` from the `Devise::Test::IntegrationHelpers` module, which just sets the current user at the Warden level. This drastically reduces the "setup" phase of every test in this file. A non-scientific test run saw this drop from 633 to 231 seconds. | |||
2017-04-04 | Ensure users have a short username otherwise a click event is triggered ↵ | Rémy Coutable | |
outside the search field Signed-off-by: Rémy Coutable <remy@rymai.me> | |||
2017-03-15 | Allow filtering by all started milestones | Sean McGivern | |
2017-03-08 | Code improvements | Clement Ho | |
2017-03-08 | Add filtered search visual tokens | Clement Ho | |
2017-02-21 | Add filtered search to MR page | Clement Ho | |
2017-02-11 | Enable the `RSpec/ExpectActual` cop and correct offenses | Robert Speicher | |
2017-02-08 | Remove sleep from tests | Clement Ho | |
2017-02-08 | Add tests | Alfredo Sumaran | |
2017-01-24 | Fix subscribe btn test | Annabel Dunstone Gray | |
2017-01-22 | update tests to correspond with new behavior | Mike Greiling | |