Welcome to mirror list, hosted at ThFree Co, Russian Federation.

gitlab.com/gitlab-org/gitlab-foss.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-10-24correct the issues list count for label:none filterMike Greiling
2017-10-07Replaces `tag: true` into `:tag` in the specsJacopo
Replaces all the explicit include metadata syntax in the specs (tag: true) into the implicit one (:tag). Added a cop to prevent future errors and handle autocorrection.
2017-09-23Improve list of sorting optionsVitaliy @blackst0ne Klachkov
2017-09-01Shorten the search input for "text with other filters" specRobert Speicher
The assignee wasn't important to the test, and shortening the query allowed us to avoid the "horizontal scroll" failure without having to stub the `sidebar_collapsed?` helper.
2017-09-01Turns out that short name was important, who knew!Robert Speicher
We now document that fact.
2017-09-01Combine multiple `it` blocks in filter_issues_specRobert Speicher
2017-09-01Remove more redundant specs in filter_issues_specRobert Speicher
We were essentially testing "all of the filters" four times, so now we just do it once at the top level.
2017-09-01Re-order top-level `let`s, so that labels are groupedRobert Speicher
2017-09-01Remove unused select_search_at_index helperRobert Speicher
2017-09-01Reduce duplication in RSS feed specs for filter_issues_specRobert Speicher
2017-09-01Remove the top-level closed issue from filter_issues_specRobert Speicher
2017-09-01Remove unused labels from filter_issues_specRobert Speicher
2017-09-01Reduce issues and milestones created in global filter_issues_spec setupRobert Speicher
Three issues were only used in one test each, and one milestone with its accompanying issue were only used in one test, so we now scope those locally.
2017-09-01Clean up the still-way-too-complex filter_issues_spec setupRobert Speicher
Removes unnecessary `let!` usage since we explicitly access these in the `before. Re-uses `user2` as the author for issues we otherwise don't care about the author for, to avoid creating a new user in each one. Makes use of the `labeled_issue` factory to avoid assigning variables just so we can add labels to an issue.
2017-09-01Remove an unnecessary issue creationRobert Speicher
This seemed to only exist to increment an issue counter by 1.
2017-09-01Remove unnecessary attributes from factoriesRobert Speicher
2017-09-01Scope group creation to the specs that actually require itRobert Speicher
Only one context tested group behavior, but we were performing group and membership creation on every example unnecessarily.
2017-09-01Use a positive assertion for have_no_selector rather than the inverseRobert Speicher
2017-09-01Remove unnecessary include from filter_issues_specRobert Speicher
2017-09-01Remove redundant specs from filter_issues_specRobert Speicher
While testing the various search tokens, we would add the token and a search term, then verify the correct issues were returned. Then we'd add a new token, search again, and verify again. Then another, and another. This was entirely redundant. If the search with higher specificity returned the same results as the search with lower specificity, we can be sure the lower specificity searches also worked without actually testing them. Because this entire spec performs very extensive setup, it's important to limit the number of times we perform that setup.
2017-08-29spec updatesPhil Hughes
2017-08-29more spec fixesPhil Hughes
2017-08-26Remove skipped examples in filtered issues feature specRobert Speicher
We perform a ton of expensive setup in this spec, via both `before` and `let!`. When we use `skip` inside an `it` block, rather than skipping the block entirely via `xit`, we still perform this expensive setup, only to do absolutely nothing with it, resulting in wasted time. Minutes, in this case. Further, these specs have been sitting in our test suite for about seven months now, so the likelihood of them being addressed soon seems low.
2017-08-16Change find to within for detecting bad search specsClement Ho
2017-08-03Change all `:empty_project` to `:project`Robert Speicher
2017-07-27Use `empty_project` where possible in spec/features/issuesRobert Speicher
2017-07-27Remove superfluous type defs in specsKeifer Furzland
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-07-05Create and use project path helpers that only need a project, no namespaceDouwe Maan
2017-06-29Clean up issuable listsTaurie Davis
2017-06-07Use data attributes instead of classClement Ho
2017-06-06Fix rspecClement Ho
2017-06-02Style people in issuable search bar (!11402)winh
2017-05-24atom links with rss token instead of private tokenAlexis Reigel
2017-05-23Use wait_for_requests to wait all JS requestOswaldo Ferreira
2017-05-04Fix eslint and rubocopClement Ho
2017-05-04Backport of multiple_assignees_feature [ci skip]Valery Sizov
2017-04-26Add button to delete filters from filtered search barClement Ho
2017-04-21Unnecessary "include WaitForAjax" and "include ApiHelpers"Jacopo
Removed all the unnecessary include of `WaitForAjax` and `ApiHelpers` in the specs. Removed unnecessary usage of `api:true`
2017-04-06Recent search history for issuesEric Eastwood
Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/27262
2017-04-04Use `sign_in` instead of `login_as` when we're not testing login flowRobert Speicher
This is a proof of concept for gitlab-org/gitlab-ce#30196. The actual login procedure is well-tested by `spec/features/login_spec.rb`, and we don't gain anything by also thoroughly testing it here, in our second-slowest feature spec. In fact, it only slows us down! So instead we use `sign_in` from the `Devise::Test::IntegrationHelpers` module, which just sets the current user at the Warden level. This drastically reduces the "setup" phase of every test in this file. A non-scientific test run saw this drop from 633 to 231 seconds.
2017-04-04Ensure users have a short username otherwise a click event is triggered ↵Rémy Coutable
outside the search field Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-03-15Allow filtering by all started milestonesSean McGivern
2017-03-08Code improvementsClement Ho
2017-03-08Add filtered search visual tokensClement Ho
2017-02-21Add filtered search to MR pageClement Ho
2017-02-11Enable the `RSpec/ExpectActual` cop and correct offensesRobert Speicher
2017-02-08Remove sleep from testsClement Ho
2017-02-08Add testsAlfredo Sumaran
2017-01-24Fix subscribe btn testAnnabel Dunstone Gray
2017-01-22update tests to correspond with new behaviorMike Greiling