Age | Commit message (Collapse) | Author |
|
|
|
|
|
|
|
See https://gitlab.com/gitlab-org/gitlab-ce/issues/45970
|
|
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|
|
|
There are several quick actions now that don't need this access - /todo and
/unsubscribe for instance - but when these were first added, there
weren't. Quick actions are now responsible for checking their own permissions.
|
|
|
|
autocomplete code
|
|
Replaces all the explicit include metadata syntax in the specs (tag:
true) into the implicit one (:tag).
Added a cop to prevent future errors and handle autocorrection.
|
|
More details are available here https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/13436/diffs#note_39115837
|
|
Update to add all issues to be updated.
Added functionality, proper tests, documentation and changelog.
|
|
|
|
|
|
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|
'master'
New `/duplicate` quick action
Closes #26372
See merge request !12845
|
|
|
|
|
|
Marking an issue as a duplicate will now also add an upvote on behalf of the author on the original issue.
|
|
|
|
For reasons that are still unclear, the EE version (but only the EE
version) of this spec was failing reliably, and changing these calls
seemed to resolve it. So we're making the change here for parity.
|
|
|
|
This was mistakenly added in 17196a2ff31 and is identical to the group
above it.
|
|
|
|
Change `logout_direct` uses to `gitlab_sign_out_direct`
|
|
Change single `login_via` use to `gitlab_sign_in_via`
|
|
Fix https://gitlab.com/gitlab-org/gitlab-ce/issues/27070
Deprecate "chat commands" in favor of "slash commands"
We looked for things like:
- `slash commmand`
- `slash_command`
- `slash-command`
- `SlashCommand`
|
|
|
|
Removed all the unnecessary include of `WaitForAjax` and `ApiHelpers` in the specs.
Removed unnecessary usage of `api:true`
|
|
|
|
|
|
|
|
It toggles the 'WIP' prefix in the MR title.
|
|
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|
|
|
|
|
|
|
methods
Other improvements:
- Ensure slash commands autocomplete doesn't break when noteable_type is not given
- Slash commands: improve autocomplete behavior and /due command
- We don't display slash commands for note edit forms.
- Add tests for reply by email with slash commands
- Be sure to execute slash commands after the note creation in Notes::CreateService
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|
Some important things to note:
- commands are removed from noteable.description / note.note
- commands are translated to params so that they are treated as normal
params in noteable Creation services
- the logic is not in the models but in the Creation services, which is
the right place for advanced logic that has nothing to do with what
models should be responsible of!
- UI/JS needs to be updated to handle notes which consist of commands
only
- the `/merge` command is not handled yet
Other improvements:
- Don't process commands in commit notes and display a flash is note is only commands
- Add autocomplete for slash commands
- Add description and params to slash command DSL methods
- Ensure replying by email with a commands-only note works
- Use :subscription_event instead of calling noteable.subscribe
- Support :todo_event in IssuableBaseService
Signed-off-by: Rémy Coutable <remy@rymai.me>
|