Welcome to mirror list, hosted at ThFree Co, Russian Federation.

gitlab.com/gitlab-org/gitlab-foss.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-12-27Fixing image lfs bug and also displaying text lfsFrancisco Javier López
This commit, introduced in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/23812, fixes a problem creating a displaying image diff notes when the image is stored in LFS. The main problem was that `Gitlab::Diff::File` was returning an invalid valid in `text?` for this kind of files. It also fixes a rendering problem with other LFS files, like text ones. They LFS pointer shouldn't be shown when LFS is enabled for the project, but they were.
2018-04-05Merge branch '42028-xss-diffs-10-6' into 'security-10-6'Douwe Maan
Port of "Fix XSS on commit diff view" for 10-6 See merge request gitlab/gitlabhq!2364
2018-01-09Fix changes dropdown ellipsis working across browsersPhil Hughes
Closes #41561
2017-09-12changed InlineDiffMarker to make it html_safe its outputmicael.bergeron
updated the spec
2017-08-17Don't escape html entities when rich == raw lineJarka Kadlecova
2017-08-01Ensure all project factories use `:repository` trait or `:empty_project`Robert Speicher
2017-07-28Fix diff commenting results just after changing viewSean McGivern
When you change the diff view (inline / side-by-side), we set a cookie based on that new view. When you add a comment, we choose the style to use in the response based on that cookie. However, when you have just changed diff style, the request cookie will contain the old value, so we should use the view param instead.
2017-06-19Don't display comment on unchanged line on both sides in parallel diffDouwe Maan
2017-06-14Implement diff viewersDouwe Maan
2017-06-01Merge branch 'fix_diff_line_comments' into 'master'Sean McGivern
Fix: A diff comment on a change at last line of a file shows as two comments in discussion Closes #32353 See merge request !11802
2017-06-01Fix rubocop in spec/helpers/diff_helper_spec.rbValery Sizov
2017-05-31Fix: A diff comment on a change at last line of a file shows as two comments ↵Valery Sizov
in discussion
2017-05-30Consistent diff and blob size limit namesDouwe Maan
2017-05-10Fix specsDouwe Maan
2017-02-02Active tense test coverageValery Sizov
Ports changes from https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/642 back into CE
2016-12-09Merge branch 'html-safe-diff-line-content' into 'security' Robert Speicher
Don't accidentally mark unsafe diff lines as HTML safe Fixes potential XSS issue when a legacy diff note is created on a merge request whose diff contained HTML See https://gitlab.com/gitlab-org/gitlab-ce/issues/25249 See merge request !2040
2016-11-04Remove an extra leading space from diff contentHiroyuki Sato
2016-08-09adds second batch of tests changed to active tensetiagonbotelho
2016-08-09fixes part1 of files to start using active tensetiagonbotelho
2016-08-04Add unfold links for Side-by-Side viewTim Masliuchenko
2016-08-03switch from diff_file_collection to diffsPaco Guzman
So we have raw_diffs too
2016-07-18Collapsed diffs lines/size don't accumulate to overflow diffs.Paco Guzman
2016-07-12Merge branch 'master' into faster-diffsJacob Schatz
2016-07-08Disable overflow messagesSean McGivern
With the option to expand and collapse individual diffs, these aren't needed any more.
2016-07-08Merge branch 'master' into faster-diffsDouwe Maan
# Conflicts: # app/helpers/notes_helper.rb # app/views/projects/diffs/_line.html.haml # app/views/projects/diffs/_parallel_view.html.haml # app/views/projects/diffs/_text_file.html.haml # features/steps/shared/diff_note.rb
2016-07-07Represent DiffRefs as proper class instead of tuple arrayDouwe Maan
2016-07-06fix up testsLuke "Jared" Bennett
Added more exceptions Added handling inline view type
2016-05-18Create DiffFilter and change SystemNoteService#change_title to use ↵Adam Butler
Gitlab::Diff::InlineDiff
2016-04-15Always read diff_view setting from the cookieRobert Speicher
Prior, when the user had their view set to "parallel" and then visited a merge request's changes tab _without_ passing the `view` parameter via query string, the view would be parallel but the `Notes` class was always instantiated with the default value from `diff_view` ("inline"), resulting in broken markup when the form to add a line note was dynamically inserted. The cookie is set whenever the view is changed, so this value should always be up-to-date. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/14557
2016-03-03Use Gitlab::Git::DiffCollectionsJacob Vosmaer
2016-01-30Fix specs and add a new oneDouwe Maan
2016-01-20Move parallel diff logic to separate classDouwe Maan
2016-01-15More refactoring from last code review. #3945Rubén Dávila
* Use commit objects instead of IDs when generating diffs * Use proper references when generating MR's source and target * Update broken specs
2016-01-09Fix broken specs. #3945Rubén Dávila
2016-01-09Fix broken specs. #3945Rubén Dávila
2015-12-31Fix broken spec and small refactor. #3945Rubén Dávila
2015-06-22Update mock and stub syntax for specsRobert Speicher
2015-05-21Disabled expansion of top/bottom blobs for new file diffsAlex Connor
2015-05-05Improve handling of large diffsAlex Lossent
Diffs with a large number of changed lines time out (504 HTTP error) or generate a HTML page that's so heavy web browsers struggle with it. https://github.com/gitlabhq/gitlabhq/pull/5014 introduced limits on commit line count so that only a safe portion is rendered. This was later undone by code refactoring in be5b6db8, e0eb4803 and c741fcab. This patch re-introduces a safe limit on number of lines.
2015-04-24Use project.commit convenience method.Douwe Maan
2015-02-12Even more hound fixesJeroen van Baarsen
Signed-off-by: Jeroen van Baarsen <jeroenvanbaarsen@gmail.com>
2015-02-12Updated rspec to rspec 3.x syntaxJeroen van Baarsen
Signed-off-by: Jeroen van Baarsen <jeroenvanbaarsen@gmail.com>
2014-09-12Fix diff_helper spec.Marin Jankovski
2014-09-09Add diff_helper spec.Marin Jankovski