| Age | Commit message (Collapse) | Author |
|---|
|
When opening the IDE on a project where the user doesn't have push
access, we create a fork and then redirect back to the IDE. To make
sure the user can actually commit, we need to open the IDE in the forked
project rather than the upstream project.
|
|
[CE] Upgrade to Rails 5.2
See merge request gitlab-org/gitlab-ce!30052
|
|
Resolve "Follow up: Simplify sort direction logic"
Closes #60798
See merge request gitlab-org/gitlab-ce!30443
|
|
(cherry picked from commit 1e8bdd01bff96122fe80c51fa8f024f18675b58b)
|
|
Updates changed method names and fixes spec failures
|
|
Minor refactor specs
|
|
Refactor sort direction icon
|
|
Added tests with project_list_filter_bar set to off
Added tests for projects_sort_option_titles
Refactor project sort options hash
|
|
|
|
Fix `simple_format` undefined error #60179
Closes #60179
See merge request gitlab-org/gitlab-ce!30366
|
|
Converted storage details into a small partial
Reworded the storage details summary as suggested
Updated pot file
|
|
`simple_format` is not defined in ActionView::Helpers::TagHelper, but
it is actually located in ActionView::Helpers::TextHelper.
The solution is to include the correct helper.
I've also added tests for `#markup_unsafe` because they were missing.
|
|
Currently, we label items to be done as "Todo." This is grammatically
incorrect and (therefore) confusing—especially to our Spanish-speaking
users for whom "todo" has a specific and unrelated meaning.
We should use "To Do" and always use it as singular (not "To Dos").
Updates to wording in a few places per MR (ee) discussion
Updating locale/gitlab.pot
Updates to wording in a few places per MR (ee) discussion
Updating locale/gitlab.pot
|
|
Add new onboarding to flipper A/B testing
See merge request gitlab-org/gitlab-ce!30125
|
|
Prior to https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/29889,
only the project context were set for the Markdown renderer. For a note
on an issuable, the group context was set to `nil` because
`note.noteable.try(:group)` attempted to get the issuable's group, which
doesn't exist.
To make group notifications work, now both the project and group context
are set. The context gets passed to `RelativeLinkFilter`, which
previously assumed that it wasn't possible to have both a group and a
project in the Markdown context. However, if a group were defined, it
would take precedence, and the URL rendered for uploads would be
`/group/-/uploads` instead of `/group/project/uploads/`. This led to
404s in e-mails.
However, now that we have both project and group in the context, we
render the Markdown giving priority to the project context if is set.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/63910
|
|
OnboardingExperimentHelpers take care of
determining if the current_user should or should
not see the new onboarding feature.
|
|
RecaptchaExperimentHelper contains helper methods
to assist in the controller and view layers.
|
|
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
|
|
This saves about 5 SQL calls per page if no custom appearance is
specified.
|
|
Fixed inconsistencies in variable names for deployment
endpoints for monitoring dashboard which causes
deployment rocket icons to disappear
|
|
Update frontend code to use /-/ scope for milestones and labels routes
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
|
|
If the default, instance-wide visibility were set to internal but a
group were private, the radio button would be set on internal even
though that setting were not allowed. We now consider the allowed
visibility setting for the group in determining what the default should
be.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/62298
|
|
Use Redis for CacheMarkDownField on non AR models
Closes #54140
See merge request gitlab-org/gitlab-ce!29054
|
|
Helps build a hash of snowplow tracking data attrs.
Updates import project pane to use new helper.
|
|
This allows using `CacheMarkdownField` for models that are not backed
by ActiveRecord.
When the including class inherits `ActiveRecord::Base` we include
`Gitlab::MarkdownCache::ActiveRecord::Extension`. This will cause the
markdown fields to be rendered and the generated HTML stored in a
`<field>_html` attribute on the record. We also store the version
used for generating the markdown.
All other classes that include this model will include the
`Gitlab::MarkdownCache::Redis::Extension`. This add the `<field>_html`
attributes to that model and will generate the html in them. The
generated HTML will be cached in redis under the key
`markdown_cache:<class>:<id>`. The class this included in must
therefore respond to `id`.
|
|
There are no namespaces in the strings so we don't need those
|
|
Move some project routes under - scope
See merge request gitlab-org/gitlab-ce!28830
|
|
|
|
- On Operations settings page
- On Metrics dashboard page
|
|
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
|
|
Since label presenter is used in label index view, label class
check doesn't work as expected because the class is now LabelPresenter.
Also `label.subject` doesn't work as expected now because Label's model
`subject` method is shadowed by Gitlab's presenter's method which uses
`subject` for referencing the original object.
Instead we use a presenter's method for both checks now.
`label_deletion_confirm_text` is not used anywhere so it's removed
|
|
This helper is used for extracting part of the issue / MR / whatever
description for use in the description meta tag:
1. To do that, we look at the source of the Markdown description.
2. We then strip out all HTML tags.
3. And then take the first 30 words.
Doing that can be really slow - especially as Markdown is supposed to be
treated as plain text. There are many better ways to do this, but the
immediate performance fix is to swap steps 2 and 3. This does mean that
the description may be less than 30 words (or even empty), but it is
much faster when the description is very long.
|
|
Part of single codebase changes.
|
|
issue
|
|
Resolve CE/EE diffs in new proj member import
See merge request gitlab-org/gitlab-ce!28254
|
|
Resolve CE/EE diffs in app/views/layouts view
Closes gitlab-ee#6647
See merge request gitlab-org/gitlab-ce!28197
|
|
Part of single codebase changes.
|
|
Part of single codebase changes.
|
|
Part of single codebase changes.
|
|
Un-nest title variable output
Update spec test names
Rename sort_value_most_stars -> sort_value_stars_desc
Rename sorted_by_stars -> sorted_by_stars_desc
Renname sort_value_most_stars_asc -> sort_value_stars_asc
Invert feature check, assign feature condition to a variable
Inline conditional nav bar rendering
Invert conditional label
Added follow up task
Fix filters returning 0 projects show the wrong view
Move click action out of test expectation
Use proper variable name for project in before block
Rename projects_sort_admin_options_hash
Renamed projects_sort_admin_options_has to
old_projects_sort_options_hash as its not only used
on the admin screen
Fix extra whitespace errors
Stub project_list_filter_bar in the projects_helper specs
Added follow up task for `show_projects?`
Removed url test expectations
|
|
This new field will allow to keep track of the storage used by the
packages features, it provides also aggregation at namespace level.
|
|
When rendering a label we want to check 'scoped_label' feature
availability on a project/group where label is being used. For
this reason a label presenter is used in UI and information about
context project/group is passed to this presenter.
|
|
Add columns to store project creation settings
Add project creation level column in groups
and default project creation column in application settings
Remove obsolete line from schema
Update migration with project_creation_level column existence check
Rename migrations to avoid conflicts
Update migration methods
Update migration method
|
|
[CE] Add mutually exclusive labels
See merge request gitlab-org/gitlab-ce!26804
|
|
- rewords examples starting with 'should'
- rewords examples starting with 'it'
Note: I had to manually fixup "onlies" to "only"
|
|
Check this feature per project/group instead of globally.
Also do not show tooltip if it's disabled.
|
|
- Add controls for sorting by title and date
- Execute Gitaly call which now accepts sorting params for wikis
|
|
into feature/webide_escaping
|
|
|
|
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
