Age | Commit message (Collapse) | Author | |
---|---|---|---|
2020-07-20 | Add latest changes from gitlab-org/gitlab@13-2-stable-ee | GitLab Bot | |
2020-05-26 | Add latest changes from gitlab-org/security/gitlab@13-0-stable-ee | GitLab Bot | |
2019-08-22 | Add frozen_string_literal to lib part 2 | Thong Kuah | |
Using the sed script from https://gitlab.com/gitlab-org/gitlab-ce/issues/59758 | |||
2019-05-29 | Hide password on import by url form | Igor Drozdov | |
2019-04-05 | Autocorrect with RSpec/ExampleWording cop | Thong Kuah | |
- rewords examples starting with 'should' - rewords examples starting with 'it' Note: I had to manually fixup "onlies" to "only" | |||
2018-12-09 | Only allow strings in URL::Sanitizer.valid? | Stan Hu | |
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/55079 | |||
2018-07-19 | Escape username and password in UrlSanitizer#full_url | Stan Hu | |
If a user uses a password with certain characters (e.g. /, #, +, etc.) UrlSanitizer#full_url will generate an invalid URL that cannot be parsed properly by Addressable::URI. If used with UrlBlocker, this will be flagged as an invalid URI. | |||
2018-07-10 | Properly handle colons in URL passwords | Stan Hu | |
Before b46d5b13ecb8e0c0793fa433bff7f49cb0612760, we relied on `Addressable::URI` to parse the username/password in a URL, but this failed when credentials contained special characters. However, this introduced a regression where the parsing would incorrectly truncate the password if the password had a colon. Closes #49080 | |||
2017-10-03 | Remove those tests as they're not needed anymore | Lin Jen-Shin | |
Because now addressable would consider them invalid anyway. | |||
2017-09-29 | Just allow the scheme we want! | Lin Jen-Shin | |
2017-09-29 | Adapt to the latest addressable behaviour | Lin Jen-Shin | |
2017-09-11 | Backport more EE changes to Gitlab::UrlSanitizer | Nick Thomas | |
2017-09-06 | Remove blank passwords from sanitized URLs | Nick Thomas | |
2017-09-06 | Backport EE fixes to Gitlab::UrlSanitizer to CE | Nick Thomas | |
2017-07-27 | Remove superfluous lib: true, type: redis, service: true, models: true, ↵ | Rémy Coutable | |
services: true, no_db: true, api: true Signed-off-by: Rémy Coutable <remy@rymai.me> | |||
2017-05-30 | Don't allow to pass a user to ProjectWiki#http_url_to_repo | Rémy Coutable | |
This partially reverts be25bbc4d2c7e3d5cf3da6f51cb7f7355295ef52. Signed-off-by: Rémy Coutable <remy@rymai.me> | |||
2017-03-20 | Fix ProjectWiki#http_url_to_repo signature | Rémy Coutable | |
New Gitlab::UrlSanitizer.http_credentials_for_user method responsible for generating a credentials hash from a user. Signed-off-by: Rémy Coutable <remy@rymai.me> | |||
2017-03-10 | Fix for creating a project through API when import_url is nil | Toon Claes | |
The API was returning 500 when `nil` is passed for the `import_url`. In fact, it was `Gitlab::UrlSanitizer.valid?` which was throwing a `NoMethodError` when `nil` value was passed. | |||
2016-07-11 | spec and fix for sanitize method | James Lopez | |
2016-07-01 | Enable Style/EmptyLines cop, remove redundant ones | Grzegorz Bizon | |
2016-05-19 | Mask credentials from URL when import of project has failed. | Rubén Dávila | |