| Age | Commit message (Collapse) | Author |
|---|
|
|
|
|
|
After trying to remove the whole method in
8f69014af2902d8d53fe931268bec60f6858f160, this is a more gentle
approach to the method. :)
Prior to this change, new commit detection wasn't implemented in Gitaly,
this was done through: https://gitlab.com/gitlab-org/gitaly/merge_requests/779
As the new implemented got moved around a bit, the whole RevList class
got removed.
Part of https://gitlab.com/gitlab-org/gitaly/issues/1233
|
|
|
|
|
|
|
|
|
|
Use root ref instead of HEAD to find latest repository commit
Closes gitlab-ee#5864
See merge request gitlab-org/gitlab-ce!20258
|
|
Expire correct method caches after HEAD changed
Closes #44725
See merge request gitlab-org/gitlab-ce!20102
|
|
|
|
|
|
|
|
|
|
Closes https://gitlab.com/gitlab-org/gitaly/issues/889
|
|
|
|
|
|
|
|
Fix Xcode project detection by looking for dirs instead of files
See merge request gitlab-org/gitlab-ce!19035
|
|
|
|
|
|
Prior to this change, a feature flag could be used to disable this
feature. Now all requests go through Gitaly's OperationService.
Closes https://gitlab.com/gitlab-org/gitaly/issues/540
When vendoring `Gitlab::Git` again in Gitaly, this implemenation will be
gone, but this is readded there through:
https://gitlab.com/gitlab-org/gitaly/merge_requests/717
|
|
|
|
|
|
|
|
Has been in opt out for 5 months, and within GitLab been in production
for longer than that.
No code needs to be migrated as this is implemented in GoLang over at
Gitaly.
Closes https://gitlab.com/gitlab-org/gitaly/issues/314
|
|
|
|
|
|
|
|
Cache `#can_be_resolved_in_ui?` git operations
Closes gitaly#1051
See merge request gitlab-org/gitlab-ce!17589
|
|
Remove double caching of Repository#empty?
Closes #43882
See merge request gitlab-org/gitlab-ce!17588
|
|
We saw that in a customer instance, `empty?` was cached to be `true` even
though `has_visible_content?` and `exists?` were `true`. This double caching
can run into edge cases because there's no guarantee that the inner values
will properly expire the outer one, especially if there is Redis replication lag.
Consider this scenario:
1. `exists?` and `has_visible_content?` are false
2. `empty?` is expired
3. A subsequent call to `empty?` returns `true` because `exists?` is false even though `empty` is true
4. `exists?` and `has_visible_content?` are then expired
5. `exists?` and `has_visible_content?` are set to true
6. `empty?` is still stuck in the wrong value as `true`
Closes #43882
|
|
|
|
|
|
|
|
|
|
We removed the exception handling for Rugged errors in !16770, which
revealed that the licensee gem attempts to retrieve a license file
via Rugged in `refs/heads/master` by default. If that branch
did not exist, a Rugged::ReferenceError would be thrown.
There were two issues:
1. Not every project uses `master` as the default branch. This
change uses the head commit to identify the license.
2. Removing the exception handling caused repositories to fail
loading. We can safely catch and ignore any Rugged error because
this means we weren't able to load a license file.
Closes #43268
|
|
|
|
Client changes for Tag,BranchNamesContainingCommit
See merge request gitlab-org/gitlab-ce!16789
|
|
'fix/remove-duplicated-logic-between-model-and-lib-in-find-branch' into 'master'
Remove repo reloading logic from Repository#find_branch
Closes #42609
See merge request gitlab-org/gitlab-ce!16815
|
|
Gitlab::Git::Repository#find_branch has a similar logic.
Fixes #42609
|
|
As part of gitlab-org/gitaly#884, this commit contains the client
implementation for both TagNamesContaintingCommit and
BranchNamesContainingCommit. The interface in the Repository model stays
the same, but the implementation on the serverside, e.g. Gitaly, uses
`for-each-ref`, as opposed to `branch` or `tag` which both aren't
plumbing command. The result stays the same.
On the serverside, we have the opportunity to limit the number of names
to return. However, this is not supported on the front end yet. My
proposal to use this ability: gitlab-org/gitlab-ce#42581. For now, this
ability is not used as that would change more behaviours on a feature
flag which might lead to unexpected changes on page refresh for example.
|
|
|
|
|
|
|
|
with missing side
|
|
Resolve "Cannot search with keyword "merge""
Closes #41666
See merge request gitlab-org/gitlab-ce!16462
|
|
A file containing /:\d+:/ in its contents would break the search results if
those contents were part of the results, because we were splitting on colons,
which can't work with untrusted input.
Changing to use the null byte as a separator is much safer.
|
|
|
|
|
|
|
