| Age | Commit message (Collapse) | Author |
|---|
|
'master'
Do not allow to use `CI_PIPELINE_ID` in environment name
Closes #46443
See merge request gitlab-org/gitlab-ce!19032
|
|
Resolve "Runner#contacted_at is not always a Time type"
Closes #46082
See merge request gitlab-org/gitlab-ce!18810
|
|
Resolve "CI/CD jobs: Wrong value in env. variable CI_DEPLOY_USER using <gitlab-deploy-token> deploy token"
Closes #46454
See merge request gitlab-org/gitlab-ce!19047
|
|
|
|
|
|
Migrate Repo#search_by_{content,name} to Gitaly
See merge request gitlab-org/gitlab-ce!18750
|
|
It was using name, instead of username. Fixes documentation as well
Closes #46454
|
|
|
|
|
|
Do not allow to trigger manual actions that were skipped
Closes #42589
See merge request gitlab-org/gitlab-ce!18985
|
|
|
|
|
|
Resolve "Estimating a large amount results in a server error 500"
Closes #46193
See merge request gitlab-org/gitlab-ce!18964
|
|
|
|
|
|
Improve performance of Projects::PipelinesController#index
See merge request gitlab-org/gitlab-ce!18427
|
|
Resolve "NoMethodError: undefined method `present' for #<GenericCommitStatus:0x00007f6eacf34a40>"
Closes #46177
See merge request gitlab-org/gitlab-ce!18979
|
|
When displaying the pipelines of a project we now preload the following
data:
1. Authors of the commits that belong to these pipelines
2. The number of warnings per pipeline, which is used by
Ci::Pipeline#has_warnings?
== Commit Authors
Previously this data was queried for every Commit separately, leading to
20 SQL queries being executed in the worst case. With an average of 3 to
5 milliseconds per SQL query this could result in 100 milliseconds being
spent in _just_ getting Commit authors.
To preload this data Commit#author now uses BatchLoader (through
Commit#lazy_author), and a separate module
Gitlab::Ci::Pipeline::Preloader is used to ensure all authors are loaded
before they are used.
== Number of warnings
This changes Ci::Pipeline#has_warnings? so it supports preloading of the
number of warnings per pipeline. This removes the need for executing a
COUNT(*) query for every pipeline just to see if it has any warnings or
not.
|
|
|
|
|
|
error page"
|
|
Workhorse to send raw diff and patch for commits
Closes gitaly#1196
See merge request gitlab-org/gitlab-ce!18974
|
|
Also moves the assertions were they belong
|
|
This reverts commit 4e1bb1d1014237df79db6b3cc2beb24228a4b228.
|
|
Delete remote uploads
Closes #45425
See merge request gitlab-org/gitlab-ce!18698
|
|
API support + Improved policies for group runners
Closes #45894 and #38979
See merge request gitlab-org/gitlab-ce!18851
|
|
|
|
|
|
|
|
Move Gitlab::Git::Repository#add_branch to mandatory
Closes gitaly#540
See merge request gitlab-org/gitlab-ce!18939
|
|
Prior to this change, this was done through unicorn. In theory this
could time out. Workhorse has been sending these raw patches and diffs
for a long time and is stable in doing so.
Added bonus is the fact that `Commit#to_patch` can be removed.
`Commit#to_diff` too, which closes
https://gitlab.com/gitlab-org/gitaly/issues/324
Closes https://gitlab.com/gitlab-org/gitaly/issues/1196
|
|
|
|
|
|
ObjectStore uploader requires presence of associated `uploads` record
when deleting the upload file (through the carrierwave's after_commit
hook) because we keep info whether file is LOCAL or REMOTE in `upload`
object.
For this reason we can not destroy uploads as "dependent: :destroy" hook
because these would be deleted too soon. Instead we rely on
carrierwave's hook to destroy `uploads` in after_commit hook.
But in before_destroy hook we still have to delete not-mounted uploads
(which don't use carrierwave's destroy hook). This has to be done in
before_Destroy instead of after_commit because `FileUpload` requires
existence of model's object on destroy action.
This is not ideal state of things, in a next step we should investigate
how to unify model dependencies so we can use same workflow for all
uploads.
Related to #45425
|
|
|
|
methods
Includes Presentable module into CommitStatus. This fixes presenter
methods being called on those classes.
Closes #46177
|
|
into 'master'
Add a unique and not null constraint on the project_features.project_id column
Closes #37882
See merge request gitlab-org/gitlab-ce!18925
|
|
This commit has two migrations:
1. The first prunes duplicate rows in the project_features table and leaves
the row with the highest ID. Since the behavior was indeterministic before
and depended on which row the database decided to use, this change at least
makes the permissions consistent. For example, in some cases, the Wiki may
have been disabled but enabled in another entry.
2. The second adds a non-null constraint on the project_features.project_id
column.
Closes #37882
Fixes a significant part of gitlab-com/migration#408.
We found that we were overcounting Wikis because of these duplicates.
On GitLab.com, there are 56 rows with duplicate entries by project_id, and 16,661 rows with NULL project_id values.
|
|
|
|
|
|
|
|
Prior to this change, a feature flag could be used to disable this
feature. Now all requests go through Gitaly's OperationService.
Closes https://gitlab.com/gitlab-org/gitaly/issues/540
When vendoring `Gitlab::Git` again in Gitaly, this implemenation will be
gone, but this is readded there through:
https://gitlab.com/gitlab-org/gitaly/merge_requests/717
|
|
|
|
|
|
|
|
Block access to API & git when terms are enforced
Closes #45849
See merge request gitlab-org/gitlab-ce!18816
|
|
'ce-5911-extract-ee-specific-files-lines-for-spec-models-clusters' into 'master'
Backport EE specific cluster spec changes to CE
See merge request gitlab-org/gitlab-ce!18866
|
|
'master'
Ensure runner_type is updated correctly when assigning shared runner to project
See merge request gitlab-org/gitlab-ce!18874
|
|
ShaAttribute crashes with ArgumentError if column doesn't exist
See merge request gitlab-org/gitlab-ce!18880
|
|
When terms are enforced, but the user has not accepted the terms
access to the API & git is rejected with a message directing the user
to the web app to accept the terms.
|
