Age | Commit message (Collapse) | Author | |
---|---|---|---|
2020-02-19 | Add latest changes from gitlab-org/gitlab@master | GitLab Bot | |
2020-02-10 | Add latest changes from gitlab-org/gitlab@master | GitLab Bot | |
2020-02-04 | Add latest changes from gitlab-org/gitlab@master | GitLab Bot | |
2020-01-29 | Add latest changes from gitlab-org/gitlab@master | GitLab Bot | |
2020-01-15 | Add latest changes from gitlab-org/gitlab@master | GitLab Bot | |
2020-01-02 | Add latest changes from gitlab-org/gitlab@master | GitLab Bot | |
2019-12-27 | Add latest changes from gitlab-org/gitlab@master | GitLab Bot | |
2019-12-19 | Add latest changes from gitlab-org/gitlab@master | GitLab Bot | |
2019-12-16 | Add latest changes from gitlab-org/gitlab@masterogolowinski-master-patch-80898 | GitLab Bot | |
2019-12-05 | Add latest changes from gitlab-org/gitlab@master | GitLab Bot | |
2019-12-01 | Add latest changes from gitlab-org/gitlab@master | GitLab Bot | |
2019-11-28 | Add latest changes from gitlab-org/gitlab@master | GitLab Bot | |
2019-11-25 | Add latest changes from gitlab-org/gitlab@master | GitLab Bot | |
2019-11-21 | Add latest changes from gitlab-org/gitlab@master | GitLab Bot | |
2019-11-07 | Add latest changes from gitlab-org/gitlab@master | GitLab Bot | |
2019-10-29 | Add latest changes from gitlab-org/gitlab@master | GitLab Bot | |
2019-10-18 | Add latest changes from gitlab-org/gitlab@master | GitLab Bot | |
2019-10-16 | Add latest changes from gitlab-org/gitlab@master | GitLab Bot | |
2019-10-03 | Add latest changes from gitlab-org/gitlab@master | GitLab Bot | |
2019-09-18 | Add latest changes from gitlab-org/gitlab@master | GitLab Bot | |
2019-09-13 | Add latest changes from gitlab-org/gitlab@master | GitLab Bot | |
2019-09-13 | Add latest changes from gitlab-org/gitlab@master | GitLab Bot | |
2019-09-10 | Add Scalability/FileUploads cop | Alessio Caiazza | |
This cop prevents you from using file in API, it points you to the development documentation about workhorse file acceleration. | |||
2019-08-28 | Fix InjectEnterpriseEditionModule cop for qa/ | Yorick Peterse | |
This ensures the InjectEnterpriseEditionModule cop is able to detect the prepend patterns used in the qa/ directory. Previously it would not detect them as all EE QA modules reside in QA::EE, and not the top-level EE namespace. | |||
2019-08-28 | Replace it_behaves_like with include_examples | Vitali Tatarintev | |
Improve specs output readability by replacing `it_behaves_like` with `include_examples` in `BeSuccessMatcher` | |||
2019-08-28 | Remove Rubocop::SpecHelper file | Vitali Tatarintev | |
2019-08-28 | Inline shared examples for BeSuccessMatcher | Vitali Tatarintev | |
Former shared examples were used only once. Inlining them makes tests more clear. | |||
2019-08-28 | Refactor BeSuccessMatcher specs for readability | Vitali Tatarintev | |
2019-08-28 | Utilize Rubocop's Include for BeSuccessMatcher | Vitali Tatarintev | |
Use Rubocop's Include instead of manually checking the matcher in controllers specs. | |||
2019-08-28 | Add support of not_to/to_not to BeSuccessMatcher | Vitali Tatarintev | |
BeSuccessMatcher now supports following examples: ``` expect(response).to be_success expect(response).to_not be_success expect(response).not_to be_success is_expected.to be_success is_expected.to_not be_success is_expected.not_to be_success ``` | |||
2019-08-28 | Refactor BeSuccessMatcher specs | Vitali Tatarintev | |
2019-08-28 | Replace double quotes with single quotes | Vitali Tatarintev | |
2019-08-28 | Enable frozen string literal | Vitali Tatarintev | |
2019-08-28 | Autocorrect `be_success` to `be_successful` | Vitali Tatarintev | |
2019-08-28 | Add Rubocop check to avoid using `be_success` | Vitali Tatarintev | |
Prevent using `be_success` call in controller specs to avoid getting following deprecation warning: ``` DEPRECATION WARNING: The success? predicate is deprecated and will be removed in Rails 6.0. Please use successful? as provided by Rack::Response::Helpers. ``` | |||
2019-08-26 | Utilize RuboCop's Include/Exclude config | Peter Leitzen | |
Stop checking the file location programmatically. | |||
2019-08-24 | Adds cop to enforce string limits on migrations | Mayra Cabrera | |
This cop will analyze migrations that add columns with string, and report an offense if the string has no limit enforced Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/64505 | |||
2019-08-01 | Add RSpec/TopLevelDescribePath cop | Sean McGivern | |
The RSpec/FilePath cop checks that a spec file's path is correct, but only if the file describes a constant. We want to check, for any file with a top-level `describe`, whether the file path ends in `_spec.rb`. We don't care what comes before that; just that it will be executed by RSpec at all. | |||
2019-07-30 | Extend cop for verifying injecting of EE modules | Yorick Peterse | |
This extends the InjectEnterpriseEditionModule RuboCop cop so that it verifies the following: 1. The line number the injection occurs on (as before). 2. The method used (e.g. prepend instead of prepend_if_ee). 3. The argument type passed when using the new module injection methods. | |||
2019-07-11 | Change element_with_pattern cop to not use quotes | ddavison | |
Using quotes within string validations can be messy. Let's use a typical CSS selector for an unquoted attribute Update the cop spec to validate appropriate new message | |||
2019-07-10 | Add a rubocop for Rails.logger | Mayra Cabrera | |
Suggests to use a JSON structured log instead Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/54102 | |||
2019-06-21 | Add a cop to ensure we authorize GraphQL types | Bob Van Landuyt | |
2019-05-28 | Merge branch 'qa-extend-click-visit-actions' into 'master' | Dan Davison | |
Implement dynamic validation on QA Pages Closes gitlab-qa#280 See merge request gitlab-org/gitlab-ce!25704 | |||
2019-05-22 | Link to issue in CodeReuse/ActiveRecord message | Luke Duncalfe | |
This provides the user with some context as to why certain ActiveRecord methods are blacklisted. | |||
2019-05-20 | Implement dynamic validation on QA Pages | ddavison | |
Elements now have the ability to be required on pages or not Currently using the default wait mechanism Altered the ElementWithPattern Cop to fit new splat for init | |||
2019-04-29 | Add Rubocop rule to ban include ActionView::Context | Stan Hu | |
2019-04-15 | Forbid the use of `#reload` and prefer `#reset` | Kamil TrzciĆski | |
The `#reload` makes to load all objects into memory, and the main purpose of `#reload` is to drop the association cache. The `#reset` seems to solve exactly that case. | |||
2019-03-28 | Properly handle `ee` migration specs | Heinrich Lee Yu | |
2019-01-16 | Fix detecting nested EE constants in RuboCop | Yorick Peterse | |
The InjectEnterpriseEditionModule cop would not detect certain nested EE constants such as `EE::Foo::Bar::Baz`. This could result in it not enforcing `prepend` being placed on the last line. This commit fixes this by just performing a string match on the line, instead of relying on AST matching. | |||
2018-12-13 | Added Cop for injecting EE modules | Yorick Peterse | |
This Cop enforces the rule that injecting EE modules (using prepend, include, or extend) is done by placing the injection on the last line of a file, instead of somewhere in the middle. By placing these lines at the very end, merge conflicts will not happen. |