| Age | Commit message (Collapse) | Author |
|---|
|
This enables sending a chat message to Slack or Mattermost
upon a successful, failed, or canceled deployment
|
|
This new table will be used to store the external_dashboard_url which
allows users to add a link to their external dashboards (ex Grafana)
to the Metrics dashboard.
|
|
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|
Introduce ServiceResponse to wrap around response
Closes #60730
See merge request gitlab-org/gitlab-ce!27516
|
|
Upgrade Rails to 5.1
See merge request gitlab-org/gitlab-ce!27480
|
|
|
|
Model.new.attributes now also returns encrypted attributes.
|
|
|
|
See https://gitlab.com/gitlab-org/gitlab-ce/issues/60730
|
|
The return result for the source or target branch being missing was
ambiguous before. It should be an empty compare to indicate no
comparison could be done.
|
|
'60500-disable-jit-kubernetes-resource-creation-for-project-level-clusters' into 'master'
Disable JIT Kubernetes resource creation for project level clusters
Closes #60500
See merge request gitlab-org/gitlab-ce!27352
|
|
Using custom_action and recipient filtering
Add more generic filtering to user_ids_notifiable_on
Add changelog entry
Remove commented class
Method is no longer needed
Overloading no longer required
Filter by action just in case of custom notification level
Add participant check
Fix unexpected extra notification mails
Using custom_action and recipient filtering
Add more generic filtering to user_ids_notifiable_on
Add changelog entry
Remove commented class
Method is no longer needed
Overloading no longer required
Filter by action just in case of custom notification level
Fix comment
Add repond_to? checks
Reverted custom_action filtering
Enhanced output of should_email helper
Changed :watch to :participating for custom notifiable users
Change spec variable name
Enhanced participating check
These conditions are no longer needed
Fix custom notification handling for participating type
Participating level should include maintainers
Fixed add_guest notification
Fix successful pipeline notification
Refactoring: Use maintainer? method on team instead
Add spec for new_issue: true for a custom group setting
which should have lower prio than an available project setting
Clean up specs
|
|
Backport metrics report type
See merge request gitlab-org/gitlab-ce!26798
|
|
This backports the changes from
https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/10452
|
|
If no pipeline is created we currently have IID gap.
This is due to fact that we generate IID not on save,
but rather ahead of time. This results, us,
losing IIDs.
|
|
JIT resource creation blocks deployments if a user is
self-managing their cluster, as it will fail the build
if unable to create a namespace and service account.
Using a custom namespace and service account was previously
supported for project level clusters, so we should preserve
this functionality.
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/27352
|
|
Properly expire all pipeline caches when pipeline is deleted
Closes #60469
See merge request gitlab-org/gitlab-ce!27334
|
|
When deleting a pipeline, only some of the cache structures were being
expired, but not the full pipeline list. We have to synchronously
schedule a pipeline cache expiration because the pipeline will be
deleted if the Sidekiq expiration job picks it up. To do this, properly
extract all the logic buried in the Sidekiq worker into a service, and
then call the service.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/60469
|
|
https://gitlab.com/gitlab-org/gitlab-ce/issues/60480
|
|
'master'
Always return the deployment in the UpdateDeploymentService#execute method
Closes gitlab-ee#11124
See merge request gitlab-org/gitlab-ce!27322
|
|
Add frozen_string_literal to spec/services
See merge request gitlab-org/gitlab-ce!27267
|
|
|
|
Fix typo in activity lease
See merge request gitlab-org/gitlab-ce!27288
|
|
As this are un-expected errors which we should hear about from Sentry.
Still rescue StandardError when operating a Helm action as we can get
non Kubeclient errors such as SSL certificate or network errors
|
|
Added changelog and rebased
|
|
|
|
Probably useful as we often move these files to "new" files.
|
|
ALso makes it consistent with EE
|
|
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|
|
|
With multiple MR assignees, `merge_request.assignee_id` is always nil,
and `merge_request.assignee_ids` isn't in `merge_request.attributes`.
So the existing code doesn't set assignees in the created MR.
This fix gets all the tests passing, but we should also check that no
other associations in the MergeRequest need similar fixups.
|
|
Set pages_domain.remove_at when disabling it
Add specs for marking pages domain for removal
Notify user that domain is being removed
Add documentation
|
|
spec/features/groups/group_page_with_external_authorization_service_spec to EE
|
|
[Backport] Support multiple assignees for merge requests
See merge request gitlab-org/gitlab-ce!27089
|
|
Git push options to create a merge request, set target_branch and set merge when pipeline succeeds
Closes #53198 and #43263
See merge request gitlab-org/gitlab-ce!26752
|
|
Fix the bug that the project statistics is not updated
See merge request gitlab-org/gitlab-ce!26854
|
|
Create pipelines for merge requests **only** when source branch is updated
See merge request gitlab-org/gitlab-ce!26921
|
|
Also set the release sha and author
|
|
This will ensure that now and in the future, PushOptionsHandlerService
will not cause the post_receive API endpoint from running other code if
something causes an unknown exception.
|
|
Exceptions are no longer raised, instead all errors encountered are
added to the errors property.
MergeRequests::BuildService is used to generate attributes of a new
merge request.
Code moved from Api::Internal to Api::Helpers::InternalHelpers.
|
|
MergeRequests::PushOptionsHandlerService has been updated to allow
creating and updating merge requests with the
`merge_when_pipeline_succeeds` set using git push options.
To create a new merge request and set it to merge when the pipeline
succeeds:
git push -u origin -o merge_request.create \
-o merge_request.merge_when_pipeline_succeeds
To update an existing merge request and set it to merge when the
pipeline succeeds:
git push -u origin -o merge_request.merge_when_pipeline_succeeds
Issue https://gitlab.com/gitlab-org/gitlab-ce/issues/53198
|
|
Previously the raw push option Array was sent to Pipeline::Chain::Skip.
This commit updates this class (and the chain of classes that pass the
push option parameters from the API internal `post_receive` endpoint to
that class) to treat push options as a Hash of options parsed by
GitLab::PushOptions.
The GitLab::PushOptions class takes options like this:
-o ci.skip -o merge_request.create -o merge_request.target=branch
and turns them into a Hash like this:
{
ci: {
skip: true
},
merge_request: {
create: true,
target: 'branch'
}
}
This now how Pipeline::Chain::Skip is determining if the `ci.skip` push
option was used.
|
|
Backports https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/10161
(code out of ee/ folder).
|
|
To create a new merge request:
git push -u origin -o merge_request.create
To create a new merge request setting target branch:
git push -u origin -o merge_request.create \
-o merge_request.target=123
To update an existing merge request with a new target branch:
git push -u origin -o merge_request.target=123
A new Gitlab::PushOptions class handles parsing and validating the push
options array. This can be the start of the standard of GitLab accepting
push options that follow namespacing rules. Rules are discussed in issue
https://gitlab.com/gitlab-org/gitlab-ce/issues/43263.
E.g. these push options:
-o merge_request.create -o merge_request.target=123
Become parsed as:
{
merge_request: {
create: true,
target: '123',
}
}
And are fetched with the class via:
push_options.get(:merge_request)
push_options.get(:merge_request, :create)
push_options.get(:merge_request, :target)
A new MergeRequests::PushOptionsHandlerService takes the `merge_request`
namespaced push options and handles creating and updating
merge requests.
Any errors encountered are passed to the existing `output` Hash in
Api::Internal's `post_receive` endpoint, and passed to gitlab-shell
where they're output to the user.
Issue https://gitlab.com/gitlab-org/gitlab-ce/issues/43263
|
|
CE: Extract EE specific files/lines for Discussion spec/services
See merge request gitlab-org/gitlab-ce!26950
|
|
Extract a Git::HooksService
Closes #15463
See merge request gitlab-org/gitlab-ce!26726
|
|
|
|
Currently, pipelines for merge requests are triggered when source or
target branch is updated. However, we should create only when source
branch is updated, because it runs unexpected pipelines.
|
|
Prior this commit exceptions raised during a HTTP request
weren't caught by the Sentry client and were passed to the user.
In addition the Sentry client tried to catch a non-existent error
`Sentry::Client::SentryError`.
Now, the Sentry client catches all possible errors coming from
a HTTP request.
|
|
|
