| Age | Commit message (Collapse) | Author |
|---|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
RailsHelpers.stub_rails_env takes care of
stubbing Rails.env
|
|
It performs an expensive operation, but isn't required in
most of tests
|
|
|
|
In f59438c0a9da7bb4d98291d2adedfc5a13a50798 we changed how quarantined
specs are excluded. But that made it impossible to run them by
providing `--tag quarantine`, this changes that.
|
|
|
|
Server Side Request Forgery mitigation bypass
Closes #2872
See merge request gitlab/gitlabhq!3205
|
|
These are not required because MySQL is not
supported anymore
|
|
None of this code can be reached any more, so it can all be removed
|
|
Use correct parent when committing in WebIDE
See merge request gitlab-org/gitlab-ce!29598
|
|
When passing start_branch on committing from the WebIDE, it's possible
that the branch has changed since editing started, which results in the
change being applied on top of the latest commit in the branch and
overwriting the new changes.
By passing the start_sha instead we can make sure that the change is
applied on top of the commit which the user started editing from.
|
|
Whenever we use the rugged implementation, we are going straight to disk
so we want to bypass the disk access check.
|
|
When we can't resolve the hostname or it is invalid, we shouldn't
even perform the request. This fix also fixes the problem the
SSRF rebinding attack.
We can't stub feature flags outside example blocks. Nevertheless,
there are some actions that calls the UrlBlocker, that are performed
outside example blocks, ie: `set` instruction.
That's why we have to use some signalign mechanism outside the scope
of the specs.
|
|
Use transactions in JS feature specs
Closes #60207
See merge request gitlab-org/gitlab-ce!27496
|
|
Log memory stats after running each spec file and compile the report.
|
|
Uses Rails transactional tests instead of DatabaseCleaner
transaction strategy because that doesn't work with JS tests
|
|
Loading `ApplicationSetting` from Redis was responsible for at least 50%
of the CPU load of the Redis cluster on GitLab.com. Since these values
generally don't change very much, we can load this from the database and
cache it in memory, skipping Redis altogther. We use
`ActiveSupport::Cache::MemoryStore` as a drop-in replacement for
`RedisCacheStore` even though we probably don't need synchronized access
within `Thread.current`.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/63977
|
|
When the SQL query cache is active, the SELECT query for finding
projects to apply service templates returns the same values. This causes
an infinite loop because even though bulk INSERT queries are made, the
cached results never reflect that progress. To fix this, we call
`Project.uncached` around the query to ensure new data is retrieved.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/63595
|
|
This reverts commit 744f1f2e7037f5c70c3168d9e2e89b1c327465d2, reversing
changes made to c4d930e5f54e7da07c80cc028dfc0f5c08719146.
|
|
This reverts merge request !27514
|
|
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|
Since we're skipping the example in a before hook, the @_subscribers
instance variable that is normally set in the setup phase of the test by
https://github.com/rails/rails-controller-testing/blob/21014e48be124dd8d0af250b79f682519d445015/lib/rails/controller/testing/template_assertions.rb#L21
isn't set but the teardown phase of the example still happens and tries
to iterate over the array of subcribers: https://github.com/rails/rails-controller-testing/blob/21014e48be124dd8d0af250b79f682519d445015/lib/rails/controller/testing/template_assertions.rb#L54
Using an around hook allows the @_subscribers instance variable to be
set.
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|
|
|
Attempt to debug https://gitlab.com/gitlab-org/gitlab-ce/issues/60953
|
|
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|
It was 2*4 => 8 times before, so 4 times is still half retries
|
|
In both e2e QA tests and unit tests, reduce the number of retires
to 2 (i.e., 1 initial and one retry)
|
|
Add no-op license helper to CE
See merge request gitlab-org/gitlab-ce!26723
|
