Welcome to mirror list, hosted at ThFree Co, Russian Federation.

gitlab.com/gitlab-org/gitlab-foss.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
path: root/spec
AgeCommit message (Collapse)Author
2018-10-09Resolve "Harmonize prettier and eslint configs"Mike Greiling
2018-10-09Merge branch 'sh-handle-invalid-comparison' into 'master'Douwe Maan
Reject invalid branch names in repository compare controller Closes #51003 See merge request gitlab-org/gitlab-ce!22186
2018-10-09Merge branch 'rails5-user-status-spec' into 'master'Sean McGivern
Rails5: fix user edit profile clear status spec See merge request gitlab-org/gitlab-ce!22169
2018-10-08Reject invalid branch names in repository compare controllerStan Hu
Closes #51003
2018-10-08Merge branch 'osw-remove-dead-code-on-mr-show' into 'master'Robert Speicher
Removes expensive dead code on main MR page request Closes #51172 See merge request gitlab-org/gitlab-ce!22153
2018-10-08Clean up ActiveRecord code in TodoServiceYorick Peterse
This refactors the TodoService class according to our code reuse guidelines. The resulting code is a wee bit more verbose, but it allows us to decouple the column names from the input, resulting in fewer changes being necessary when we change the schema. One particular noteworthy line in TodoService is the following: todos_ids = todos.update_state(state) Technically this is a violation of the guidelines, because `update_state` is a class method, which services are not supposed to use (safe for a few allowed ones). I decided to keep this, since there is no alternative. `update_state` doesn't produce a relation so it doesn't belong in a Finder, and we can't move it to another Service either. As such I opted to just use the method directly. Cases like this may happen more frequently, at which point we should update our documentation with some sort of recommendation. For now, I want to refrain from doing so until we have a few more examples.
2018-10-08Clean up ActiveRecord code in TodosFinderYorick Peterse
This refactors the TodosFinder finder according to the new code reuse rules, as enforced by the CodeReuse cops. I also changed some of the methods to use regular if statements, instead of assignments and/or early returns. This results in a more natural flow when reading the code, and it makes it harder to accidentally return the wrong result.
2018-10-08Merge branch 'Fix-pipeline-redirect' into 'master'Grzegorz Bizon
Redirect to the pipeline builds page when a build is canceled Closes #39161 See merge request gitlab-org/gitlab-ce!21595
2018-10-08Merge branch 'rails5-mysql-schedule-build' into 'master'Douwe Maan
Rails 5: fix mysql milliseconds problems in scheduled build specs See merge request gitlab-org/gitlab-ce!22170
2018-10-08Merge branch 'increase-event-retention-prune-old-events-worker' into 'master'Douwe Maan
Prune events older than 2 years instead of 12 months See merge request gitlab-org/gitlab-ce!22145
2018-10-08Merge branch 'backport-ce-to-ee-spec-fix' into 'master'Rémy Coutable
Fix issues controller N+1 failure See merge request gitlab-org/gitlab-ce!22141
2018-10-06Merge branch 'bw-fix-checking-disabled-services' into 'master'51761-create-new-project-auto-populate-project-slug-string-to-project-name-if-name-is-emptyStan Hu
Check disabled_services when finding a service See merge request gitlab-org/gitlab-ce!22172
2018-10-06Check disabled_services when finding a serviceBrett Walker
2018-10-06Fix invalid parent path on group settings pageDmitriy Zaporozhets
2018-10-06Add button to insert table in markdown editorGeorge Tsiolis
2018-10-06Rails 5: fix mysql milliseconds problems in scheduled build specsJasper Maes
2018-10-06Rails5: fix user edit profile clear status specJasper Maes
2018-10-06Fix LFS uploaded images not being renderedOswaldo Ferreira
2018-10-06Merge branch 'ee-7126-admin-projects-geo-status' into 'master'Douglas Barbosa Alexandre
EE Backport: enable Geo Status widget in admin/projects See merge request gitlab-org/gitlab-ce!22161
2018-10-06Remove dead code on main MR pageOswaldo Ferreira
2018-10-06Prepare admin/projects/show view to allow EE specific featureGabriel Mazetto
In EE it will render a Geo Status widget when Geo is enabled and it is in a secondary node. Also added minimal specs to that action.
2018-10-05Add timed incremental rollout to Auto DevOpsAlessio Caiazza
Auto DevOps deployment strategies now supports timed incremental rollout. We are deprecating the usage of INCREMENTAL_ROLLOUT_ENABLED environment variable in Auto DevOps template. The new behavior will be driven by the INCREMENTAL_ROLLOUT_MODE variable that can either be manual (same as INCREMENTAL_ROLLOUT_ENABLED) or timed. Rollout deployments will be executed using a 5 minute delay between each job.
2018-10-05Merge branch 'fix-flacky-test-jobs-spec' into 'master'Kamil Trzciński
[broken master] Fix time dependent jobs spec See merge request gitlab-org/gitlab-ce!22159
2018-10-05Merge branch ↵Sean McGivern
'43109-ci_environments_status-json-executes-more-than-100-queries' into 'master' Resolve "Controller Projects::MergeRequestsController#ci_environments_status.json executes more than 100 SQL queries" Closes #43109 See merge request gitlab-org/gitlab-ce!21996
2018-10-05Update spec comment to point to correct issueBrett Walker
2018-10-05Fix time dependent jobs specAlessio Caiazza
2018-10-05Merge branch 'master' of dev.gitlab.org:gitlab/gitlabhqBob Van Landuyt
2018-10-05Merge branch 'security-bw-confidential-titles-through-markdown-api' into ↵Bob Van Landuyt
'master' [master] Confidential issue/private snippet titles can be read by unauthenticated user through GFM markdown API Closes #2706 See merge request gitlab/gitlabhq!2507
2018-10-05Merge branch 'security-fix-leaking-private-project-namespace' into 'master'Bob Van Landuyt
[master] Fix leaking private project namespace Closes #2708 See merge request gitlab/gitlabhq!2529
2018-10-05Merge branch 'security-osw-user-info-leak-discussions' into 'master'Bob Van Landuyt
[security - master] Filter user sensitive data from discussions JSON See merge request gitlab/gitlabhq!2536
2018-10-05Merge branch 'issue_43097' into 'master'Sean McGivern
Move related branches to service Closes #43097 See merge request gitlab-org/gitlab-ce!22094
2018-10-05Merge branch 'ce-5987-project-templates-api' into 'master'Robert Speicher
Add a new project-specific templates API endpoint See merge request gitlab-org/gitlab-ce!22118
2018-10-05Merge branch 'rails5-fix-artifacts-controller-spec' into 'master'Kamil Trzciński
Rails5: fix artifacts controller download spec See merge request gitlab-org/gitlab-ce!22123
2018-10-05Added new test and updated all event idsJeremy Watson
2018-10-05Renamed test eventsJeremy Watson
2018-10-05Updated existing spec for new 2 year timeframeJeremy Watson
2018-10-05Merge branch 'scheduled-manual-jobs' into 'master'Kamil Trzciński
Delayed jobs Closes #51352 See merge request gitlab-org/gitlab-ce!21767
2018-10-05Backport changes from gitlab-ee!7538Simon Knox
2018-10-05Merge branch '46050_add_new_ci_predefined_variables_for_gitlab_version' into ↵Douglas Barbosa Alexandre
'master' Add new CI predefined variables with version components Closes #46050 See merge request gitlab-org/gitlab-ce!21853
2018-10-05Merge branch 'master-ce' into scheduled-manual-jobsShinya Maeda
2018-10-05Merge branch 'load_project_features' into 'master'Sean McGivern
Preload project features in reference parser Closes #43094 See merge request gitlab-org/gitlab-ce!22008
2018-10-05Make GitLab pages support access controlTuomo Ala-Vannesluoma
2018-10-05Merge branch '50246-can-t-sort-group-issues-by-popularity-when-searching' ↵Grzegorz Bizon
into 'master' Resolve "Can't sort group issues by popularity when searching" Closes #50246 See merge request gitlab-org/gitlab-ce!21521
2018-10-05Add variables to CI jobs for GitLab version componentsGilbert Roulot
Adds CI_SERVER_VERSION_MAJOR, CI_SERVER_VERSION_MINOR, CI_SERVER_VERSION_PATCH to the list of environment variables passed to CI jobs.
2018-10-05Fix issues controller N+1 failureSean McGivern
EE needs :request_store to cache license queries - otherwise we will blow past the query limit just with `SELECT * FROM licenses` over and over.
2018-10-05Put issues group search CTE behind a (default on) flagSean McGivern
We don't think this is needed any more - see https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/21521, and https://gitlab.com/gitlab-org/gitlab-ce/issues/52271 for removing the flag.
2018-10-05Merge branch 'feature/gb/pipeline-only-except-with-modified-paths' into 'master'Kamil Trzciński
Pipeline only/except for modified paths See merge request gitlab-org/gitlab-ce!21981
2018-10-05Backport project template API to CENick Thomas
2018-10-05Add spec for group issues search + sortingSean McGivern
2018-10-05Resolve "Drop down filter for project snippets"Fabian Schneider