| Age | Commit message (Collapse) | Author |
|---|
|
Remove dependencies on Linguist
Closes #35450
See merge request gitlab-org/gitlab-ce!21008
|
|
Refactor Cluster services to enable groups or projects
See merge request gitlab-org/gitlab-ce!22181
|
|
Fixes close/reopen quick actions preview for issues and merge_requests
Closes #52669
See merge request gitlab-org/gitlab-ce!22343
|
|
'master'
Fix code reuse issue in Projects::Clusters::ApplicationController#index
See merge request gitlab-org/gitlab-ce!22182
|
|
|
|
|
|
Send deployment_status when job starts environment
Closes #52614
See merge request gitlab-org/gitlab-ce!22354
|
|
This cop forbids the use of `element :foo, 'pattern'` and
`element :bar, /pattern/` in QA files.
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|
The check was if the job `has_environment` which results into showing
the environment information when the job stops the environment. This
result into having a blank `deployment_status`.
Use `starts_environment?` to be the same as the haml we have in 11.3
https://gitlab.com/gitlab-org/gitlab-ce/blob/30f019dca78bb64bcb8b355a267be006884e6d8f/app/views/projects/jobs/show.html.haml#L28
|
|
Close/reopen quick actions preview wasn't shown properly, now the
preview is shown as expected.
|
|
This fixes a bug where the file templates would not be cleared
after changing the template type.
Previously the templates would get pushed into the array
creating a list of templates for the different types.
This changes that by clearing the templates array
when the template type gets changed.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/52487
|
|
Improve spec for Gitlab::Ci::Status::Pipeline::Factory
Closes #52280
See merge request gitlab-org/gitlab-ce!22247
|
|
|
|
In [!21565][0] we removed the loadCheck function from the LazyLoader for
images. The function seemed to be obsolete before anyhow, because we
make use of the MutationObserver in order to detect elements added /
removed from the DOM.
[0]: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/21565
|
|
Swap out `go` method with subject which is the convention.
Re-organize 'PUT update' to remove un-necessary context nesting.
DRY up repeated blocks to `add_maintainer` and `sign_in`
|
|
Remove the inheritance from ::BaseService which is causing us to inherit
the initializer that has project as the first arg, as we will not have
access to project with forthcoming group clusters.
Also call install service from create service - 1 less thing to re-use
Extract TestRequest code into a spec helper. Given that we need
different behaviour for Rails 5.0 (and again in Rails 5.1!), it's handy
to have that branching behaviour in one place
|
|
This should help with code re-use when we create applications for group
level cluster next.
Change `find_or_initialize_by` to explicitly find or build the right
association based on the application name. The benefit here is that we
use the associations on @cluster rather than querying from the other
side of the association.
|
|
This enables us to have other options in the future such as passing in
`group:`.
Also, remove project arg from UpdateService, as un-used.
This will help group cluster controller to re-use this services.
|
|
In Rails 5 catches invalid UTF8 characters in querystring in a
params middleware, errors are handled by a params middleware and
raises a BadRequest exception. This means that these UTF8 errors
are not raised deeper in application stack and these can't also
be handled on application level.
If we would want to have custom handler for these errors, we would
have to create a new middleware and insert it before actionpack's
params middleware and rescue BadRequest exceptions there. But there
is no need to do this currently (see discussion on
https://gitlab.com/gitlab-org/gitlab-ce/issues/51908)
|
|
This integration no longer works and does not appear to be supported.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/39697
|
|
This saves about 128 MB of baseline RAM usage per Unicorn and
Sidekiq process (!).
Linguist wasn't detecting languages anymore from CE/EE since
9ae8b57467ac8b38f1fa9020a466d94a93cbb9dd. However, Linguist::BlobHelper
was still being depended on by BlobLike and others.
This removes the Linguist gem, given it isn't required anymore.
EscapeUtils were pulled in as dependency, but given Banzai depends on
it, it is now added explicitly.
Previously, Linguist was used to detect the best ACE mode. Instead,
we rely on ACE to guess the best mode based on the file extension.
|
|
Updates the check for started in job header
See merge request gitlab-org/gitlab-ce!22329
|
|
|
|
The function that was checking if the job was started or not
was expecting a boolean, however it was receiving a null.
During the refactor the condition was changed, causing the function
to break with null
This commit fixes the check
|
|
|
|
This commit adds back `js-` classes needed to
automatically collapse the sidebar on resize.
|
|
As we now support getting the merge base for multiple revisions in
gitaly, we can provide this functionality in our API
|
|
|
|
4. enable jasmine/prefer-jasmine-matcher
See merge request gitlab-org/gitlab-ce!22236
|
|
1. enable jasmine/new-line-between-declarations
See merge request gitlab-org/gitlab-ce!22230
|
|
|
|
Fix project deletion when there is a export available
Closes #52362
See merge request gitlab-org/gitlab-ce!22276
|
|
Support pushing of feature flags to the frontend
Closes gitlab-org/release/framework#17
See merge request gitlab-org/gitlab-ce!22197
|
|
Adds `.json` to the end of pipelines endpoint
Closes #52472
See merge request gitlab-org/gitlab-ce!22293
|
|
|
|
This adds a method to Gitlab::GonHelper called
`push_frontend_feature_flag`. This method can be used to easily expose
the state of a feature flag to Javascript code. For example, using this
method we may write the following controller code:
before_action do
push_frontend_feature_flag(:vim_bindings)
end
def index
# ...
end
def edit
# ...
end
In Javascript we can then check the state of the flag as follows:
if ( gon.features.vimBindings ) {
// ...
}
Fixes https://gitlab.com/gitlab-org/release/framework/issues/17
|
|
|
|
|
|
When the job page is rendered we fetch the pipeline
endpoint to render the stages in the sidebar.
Without `.json` the response is cached, and when the
user goes back to the pipeline's page it renders the
json output instead of the Vue app
|
|
Rspec was using a CSS class to check if the content
was being rendered. Since the CSS has changed, the specs failed
This commit replaces the CSS class with a `js-` prepended one
to guarantee changing CSS won't break a pipeline
|
|
Project deletions were failing with "Can't modify frozen hash" because:
1. Project#remove_exports was called in the after_destroy hook
2. This would remove the file and update ImportExportUpload
3. ImportExportUpload#save would attempt to write to a destroyed model
To avoid this, we just check if ImportExportUpload has been destroyed
before attempting to save it.
This would have a side effect of not running after_commit hooks to delete the
repository on disk, making it impossible to delete the project entirely.
Closes #52362
|
|
|
|
|
|
Was introduced in the time that GitLab still used NFS, which is not
required anymore in most cases. By removing this, the API it calls will
return empty responses. This interface has to be removed in the next
major release, expected to be 12.0.
|
|
|
|
|
|
|
|
|
|
Reject invalid branch names in repository compare controller
Closes #51003
See merge request gitlab-org/gitlab-ce!22186
|
|
Rails5: fix user edit profile clear status spec
See merge request gitlab-org/gitlab-ce!22169
|
