| Age | Commit message (Collapse) | Author |
|---|
|
Notes call `#after_note_created` and `#after_note_destroyed` on their
noteable in callbacks, so the noteable can perform tasks particular to
them, like cache expiry.
This is in preparation of the EE-specific class
`DesignManagement::Design` clearing its `user_notes_count` cache when
its note are created or destroyed.
Refactoring Rspec behaviour testing of a counter caching service into a
shared example.
https://gitlab.com/gitlab-org/gitlab-ee/issues/13353
|
|
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|
This commit creates a create_cluster directory to collect
all Vue applications related to creating kubernetes applications
using gitlab.
It also moves the gke_cluster_dropdowns collection of apps to
the create_cluster directory. gke_cluster_dropdowns contains
dropdown components used to select configuration options to
create a Kubernetes cluster in Google Cloud.
|
|
'65312-use-group-labels-instead-of-legacy-team-labels-for-danger-picking-test-reviewers' into 'master'
Detect the new stage labels in `Gitlab::Danger::Teammate`
Closes #65312
See merge request gitlab-org/gitlab-ce!32261
|
|
'66641-broken-master-real-http-connections-are-disabled-unregistered-request' into 'master'
Use `stub_full_request` to fix spec failure
Closes #66641
See merge request gitlab-org/gitlab-ce!32259
|
|
Also change test URL sequest to .test TLD
|
|
Add nil check for Gitlab.config.prometheus
Closes #13806
See merge request gitlab-org/gitlab-ce!32201
|
|
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|
Promote Label to Group Label via API endpoint
Closes #57657
See merge request gitlab-org/gitlab-ce!25218
|
|
Remove N+1 SQL query loading project feature in dashboard
Closes #66482
See merge request gitlab-org/gitlab-ce!32169
|
|
Resolve "Store deploy tokens encrypted"
Closes #63502
See merge request gitlab-org/gitlab-ce!30679
|
|
allow_bypass_two_factor configration dose not work with saml provider
|
|
|
|
|
|
Fix Piwik not working
Closes #66627
See merge request gitlab-org/gitlab-ce!32234
|
|
Due to indentation, the changes in
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/31402 broke the
templating of Piwik script header.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/66627
|
|
Guard against deleted project feature entry
Closes #66482
See merge request gitlab-org/gitlab-ce!32187
|
|
This reverts merge request !31826
|
|
In https://gitlab.com/gitlab-org/gitlab-ce/issues/66482, we see that a
project's `project_feature` association may be lazily loaded and hence
return `nil` if the entry is deleted if the `Project` is already loaded
in memory. To ensure we don't fail hard when this happens, assume all
features are disabled.
We can fix this issue by eager loading the `project_feature` in
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/32169, but we
shouldn't have to depend on that.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/66482
|
|
Removed unused method for name setter method
|
|
This also restructures how and where the configuration for
Snowplow lives.
|
|
Fix N+1 Gitaly calls in /api/v4/projects/:id/issues
See merge request gitlab-org/gitlab-ce!32171
|
|
The `GraphQL::Function` has been deprecated in
favor of resolvers.
|
|
|
|
Code Review Usage Ping for Create SMAU
|
|
Remove the object pools feature flag
See merge request gitlab-org/gitlab-ce!32204
|
|
|
|
Stop checking the file location programmatically.
|
|
|
|
The flag defaulted to true, so there's no change unless users turned it
off. Given there's a lack of issues regarding object pools, this should
be OK.
|
|
'66443-unrecoverable-configuration-loop-in-external-auth-control' into 'master'
Resolve "Unrecoverable configuration loop in external auth control"
Closes #66443
See merge request gitlab-org/gitlab-ce!32102
|
|
Call QuickActionsService on Note update
Add support for notes which just contain
commands after editing
Return http status gone (410) if note was deleted
Temporary frontend addition so it is not
failing when a note is deleted
Move specs to shared examples
Fix rubocop style issue
Deleting note on frontend when status is 410
Use guard clause for note which got deleted
Simplified condition for nil note
This method should no longer be called
with nil note
Refactoring of execute method to reduce
complexity
Move errors update to delete_note method
Note is now deleted visually when it only
contains commands after update
Add expectation
Fix style issues
Changing action to fix tests
Add tests for removeNote and update
deleteNote expectations
|
|
|
|
|
|
DB Load Balancing: Support SRV lookups
See merge request gitlab-org/gitlab-ce!32135
|
|
|
|
Backport expired job artifact trait
See merge request gitlab-org/gitlab-ce!32179
|
|
- Also add helper to undo rename_column_concurrently.
|
|
|
|
'66073-use-time-series-chart-instead-of-area-chart-in-panel_types' into 'master'
Enable line charts in dashbaord panels and embedded charts
Closes #66073
See merge request gitlab-org/gitlab-ce!31920
|
|
This is a follow-up from
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/31938.
In GitLab 9.0,
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/9661 removed the
`subscribed` flag from the API when the user requested a list of issues
or merge requests since calculating this value triggers extensive
Markdown processing.
In GitLab 12.0 via a4fbf39e, we accidentally reintroduced this
performance regression by changing `IssueBasic` to `Issue` in
`entities.rb`. This showed up as a Gitaly N+1 issue since the Markdown
processing would attempt to extract a commit if it detected a regex that
matched a commit.
We restore the prior behavior by once again removing the `subscribed`
flag for the bulk list of issues and merge requests and add a test to
ensure they aren't reintroduced.
Relates to https://gitlab.com/gitlab-org/gitlab-ce/issues/66202
|
|
- When renaming a column concurrently, drop any existing trigger before
attempting to create a new one.
When running migration specs multiple times (as it happens during
local development), the down method of previous migrations are called.
If any of the called methods contains a call to
rename_column_concurrently, a trigger will be created and not removed.
So, the next time a migration spec is run, if the same down method is
executed again, it will cause an error when attempting to create the
trigger (since it already exists). Dropping the trigger if it already
exists will prevent this problem.
|
|
Add to the service and migration both.
|
|
This cop will analyze migrations that add columns with string, and
report an offense if the string has no limit enforced
Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/64505
|
|
Some pipeline status icon tooltips were showing
"Commit: ..." which customers found to be
misleading since it was not the commit that was
failing but the pipeline.
We are changing all status icon tooltips to say
"Pipeline: ..." instead of "Commit: ..." now.
|
|
Projects that have a pipeline may need to check whether the user has
permission to read the build (`can?(current_user, :read_build,
project)`), which requires checking the `project_features` table.
This would cause an N+1 SQL query for each project.
This change also has a beneficial side effect that may avoid a race
condition. When a user deletes a project, the project is queued for
deletion and the user is redirected back to the dashboard page. However,
the following may happen:
1. The dashboard page may load this deleted project in the list of
20 projects.
2. The view will load the project pipeline status from the cache and
attempt to show each project.
3. When the view encounters the deleted project, it calls
`can?(current_user, :read_build, project)` to determine whether to
display the pipeline status.
4. Sidekiq deletes the project from the database.
5. However, since the deleted project is still loaded in memory, it will
attempt to call `project.project_feature.access_level`.
6. Since `project_feature` was not eager loaded, a lazy `SELECT` call is
made to the database.
7. This `SELECT` call returns nothing, and the user sees a 500 error.
By eager loading `project_feature`, we can ensure that we have a
consistent view and avoid records from being deleted later.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/66482
|
|
Allow users to read pipelines for public projects
with public builds enabled without providing an access token.
|
|
Return correct user for manual deployments
See merge request gitlab-org/gitlab-ce!32004
|
|
- Introducting StageEvents to define the available events
- Define the event pairing rules, since some events are not compatible
- Express default Cycle Analytics stages with the event structure
|
|
[CE backport] Enforced SSO shouldn't break container registry authentication
See merge request gitlab-org/gitlab-ce!32110
|
