| Age | Commit message (Collapse) | Author |
|---|
|
|
|
- Extract MR fields for notes into a separate serializer
- Check if pipelines are empty via count
|
|
Resolve "Migrate spec/javascripts/vue_shared/components/file_icon_spec.js to Jest"
See merge request gitlab-org/gitlab-ce!32278
|
|
Persists if a board list is collapsed for each user.
|
|
|
|
|
|
Remove csslab
Closes #66661
See merge request gitlab-org/gitlab-ce!32330
|
|
A new param with_security_reports was added to
GET /groups/:id/projects API and the code to
support this logic in GroupProjectsFinder and
Project model. Also, a DB index was added to
ci_job_artifacts table to speed up the search
of security reports artifacts for projects
|
|
This change sets NOT NULL constraint to users.private profile.
closes https://gitlab.com/gitlab-org/gitlab-ce/issues/57538
|
|
Add rubocop check for be success
See merge request gitlab-org/gitlab-ce!32091
|
|
Makes LFS object link process OIDs in batches
Closes #66274
See merge request gitlab-org/gitlab-ce!32268
|
|
|
|
- local tests that assume certain parameters to queries from
QueryRecorder fail. These same tests don't fail in the runners,
and I can't tell why. This fixes the local failures
|
|
Add changelog entry
Remove unnecessary test checking for form value
Translations updated for gitlab.pot
Use proper format on changelog entry
|
|
Change the way totalNotes is calculated
See merge request gitlab-org/gitlab-ce!32191
|
|
Fix moving issues API failing when text includes commit URLs
Closes #66666
See merge request gitlab-org/gitlab-ce!32317
|
|
When a issue is moved from one project to another, all associated
Markdown text is rewritten in the context of the new project. If the
note contained a link to a commit URL, `CommitRewriter#rewrite` would
fail because `Commit#link_reference_pattern` would match `nil` `commit`
values in the HTML generated from the Markdown. These `nil` values were
passed along to `Project#commits_by` because `Commit#reference_valid?`
was always returning `true`.
To prevent this issue from happening, we tighten up the check for
`Commit#reference_valid?` to look for valid SHA values.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/66666
|
|
Improve specs output readability by replacing
`it_behaves_like` with `include_examples`
in `BeSuccessMatcher`
|
|
This also restructures how and where the configuration for
Snowplow lives.
|
|
|
|
Former shared examples were used only once.
Inlining them makes tests more clear.
|
|
|
|
Use Rubocop's Include
instead of manually checking the matcher in controllers specs.
|
|
BeSuccessMatcher now supports following examples:
```
expect(response).to be_success
expect(response).to_not be_success
expect(response).not_to be_success
is_expected.to be_success
is_expected.to_not be_success
is_expected.not_to be_success
```
|
|
|
|
|
|
|
|
|
|
Prevent using `be_success` call in controller specs to avoid
getting following deprecation warning:
```
DEPRECATION WARNING: The success? predicate is deprecated and
will be removed in Rails 6.0.
Please use successful? as provided by Rack::Response::Helpers.
```
|
|
Add Issue and Merge Request titles to Todo items
Closes #63488
See merge request gitlab-org/gitlab-ce!30435
|
|
totalNotes is only used to prerender a number of
skeleton containers until real notes are loaded
issuable.discussions makes multiple requests, so
too expensive for this
This commit uses mere notes for this and sends
actual totalNotes number if it's less than 10;
otherwise it sends 10 - it allows us to avoid
bunch of skeleton prerenderings, which are not
necessary since they doesn't fit into the whole
screen and disappear quite fast
|
|
|
|
Only displays the todo body if the todo has a note.
This is to avoid redundant Issue or Merge Request titles
displayed both in the Todo title and body.
|
|
During a project import, `LfsLinkService` attempts to link `LfsObjects`
that have not already been associated with a project. It's possible for
a large repo to have thousands of OIDs, which can cause long database
query and parsing times. By processing a batch of 1000 at a time, we
can reduce that time at the expense of a few more SQL queries.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/66274
|
|
Notes call `#after_note_created` and `#after_note_destroyed` on their
noteable in callbacks, so the noteable can perform tasks particular to
them, like cache expiry.
This is in preparation of the EE-specific class
`DesignManagement::Design` clearing its `user_notes_count` cache when
its note are created or destroyed.
Refactoring Rspec behaviour testing of a counter caching service into a
shared example.
https://gitlab.com/gitlab-org/gitlab-ee/issues/13353
|
|
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|
This commit creates a create_cluster directory to collect
all Vue applications related to creating kubernetes applications
using gitlab.
It also moves the gke_cluster_dropdowns collection of apps to
the create_cluster directory. gke_cluster_dropdowns contains
dropdown components used to select configuration options to
create a Kubernetes cluster in Google Cloud.
|
|
'65312-use-group-labels-instead-of-legacy-team-labels-for-danger-picking-test-reviewers' into 'master'
Detect the new stage labels in `Gitlab::Danger::Teammate`
Closes #65312
See merge request gitlab-org/gitlab-ce!32261
|
|
'66641-broken-master-real-http-connections-are-disabled-unregistered-request' into 'master'
Use `stub_full_request` to fix spec failure
Closes #66641
See merge request gitlab-org/gitlab-ce!32259
|
|
Also change test URL sequest to .test TLD
|
|
Add nil check for Gitlab.config.prometheus
Closes #13806
See merge request gitlab-org/gitlab-ce!32201
|
|
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|
Promote Label to Group Label via API endpoint
Closes #57657
See merge request gitlab-org/gitlab-ce!25218
|
|
Remove N+1 SQL query loading project feature in dashboard
Closes #66482
See merge request gitlab-org/gitlab-ce!32169
|
|
Resolve "Store deploy tokens encrypted"
Closes #63502
See merge request gitlab-org/gitlab-ce!30679
|
|
allow_bypass_two_factor configration dose not work with saml provider
|
|
|
|
|
|
Fix Piwik not working
Closes #66627
See merge request gitlab-org/gitlab-ce!32234
|
|
Due to indentation, the changes in
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/31402 broke the
templating of Piwik script header.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/66627
|
