| Age | Commit message (Collapse) | Author |
|---|
|
'master'
Cleanup stale +deleted repo paths on project removal (adjusts project removal bug)
Closes #46146
See merge request gitlab-org/gitlab-ce!24269
|
|
Return the maximum group access level in the projects API
Closes #43684
See merge request gitlab-org/gitlab-ce!24403
|
|
1. When removing projects, we can end-up leaving the +deleted
repo path dirty and not successfully removing the non-deleted
namespace (mv process is not atomic and can be killed without
fully moving the path).
2. In order to solve that, we're adding a clean-up phase on
ensure which will schedule possible staled +deleted path deletion.
Note that we don't check the current state (if there is or not a
repo) in order to schedule the deletion. That's intentional
in order to leverage Gitlab::GitalyClient::NamespaceService#remove
idempotency and ensure consistency.
|
|
[EE Backport] Add notes filters for epics
See merge request gitlab-org/gitlab-ce!24372
|
|
|
|
Spam checks are meant for content that could be indexed by search
engines. Confidential issues aren't indexed by search engines, so we
don't need to do spam checks for them.
We do need to check for spam when an issue changes from confidential to
public, even if nothing else changed.
|
|
Avoid overwriting default jaeger values with nil
See merge request gitlab-org/gitlab-ce!24482
|
|
Fix runner eternal loop when update job result
Closes #56518
See merge request gitlab-org/gitlab-ce!24481
|
|
Collapses directory structure in merge request tree
Closes #53069
See merge request gitlab-org/gitlab-ce!24392
|
|
During the review process for adding opentracing factories, a bug was
introduced which caused Jaeger to initialize an invalid tracer. The
bug was due to use sending nil through as a kwarg when the Jaeger
initializer used a non-nil default value.
This is fairly insidious as, the tracer looks like a tracer, but, when
methods are invoked, it throws `NoMethodError` errors. To ensure that
this issue does not happen in future, the tests have been changed to
ensure that the tracer works as expected. This could avoid problems
in future when upgrading to newer versions of Jaeger.
|
|
Add spec
Add changelog
|
|
Port generic Helm upgrade functionality to CE
See merge request gitlab-org/gitlab-ce!23924
|
|
Handle emptyText in user_avatar_list
See merge request gitlab-org/gitlab-ce!24436
|
|
Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
|
|
The document is now split in two sections:
- Testing an ActiveRecord migration
- Testing an non-ActiveRecord migration
Both sections have an example
|
|
Markdown footnotes not working
Closes #26375
See merge request gitlab-org/gitlab-ce!24168
|
|
Cleanup legacy artifact background migration
Closes #46866
See merge request gitlab-org/gitlab-ce!24144
|
|
'42769-remove-expansion-hover-animation-from-status-icon-buttons' into 'master'
Resolve "Remove expansion hover animation from status icon buttons"
Closes #42769
See merge request gitlab-org/gitlab-ce!24268
|
|
|
|
and additional spec
|
|
Improve MilestonesFinder to accept project and group relations
Closes #47988
See merge request gitlab-org/gitlab-ce!24325
|
|
|
|
The expansion hover animation caused a number of layout headaches; this
commit removes the animation and replaces them with hover/active/focus
styles.
Related issue:
https://gitlab.com/gitlab-org/gitlab-ce/issues/42769
|
|
Conditionally initialize the global opentracing tracer
See merge request gitlab-org/gitlab-ce!24186
|
|
|
|
This change will instantiate an OpenTracing tracer and configure it
as the global tracer when the GITLAB_TRACING environment variable is
configured. GITLAB_TRACING takes a "connection string"-like value,
encapsulating the driver (eg jaeger, etc) and options for the driver.
Since each service, whether it's written in Ruby or Golang, uses the
same connection-string, it should be very easy to configure all
services in a cluster, or even a single development machine to be
setup to use tracing.
Note that this change does not include instrumentation or propagation
changes as this is a way of breaking a previous larger change into
components. The instrumentation and propagation changes will follow
in separate changes.
|
|
Remove import_issues_csv feature flag
See merge request gitlab-org/gitlab-ce!24324
|
|
Add migration and spec
commit 3cc12e1268a6865f524d8fab1804f018312fdf5a
Author: Shinya Maeda <shinya@gitlab.com>
Date: Tue Jan 8 19:34:31 2019 +0900
Add changelog to this change
commit 5006fc96e38db514956a35f53ae8ee536548a2e9
Author: Shinya Maeda <shinya@gitlab.com>
Date: Tue Jan 8 19:32:56 2019 +0900
Remove partial index from ci_builds artifact_file
ok
Update schema
commit 3c956bdc02b195bc67d0327bf3748a631ea5466d
Author: Shinya Maeda <shinya@gitlab.com>
Date: Mon Jan 7 21:41:27 2019 +0900
Add frozen_string_literal: true
commit 8c827cd616890160e6e8908843403a6f20c03236
Author: Shinya Maeda <shinya@gitlab.com>
Date: Mon Jan 7 21:40:06 2019 +0900
Set batch size 100
commit aeee559777d3bdeadfd2b9bb61d460f2dc1fa8a6
Author: Shinya Maeda <shinya@gitlab.com>
Date: Fri Jan 4 18:33:05 2019 +0900
Cleanup legacy artifact background migration
|
|
|
|
|
|
'56309-read-only-controller-doesn-t-account-for-relative-paths-for-admin-sidekiq-route' into 'master'
Allow sidekiq admin requests, regardless of root
Closes #56309
See merge request gitlab-org/gitlab-ce!24352
|
|
Fix detecting nested EE constants in RuboCop
See merge request gitlab-org/gitlab-ce!24430
|
|
Currently if a project is inside a nested group and a user doesn't have
specific permissions for that group but does have permissions on a
parent group the `GET /projects/:id` API call will return the following
permissions:
```json
permissions: { project_access: null, group_access: null }
```
It could also happen that the group specific permissions are of lower
level than the ones the user has in parent groups. This patch makes it
so that the permission returned for `group_access` is the highest from
amongst the hierarchy, which is (ostensibly) the information that the
API user is interested in for that field.
|
|
|
|
[master] Validate bundle files before unpacking them
Closes #2770
See merge request gitlab/gitlabhq!2772
|
|
|
|
Refactor checking personal project limits
See merge request gitlab-org/gitlab-ce!24396
|
|
Enable FactoriesInMigration cop for background migrations
See merge request gitlab-org/gitlab-ce!24425
|
|
Refactor Project#after_create_default_branch
See merge request gitlab-org/gitlab-ce!24329
|
|
The InjectEnterpriseEditionModule cop would not detect certain nested EE
constants such as `EE::Foo::Bar::Baz`. This could result in it not
enforcing `prepend` being placed on the last line. This commit fixes
this by just performing a string match on the line, instead of relying
on AST matching.
|
|
**Why?**
To reduce duplicate code, it's helpful to encapsulate this behavior
here.
|
|
Add badge count to projects
Closes #29798
See merge request gitlab-org/gitlab-ce!18425
|
|
This refactors some of the logic used for protecting default branches,
in particular Project#after_create_default_branch. The logic for this
method is moved into a separate service class. Ideally we'd get rid of
Project#after_create_default_branch entirely, but unfortunately
Project#after_import depends on it. This means it has to stick around
until we also refactor Project#after_import.
For branch protection levels we introduce
Gitlab::Access::BranchProtection, which provides a small wrapper around
Integer based branch protection levels. Using this class removes the
need for having to constantly refer to Gitlab::Access::PROTECTION_*
constants.
|
|
|
|
This refactors the code used for checking if a user has exceeded the
personal projects limit. As part of this refactor the method has been
renamed from Project#check_limit to "check_personal_projects_limit", as
this name makes it much more clear what the purpose of the method is.
Standalone unit tests have also been added, as before we only had a
single generic validation test that did not cover all cases.
The old implementation of the refactored method also included a `rescue`
statement. This code would only run when a project creator was not set.
The error that would be added wasn't super useful, especially since
there would already be errors for the creator not being present. As none
of the other code in the "check_personal_projects_limit" raises, it has
been removed.
|
|
Enable Gitlab-Pages for subgroups
See merge request gitlab-org/gitlab-ce!23505
|
|
|
|
Fix RSpec/FactoriesInMigrationSpecs in two files
See merge request gitlab-org/gitlab-ce!24405
|
|
Add group ful path to project's shared_with_groups
See merge request gitlab-org/gitlab-ce!24052
|
|
Fixed transient user merges immediately spec
Closes gitlab-ee#9206
See merge request gitlab-org/gitlab-ce!24421
|
