Welcome to mirror list, hosted at ThFree Co, Russian Federation.

gitlab.com/gitlab-org/gitlab-foss.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
path: root/spec
AgeCommit message (Collapse)Author
2019-01-23Merge branch '56417-update-helm-to-2-12-2' into 'master'Kamil Trzciński
Update Helm to 2.12.2 to address Helm client vulnerability Closes #56417 See merge request gitlab-org/gitlab-ce!24418
2019-01-23Merge branch ↵Filipa Lacerda
'25569-changing-wording-to-delete-when-referring-to-removing-a-branch' into 'master' Resolve "Changing wording to "Delete" when referring to removing a branch" Closes #25569 See merge request gitlab-org/gitlab-ce!23966
2019-01-23Merge branch 'dm-trim-discussion-truncated-line-first-chars' into 'master'Phil Hughes
Fix bug that caused Suggestion Markdown toolbar button to insert snippet with leading +/-/<space> See merge request gitlab-org/gitlab-ce!24568
2019-01-22Merge branch '52363-add-domain-to-cluster-model' into 'master'Kamil Trzciński
Add domain field into Clusters::Cluster See merge request gitlab-org/gitlab-ce!24368
2019-01-22Use 'delete' instead of 'remove' for source branchSam Bigelow
This is to match `git branch -D <branchname>`
2019-01-22Merge branch 'an-opentracing-propagation' into 'master'Kamil Trzciński
Adds inter-service OpenTracing propagation See merge request gitlab-org/gitlab-ce!24239
2019-01-22fix(labels): Move the primary button out of breadcrumbs and into the project ↵Martin Hobert
section
2019-01-22Add domain field into Clusters::ClusterMayra Cabrera
This is the 1st step for moving Auto DevOps domain into cluster settings, whether is project or group. Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/52363
2019-01-22Merge branch 'fixes-populate-cluster-kubernetes-namespace-table-spec' into ↵Kamil Trzciński
'master' Removes factories on Cluster background migration See merge request gitlab-org/gitlab-ce!24536
2019-01-22Merge branch '56636-hashed-storage-afterrenameservice' into 'master'Douglas Barbosa Alexandre
Hashed Storage: `AfterRenameService` was not renaming Pages or Uploads folder on legacy storage Closes #56636 See merge request gitlab-org/gitlab-ce!24526
2019-01-22Adds inter-service OpenTracing propagationAndrew Newdigate
This change allows the GitLab rails and sidekiq components to receive tracing spans from upstream services such as Workhorse and pass these spans on to downstream services including Gitaly and Sidekiq. This change will also emit traces for incoming and outgoing requests using the propagated trace information. This will allow operators and engineers to view traces across the Workhorse, GitLab Rails, Sidekiq and Gitaly components. Additional intra-service instrumentation will be added in future changes.
2019-01-22Trim first char of diff line text on diff discussionsDouwe Maan
Before, diff file `higlighted_diff_lines`/`parallel_diff_lines` and diff discussion `truncated_diff_lines` were inconsistent: `text` and `rich_text` on the latter included the leading +/-/<space> character, like on the backend, while the former had no `text` and its `rich_text` had dropped this char. This resulted in a bug when the suggestions feature expected these diff line objects to be identical in format and thus interchangeable, which was not the case.
2019-01-22Merge branch 'tz-user-avatar-caching' into 'master'Sean McGivern
Changed the Caching of User Avatars to be public and to 5 minutes See merge request gitlab-org/gitlab-ce!24546
2019-01-22Merge branch ↵Grzegorz Bizon
'55966-when-ref-is-ambiguous-createpipelineservice-raises-an-error' into 'master' Resolve "When ref is ambiguous, `CreatePipelineService` raises an error" Closes #55966 See merge request gitlab-org/gitlab-ce!24437
2019-01-22Merge branch 'leipert-make-canvas-more-tolerant' into 'master'Phil Hughes
Make favicon tests more fault resistent Closes #50527 See merge request gitlab-org/gitlab-ce!22686
2019-01-22Removes factories on Cluster background migrationMayra Cabrera
'Populate cluster kubernetes namespace' was using factories for their specs. According to our documentation (see spec/migrations/readme.md), we should use table helper to create a temproary ActiveRecord::Base derived model for a table.
2019-01-22Update GitLab Runner Helm Chart to 0.1.45Tomasz Maczukin
2019-01-22Merge branch '47007-related-merge-requests-in-issue-design-restyle' into ↵Kushal Pandya
'master' Resolve "Related merge requests in issue design - Restyle" Closes #47007 See merge request gitlab-org/gitlab-ce!24270
2019-01-22Merge branch '56547-limit-sidekiq-logging-based-on-argument-size' into 'master'Stan Hu
Resolve "Limit sidekiq logging based on argument size" Closes #56547 See merge request gitlab-org/gitlab-ce!24493
2019-01-22Merge branch 'proof-read' into 'master'Achilleas Pipinellis
Fix typos in dev & test docu See merge request gitlab-org/gitlab-ce!24539
2019-01-22Merge branch '53671-redirect-projects-id-to-project-page' into 'master'Douglas Barbosa Alexandre
Resolve "Redirect projects/:id to project page" Closes #53671 See merge request gitlab-org/gitlab-ce!24467
2019-01-22Refactored AfterRenameService to reduce couplingGabriel Mazetto
We still rely on the Dirty API for project rename (before/after) values, but we don't access the dirty api from the service class anymore. The previous value is now part of the initialization, which makes it easier to test and the behavior is clearer. The same was done with the `rename_repo` on the Storage classes, we now provide before and after values as part of the method signature.
2019-01-22Turned cache_privately? into cache_publicly?Tim Zallmann
Also removed unnecessary comment
2019-01-22Limit Sidekiq args logging to 10 KB of JSONSean McGivern
When logging arguments from Sidekiq to JSON, restrict the size of `args` to 10 KB (when converted to JSON). This is to avoid blowing up with excessively large job payloads.
2019-01-22Merge branch ↵Filipa Lacerda
'53856-changing-group-visibility-does-not-re-enable-save-button' into 'master' Resolve "Changing group visibility does not re-enable Save button" Closes #53856 See merge request gitlab-org/gitlab-ce!23022
2019-01-22Merge branch '50013-add-browser-platform-flags' into 'master'Douwe Maan
Add CSS & JS global flags to represent browser and platform Closes #50013 See merge request gitlab-org/gitlab-ce!24017
2019-01-22Merge branch 'sh-fix-snippet-uploads-path-lookup' into 'master'Sean McGivern
Fix 404s with snippet uploads in object storage Closes #52595 See merge request gitlab-org/gitlab-ce!24550
2019-01-22Add `client_detection` helper to add browser and plaform flagsKushal Pandya
2019-01-22Resolve "Merge request file browser should always be possible show/hide"Sam Bigelow
2019-01-22Add ability to resolve project id into pathDmitriy Zaporozhets
By visiting `projects/:id` you will be redirected to project page with path in it. projects/123 => foo/bar Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2019-01-22Fix 404s with snippet uploads in object storageStan Hu
Previously, an HTTP request for `/uploads/-/system/personal_snippet/:snippet_id/:hash/:filename` would look for an uploader of `PersonalFileUploader` class and use `PersonalFileUploader#upload_paths` to search the datbase for one of the following paths: 1. `:hash/:filename` 2. `uploads/-/system/personal_snippet/:id/:hash/:filename` However, when the upload were stored in object storage, `PersonalFileUploader#store_dirs` stored the path as: `personal_snippet/:snippet_id/:hash` The extraneous `uploads/-/system` prefix prevented the path from being matched, and uploads in object storage would return a 404 error. Uploads in local storage would work fine. To fix this, we set the `#base_dir` properly so that `#upload_paths` generates the right value for object storage. Note that this also makes `#store_dirs` do the right thing in `FileUploader`. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/52595
2019-01-22Fix DirtySubmit handling of checkbox and radio inputsLuke Bennett
Most browsers do not fire the "input" event for checkboxes or radios. Adds a "change" listener to properly trigger these DirtySubmit updates.
2019-01-22Fixed static analysis error and 2 caching specsTim Zallmann
2019-01-22Changed the Caching of User Avatars to be public and to 5 minutesTim Zallmann
2019-01-21Make favicon tests more fault resistentLukas Eipert
It seems like every new version of Chrome renders the favicon canvas differently. This reduces the problems with it by creating a more fault tolerant check, which compares the color values in the pixels and is okay if they are within a certain threshold.
2019-01-21Merge branch '56371-don-t-check-confidential-issues-for-spam' into 'master'Douglas Barbosa Alexandre
Resolve "Don't check confidential issues for spam" Closes #56371 See merge request gitlab-org/gitlab-ce!24453
2019-01-21Fix typosKatrin Leinweber
2019-01-21Fixed legacy storage renaming codeGabriel Mazetto
During a previous refactor on project model, code related to the hashed storage was extracted into AfterRenameService, see 4b9c17f196bab6075563f62d01f9db65c1a0515c. The "path_before" was changed from using `previous_changes['path']` to `path_was`. They are not equivalent. `path_was` exists reliably only *before* persisting to the database. After database persistence is confirmed, the value is moved to `previous_changes[:attribute_name]`. Because the repository/attachments rename or storage upgrade happens after it was persisted to the database, we were in fact not informing the right parameters (and therefore not doing what it was supposed to).
2019-01-21Assign pipeline protected attribute in PopulateMatija Čupić
This removes the Protect pipeline chain step and assigns the protected attribute in the Populate step instead.
2019-01-21Resolve "Admin Settings: Cannot read property 'addEventListener' of null"Martin Wortschack
2019-01-21Merge branch 'sh-preload-associations-for-group-api' into 'master'Douwe Maan
Eliminate N+1 queries in /api/groups/:id Closes #49845 See merge request gitlab-org/gitlab-ce!24513
2019-01-21Search project tags via APIRobert Schilling
2019-01-21Merge branch 'raise-on-unfiltered-params' into 'master'Rémy Coutable
Set ActionController raise_on_unfiltered_parameters to true See merge request gitlab-org/gitlab-ce!24443
2019-01-21Merge branch 'sh-bump-katex-version-0.10.0' into 'master'Kushal Pandya
Bump the katex package to 0.10.0 See merge request gitlab-org/gitlab-ce!24478
2019-01-20Eliminate N+1 queries in /api/groups/:idStan Hu
In https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/15475/diffs, a significant amount of work went into eliminating N+1 queries in the /api/groups/:id/projects endpoint. We can reuse the `Entities::Project.prepare_relation` call on the projects. In a group with 2,573 projects on GitLab.com, this change significantly improves performance: * 18019 SQL queries down to 21 * Time spent in DB: 70 s down to 384 ms Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/49845
2019-01-19Merge branch '56213-remove-error_tracking-feature-flag' into 'master'Kamil Trzciński
Resolve "Remove `error_tracking` feature flag" Closes #56213 See merge request gitlab-org/gitlab-ce!24306
2019-01-18Remove unwanted margin above suggested changes.Jacques Erasmus
2019-01-18Merge branch 'docs-fix-migrations-readme' into 'master'Robert Speicher
Improvements for spec migration readme See merge request gitlab-org/gitlab-ce!24440
2019-01-18Update spec/features/markdown/math_spec.rbAndrew Harmon
Refer to https://github.com/KaTeX/KaTeX/pull/1700 for additional details.
2019-01-18Move assignment to protected to separate stepMatija Čupić
This moves setting the protected attribute of a pipeline to a separate pipeline chain step in order to perform the assignment after validation.