Welcome to mirror list, hosted at ThFree Co, Russian Federation.

gitlab.com/gitlab-org/gitlab-foss.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
path: root/spec
AgeCommit message (Collapse)Author
2018-11-01add related merge request endpointHelmut Januschka
2018-11-01Merge branch 'engwan/gitlab-ce-44012-filter-reactions-none-any'Sean McGivern
2018-11-01Merge branch '52382-filter-milestone-api-none-any' into 'master'Sean McGivern
Resolve "Filter by `None`/`Any` for milestone in issues/mrs API" Closes #52382 See merge request gitlab-org/gitlab-ce!22637
2018-11-01Merge branch 'gt-update-typos-in-comments-and-specs' into 'master'Achilleas Pipinellis
Fix typos in comments and specs See merge request gitlab-org/gitlab-ce!22683
2018-11-01Merge branch 'sh-optimize-merge-request-project-lookup' into 'master'Sean McGivern
Reduce SQL queries needed to load open merge requests See merge request gitlab-org/gitlab-ce!22709
2018-11-01Fix typos in comments and specsGeorge Tsiolis
2018-11-01Fix testsHeinrich Lee Yu
2018-11-01Add testsHeinrich Lee Yu
2018-11-01Update API to accept None and AnyHeinrich Lee Yu
2018-11-01Merge branch 'prettify-all-remaining-things' into 'master'Filipa Lacerda
Prettify remaining files with differences in CE and EE See merge request gitlab-org/gitlab-ce!22702
2018-10-31Merge branch 'gt-fix-quick-links-button-styles' into 'master'Annabel Dunstone Gray
Fix quick links button styles Closes #52220 and #52063 See merge request gitlab-org/gitlab-ce!22657
2018-10-31Fix eslint violationsMike Greiling
2018-10-31Prettify remaining files with differences in CE and EEMike Greiling
2018-10-31Merge branch '53335-cancel-job-redirects-to-job-page' into 'master'Grzegorz Bizon
Send continue parameter on for `cancel_path` Closes #53335 See merge request gitlab-org/gitlab-ce!22712
2018-10-31Use array syntax instead of dig for consistencySteve Azzopardi
We are using hash[symbol][symbol] everywhere else in the test file.
2018-10-31Send continue parameter on for cancel_pathSteve Azzopardi
In https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/21595 `ContinueParams` was introducted in the `Projects::JobController#cancel` since `continue` parameter is not present for in `cancel_path` for `Projects::JobController#show.sjon` the user is being redirect to the pipeline page, where it should be redirected to the current job page instead. Add the `continue` parameter as a query string for `cancel_path`.
2018-10-31Merge branch ↵Filipa Lacerda
'41545-gitlab-merge-request-status-could-not-connect-to-the-ci-server-please-check-your-settings-and-try-again' into 'master' Resolve "Reword error message for internal CI unknown pipeline status" Closes #53056 See merge request gitlab-org/gitlab-ce!22474
2018-10-31Reduce SQL queries needed to load open merge requestsStan Hu
The SQL queries and memory allocation in MergeRequests::RefreshService is dominated by queries for Project and Route loads. On staging, the absence of an inverse relationship caused Rails to make over 1100 extraneous SQL queries for the www-gitlab-com repository. Relates to https://gitlab.com/gitlab-org/gitlab-ce/issues/49703
2018-10-30Merge branch 'add-language-param-to-highlight' into 'master'Douwe Maan
Add language param to highlight See merge request gitlab-org/gitlab-ce!21584
2018-10-30Merge branch 'bvl-move-wrapped-gitaly-errors' into 'master'Douwe Maan
Move Repository#wrapped_gitaly_errors into concern See merge request gitlab-org/gitlab-ce!22691
2018-10-30Resolve "Create new group: Rename form fields and update UI"Martin Wortschack
2018-10-30Move Repository#wrapped_gitaly_errors into concernBob Van Landuyt
Having this in a concern allows us to reuse it for different single purpose classes that call out to git without going through the repository every time.
2018-10-30Merge branch '53227-empty-list' into 'master'Phil Hughes
Resolve "Empty list for links to changed pages in Review App from MR Widget" Closes #53227 See merge request gitlab-org/gitlab-ce!22665
2018-10-30Merge branch 'tc-index-lfs-objects-file-store' into 'master'Douglas Barbosa Alexandre
Enhance performance of counting local LFS objects Closes gitlab-ee#6067 See merge request gitlab-org/gitlab-ce!22143
2018-10-30Merge branch 'winh-pipeline-actions-dynamic-timer' into 'master'Filipa Lacerda
Add dynamic timer for delayed jobs in pipelines list See merge request gitlab-org/gitlab-ce!22621
2018-10-30Merge branch 'mr-diff-discussion-deletion' into 'master'Filipa Lacerda
Fixes diff discussions not being fully removed Closes #53317 See merge request gitlab-org/gitlab-ce!22680
2018-10-30Merge branch 'sh-fix-issue-53153' into 'master'Sean McGivern
Fix extra merge request versions created from forked merge requests Closes #53153 See merge request gitlab-org/gitlab-ce!22611
2018-10-30Runs prettier on changed filesFilipa Lacerda
2018-10-30Prevents review app to render an empty dropdown.Filipa Lacerda
When a deployment has no files to show in the dropdown we fallback to the regular single button for the review app link. This commit moves the review app link into a component since it's used twice.
2018-10-30Fixes diff discussions not being fully removedPhil Hughes
This fixes a bug where a discussion on a none changed line would not get fully removed and therefore leave the comment row empty. This was caused by the discussiob being added to the right when it shouldnt of been This also fixes a very rare edge case where discussions would get added twice to diff lines causing a Vue rendering warning Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/53317
2018-10-30Renaming Secret Variables in the codebaseMarcel Amirault
2018-10-30Allow FoundBlob to access language from gitattributesMark Chao
Extract language_from_git_attributes as a concern so it can ben included in two blob classes.
2018-10-30Move :plain option to Highlight classMark Chao
This is to DRY the repeated file size check. Move spec and constants to Highlight
2018-10-30Make Highlight accept language paramMark Chao
This replaces the repository param. This allows more flexiblity as sometimes we have highlight content not related to repository. Sometimes we know ahead of time the language of the content. Lastly language determination seems better fit as a logic in the Blob class. `repository` param is only used to determine the language, which seems to be the responsiblity of Blob.
2018-10-30Add BlobPresenter for highlightingMark Chao
Force FoundBlob to use BlobPresenter
2018-10-30Add access to Blob's language from gitattributesMark Chao
Ported from Highlight class since it as a concept is more related to blob, and this allows more flexibility.
2018-10-30Add spec for Gitlab::Git::Repository#attributesMark Chao
seed_helper changed because testing requires attributes file in repo, but repo was not a real git repo but instead faked.
2018-10-30Enhance performance of counting local LFS objectsToon Claes
Add an index to the `file_store` column on `lfs_objects`. This makes counting local objects faster. Also, there is no longer need to check for objects with `file_store` being `NULL`. See https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/18557 --- ### Query plans #### Before & with `NULL` ``` Aggregate (cost=113495.96..113495.97 rows=1 width=8) (actual time=1691.394..1691.394 rows=1 loops=1) -> Seq Scan on lfs_objects (cost=0.00..106415.50 rows=2832186 width=0) (actual time=0.012..1312.488 rows=2852607 loops=1) Filter: ((file_store = 1) OR (file_store IS NULL)) Rows Removed by Filter: 131 Planning time: 0.077 ms Execution time: 1691.433 ms ``` #### Before, without `NULL` ``` Aggregate (cost=113495.96..113495.97 rows=1 width=8) (actual time=856.423..856.424 rows=1 loops=1) -> Seq Scan on lfs_objects (cost=0.00..106415.50 rows=2832186 width=0) (actual time=0.012..672.181 rows=2852607 loops=1) Filter: (file_store = 1) Rows Removed by Filter: 131 Planning time: 0.128 ms Execution time: 856.470 ms ``` #### After & with `NULL` ``` Aggregate (cost=68819.95..68819.96 rows=1 width=8) (actual time=583.355..583.355 rows=1 loops=1) -> Index Only Scan using index_lfs_objects_on_file_store on lfs_objects (cost=0.43..61688.35 rows=2852643 width=0) (actual time=0.028..399.177 rows=2852607 loops=1) Filter: ((file_store = 1) OR (file_store IS NULL)) Rows Removed by Filter: 131 Heap Fetches: 867 Planning time: 0.096 ms Execution time: 583.404 ms ``` #### After, without `NULL` ``` Aggregate (cost=68817.29..68817.30 rows=1 width=8) (actual time=490.550..490.551 rows=1 loops=1) -> Index Only Scan using index_lfs_objects_on_file_store on lfs_objects (cost=0.43..61685.68 rows=2852643 width=0) (actual time=0.040..311.760 rows=2852607 loops=1) Index Cond: (file_store = 1) Heap Fetches: 831 Planning time: 0.294 ms Execution time: 490.590 ms ``` Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/6067
2018-10-30Merge remote-tracking branch 'origin/master' into dev-masterJan Provaznik
2018-10-30Fix problem with spec that showed up in EE mergeBrett Walker
2018-10-30Fix extra merge request versions created from forked merge requestsStan Hu
When a forked merge request was created with the same branch name as the target name, MergeRequests::RefreshService would always create a new diff even though nothing had changed. For example, on GitLab.com: 1. There were a number of merge requests in the gitlab-ce and www-gitlab-com projects that had old merge requests from the community. 2. These merge requests originated from forked projects and used the source branch master. 3. When someone pushed to master in the main repository, MergeRequests::RefreshService would see that master matched the merge requests in question and generated a new diff. 4. This led to an explosion of merge request diffs and slowed down the "Changes" tab considerably. This change alters MergeRequests::RefreshService so that it will only refresh the diff if the merge request's source project and branch match. Otherwise, the refresh will only happen if a pushed commit contains a commit relevant to the existing merge request. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/53153
2018-10-30Merge remote-tracking branch 'origin/master' into dev-masterDJ Mountney
2018-10-30Merge branch 'blackst0ne-update-push-new-merge-request-url' into 'master'Douwe Maan
Make new merge request URL more friendly when pushing code Closes #53012 See merge request gitlab-org/gitlab-ce!22526
2018-10-29Delete job_spec.jsWinnie Hellmann
2018-10-29Fix broken "Show whitespace changes" button on MR "Changes" tabJacques Erasmus
2018-10-29Merge branch 'security-2717-fix-issue-title-xss' into 'master'Jan Provaznik
[master] Escape issue title while template rendering to prevent XSS See merge request gitlab/gitlabhq!2556
2018-10-29Merge branch 'security-redact-links' into 'master'Jan Provaznik
[master] Redact unsubscribe links in issuable texts See merge request gitlab/gitlabhq!2528
2018-10-29Merge branch 'fix/control-headers' into 'master'Jan Provaznik
[master] Resolve "Sensitive information is stored in browser history" See merge request gitlab/gitlabhq!2555
2018-10-29Merge branch 'sh-fix-wiki-security-issue-53072' into 'master'Jan Provaznik
[master] Validate Wiki attachments are valid temporary files See merge request gitlab/gitlabhq!2568
2018-10-29[master] Persist only SHA digest of PersonalAccessToken#tokenImre Farkas