| Age | Commit message (Collapse) | Author |
|---|
|
into 'master'"
This reverts merge request !30808
|
|
This change adds a new counter 'cycle_analytics_views' to the usage data
metrics to count the page views for cycle analytics show page.
|
|
Add `ci_dag_limit_needs`
See merge request gitlab-org/gitlab-ce!31803
|
|
We don't use phase restarts, as we use `preload_app`:
https://github.com/puma/puma/blob/master/README.md#clustered-mode
`:puma_phase` values will always be zero.
|
|
Reduce Gitaly calls in PostReceive
Closes #65878
See merge request gitlab-org/gitlab-ce!31741
|
|
This makes to limit `needs:` to 5 by default.
Allow to increase the limit to 50 with disable of FF.
|
|
This adds a notification to let users know of our updated privacy
policy.
Users can dismiss the notification either by following the link or
closing the notification via an "x" icon.
|
|
|
|
|
|
CE backport for gitlab-org/gitlab-ee!14894: Fix the merge button dropdown
See merge request gitlab-org/gitlab-ce!31248
|
|
Require `needs:` to be present
Closes #65839
See merge request gitlab-org/gitlab-ce!31761
|
|
Fix project avatar image in Slack pipeline notifications
Closes #66008
See merge request gitlab-org/gitlab-ce!31788
|
|
Source Code Usage Ping for Create SMAU
|
|
Bump Helm to 2.14.3 and kubectl to 1.11.10
See merge request gitlab-org/gitlab-ce!31716
|
|
|
|
Expand variables only when needed
See merge request gitlab-org/gitlab-ce!31772
|
|
|
|
**Prevention of running 2 simultaneous updates**
Instead of using `RemoteMirror#update_status` and raise an error if
it's already running to prevent the same mirror being updated at the
same time we now use `Gitlab::ExclusiveLease` for that.
When we fail to obtain a lease in 3 tries, 30 seconds apart, we bail
and reschedule. We'll reschedule faster for the protected branches.
If the mirror already ran since it was scheduled, the job will be
skipped.
**Error handling: Remote side**
When an update fails because of a `Gitlab::Git::CommandError`, we
won't track this error in sentry, this could be on the remote side:
for example when branches have diverged.
In this case, we'll try 3 times scheduled 1 or 5 minutes apart.
In between, the mirror is marked as "to_retry", the error would be
visible to the user when they visit the settings page.
After 3 tries we'll mark the mirror as failed and notify the user.
We won't track this error in sentry, as it's not likely we can help
it.
The next event that would trigger a new refresh.
**Error handling: our side**
If an unexpected error occurs, we mark the mirror as failed, but we'd
still retry the job based on the regular sidekiq retries with
backoff. Same as we used to
The error would be reported in sentry, since its likely we need to do
something about it.
|
|
Only expire tag cache once per push
See merge request gitlab-org/gitlab-ce!31641
|
|
This makes us to expand variables only when needed,
instead of requesting all variables each time.
This specifically helps in situation when explicit name
of `environment: production` is used.
|
|
This commit fixes the project avatar images that are rendered in the
footer of Slack pipeline notifications. Previously, the image URLs
provided to Slack were relative URLs; now they are absolute.
|
|
It was originally returning 302 when the rate limit kicks in, because
using the the correct status code makes it easier to track rate limiting
events
Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/65974
|
|
Previously each tag in a push would invoke the Gitaly `FindAllTags` RPC
since the tag cache would be invalidated with every tag.
We can eliminate those extraneous calls by expiring the tag cache once
in `PostReceive` and taking advantage of the cached tags.
Relates to https://gitlab.com/gitlab-org/gitlab-ce/issues/65795
|
|
Only expire branch cache once per push
See merge request gitlab-org/gitlab-ce!31653
|
|
This changes the `needs:` logic to require
that all jobs to be present. Instead of skipping
do fail the pipeline creation if `needs:` dependency
is not found.
|
|
Ensure changelog filenames have length less than 99 characters
See merge request gitlab-org/gitlab-ce!31752
|
|
Require `stage:` to be set with `needs:`
Closes #65568
See merge request gitlab-org/gitlab-ce!31760
|
|
Fix a performance issue in Helm#can_uninstall?
Closes #65963
See merge request gitlab-org/gitlab-ce!31751
|
|
Since we are unsure what would be the behavior of `stage:`
when we work on DAG. Let's make `stage:` to be required
today with `needs:`.
|
|
Remove unused `BuildProcessWorker`
Closes #65539
See merge request gitlab-org/gitlab-ce!31756
|
|
Improve cluster policy spec coverage
See merge request gitlab-org/gitlab-ce!31700
|
|
Signed-off-by: Balasankar "Balu" C <balasankar@gitlab.com>
|
|
We migrated all logic to `PipelineProcessWorker`
and this worker become redundant.
|
|
Convert `spec/javascripts/environments/*rollback*` tests from Jasmine to Jest
Closes #61800
See merge request gitlab-org/gitlab-ce!31021
|
|
This commit reduces I/O load and memory utilization during PostReceive
for the common case when no project hooks or services are set up.
We saw a Gitaly N+1 issue in `CommitDelta` when many tags or branches
are pushed. We can reduce this overhead in the common case because we
observe that most new projects do not have any Web hooks or services,
especially when they are first created. Previously, `BaseHooksService`
unconditionally iterated through the last 20 commits of each ref to
build the `push_data` structure. The `push_data` structured was used in
numerous places:
1. Building the push payload in `EventCreateService`
2. Creating a CI pipeline
3. Executing project Web or system hooks
4. Executing project services
5. As the return value of `BaseHooksService#execute`
6. `BranchHooksService#invalidated_file_types`
We only need to generate the full `push_data` for items 3, 4, and 6.
Item 1: `EventCreateService` only needs the last commit and doesn't
actually need the commit deltas.
Item 2: In addition, `Ci::CreatePipelineService` only needed a subset of
the parameters.
Item 5: The return value of `BaseHooksService#execute` also wasn't being
used anywhere.
Item 6: This is only used when pushing to the default branch, so if
many tags are pushed we can save significant I/O here.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/65878
Fic
|
|
Calling #present? was causing a DB query to happen each time around the
loop. We only wanted to check for nil as it's nil in the first loop
around so there is no need for #present?
|
|
Standardize punctuation and format
|
|
Load search result counts asynchronously (CE)
See merge request gitlab-org/gitlab-ce!31663
|
|
Properly save suggestions in project exports
Closes #65880
See merge request gitlab-org/gitlab-ce!31690
|
|
Creates `refresh_counts` module to dynamically fetch
and load data based on attributes of HAML elements.
|
|
Querying all counts for the different search results in the same request
led to timeouts, so we now only calculate the count for the *current*
search results, and request the others in separate asynchronous calls.
|
|
This commit converts two Jasmine tests into Jest tests.
|
|
Adds highlight to collapsible line in job log
Closes #65790
See merge request gitlab-org/gitlab-ce!31665
|
|
Update GraphicsMagick from 1.3.29 to 1.3.33
See merge request gitlab-org/gitlab-ce!31692
|
|
Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
|
|
This commit fixes an issue that was causing the merge button dropdown
trigger to be shown even if the dropdown itself was hidden. This commit
also fixes an issue that caused the "Merge Immediately" option not to be
available when merge trains were enabled.
|
|
In the job log adds a highlight when hovering
the collapsible line
|
|
Fix active metric files being wiped after the app starts
See merge request gitlab-org/gitlab-ce!31668
|
|
|
|
Add author lines to project import comments
See merge request gitlab-org/gitlab-ce!31579
|
