Age | Commit message (Collapse) | Author |
|
Make all group public
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/1219#
Internal issue - https://dev.gitlab.org/gitlab/gitlabhq/issues/1361
See merge request !1247
|
|
Import forked repositories asynchronously to prevent large repositories from timing out
Preserve synchronous mode of adding a repository since some tasks (e.g. restore/check) require the former.
One side bug fix is that the `ProjectCacheWorker` is also run, updating the repository size and commit numbers properly. Previously all the values were set to 0 when a project were forked.
* Closes #2388
* Closes #2400
See merge request !1231
|
|
|
|
|
|
Clean up overlap between dashboard and explore
- Clean up overlap between dashboard and explore. ... 5d785457
- Split up SnippetsController into separate dashboard and explore sections.
- Use consistent page titles, header titles and sidebars between dashboard and explore sections when signed in or not.
- Consistently case `Back to X` links. 260fcd45
- Link to help from signin page bottom. d92696d3
- Make Help accessible for guests. c258e977
cc @dzaporozhets
See merge request !1260
|
|
Syntax highlighting improvements
On the server side:
During development I would occasionally see SanitizationFilter sanitizing
the result of SyntaxHighlightFilter, even though its attributes were
whitelisted. This updates the `clean_spans` transformer to return the
whitelisted node as [suggested by the Sanitize docs](http://git.io/vZR8i).
On the client side:
- Makes the syntax_highlight JS more flexible
- Adds JS specs
- Simplifies highlighting of new notes
- Adds highlighting to Markdown preview
See merge request !1278
|
|
timing out
Use import_status to track async import status and give feedback to the user
Closes #2388
Closes #2400
|
|
|
|
Also makes it work when given a parent element containing a
`.js-syntax-highlight` element so for dynamically-added things like
notes or Markdown previews, we can more accurately target just the
element we care about.
|
|
Gracefully handle errors in syntax highlighting by leaving the block unformatted
A bug in Rouge caused an Exception:
```undefined method `sub' for :Literal:Symbol```
That caused https://gitlab.com/embeddable-common-lisp/ecl/issues/156 to hit Error 500 and fail to display. If a failure occurs, just render the text as preformatted.
Closes #2433
See merge request !1274
|
|
|
|
Closes #2433
|
|
|
|
Fix emoji URLs in Markdown when relative_url_root is used
Path/URL helpers (e.g. `asset_url_helper`) already include the relative_url_root, so there is no need to attach it twice.
Also adds the ability to run rspecs with relative_url_defined on the enviornment. For example:
RELATIVE_URL_ROOT=/gitlab rspec
Closes #1728
See merge request !1254
|
|
|
|
Global labels
https://dev.gitlab.org/gitlab/gitlabhq/issues/2353
See merge request !1240
|
|
|
|
|
|
|
|
|
|
Re-annotate models
See merge request !1253
|
|
Also adds the ability to run rspecs with relative_url_defined on the enviornment. For example:
RELATIVE_URL_ROOT=/gitlab rspec
Closes #1728
|
|
|
|
Closes internal https://dev.gitlab.org/gitlab/gitlabhq/issues/2466
|
|
Add Content-Type header to fix a bug which IE can't show image in
markdown when the image is from raw.
modified: CHANGELOG
modified: app/controllers/projects/raw_controller.rb
modified: spec/controllers/projects/raw_controller_spec.rb
|
|
|
|
|
|
Remove the filename argument from Content-Disposition header
This MR removes the filename argument from the `Content-Disposition` header to avoid RFC 5987 and RFC 6266 encoding issues. Some browsers (e.g. Internet Explorer) do not properly decode a Unicode string properly, and this can lead to odd filenames in the raw file download. This change allows the browser to determine the filename based on the URL.
For example, if I have a file called `한글한글.pptx` and click to download it with the "Raw" button in the Files section, IE11 will ask:
![image](https://gitlab.com/stanhu/gitlab-ce/uploads/fdb688282c0d4564872deadb44c58b2c/image.png)
If you look at the `Content-Disposition` field, you see this:
![image](https://gitlab.com/stanhu/gitlab-ce/uploads/2b342b83ae1ec61fd31937163ace8ec5/image.png)
Chrome, Firefox, and Safari seem to be able to handle UTF-8 encoded filenames, even though this is not standard.
See: http://greenbytes.de/tech/tc2231/
Closes https://github.com/gitlabhq/gitlabhq/issues/9595
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/1829
I've also submitted a pull request to Rails to support RFC 6266: https://github.com/rails/rails/pull/21461
See merge request !1235
|
|
RFC 5987 and RFC 6266 encoding issues. This change allows the browser
to determine the filename based on the URL.
See: http://greenbytes.de/tech/tc2231/
Closes https://github.com/gitlabhq/gitlabhq/issues/9595
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/1829
|
|
|
|
Decouple Gitlab::Markdown from the GitlabMarkdownHelper
This module is now the sole source of knowledge for *how* we render
Markdown (and GFM).
See merge request !1223
|
|
Import all Bitbucket issues and sort issues by creation date
Previously only the first 15 Bitbucket issues would be imported. Other issues in the API return call also calls import errors.
Tested by importing 400+ issues from this repo: https://bitbucket.org/ned/coveragepy
API reference here: https://bitbucket.org/site/master/issues/3571/api-issues-sorting-bb-3518
Closes https://github.com/gitlabhq/gitlabhq/issues/9519
See merge request !1226
|
|
Also fix a number of issues where author/reporter names were not available.
|
|
Expire cache when merge request source branch was removed
Re-implement !1160 for 8.0. Also we have tests for MergeWorker now! Yay :sparkles:
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
See merge request !1224
|
|
This adds some duplication, but this helper is temporary.
|
|
|
|
Don't notify users without access to the project when they are (accidentally) mentioned in a note.
Addresses #2366.
See merge request !1216
|
|
|
|
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
|
|
|
|
|
|
This module is now the sole source of knowledge for *how* we render
Markdown (and GFM).
|
|
Apply syntax highlighting to fenced code blocks client-side
Instead of applying the syntax highlighting scheme class to these blocks
server-side, we use Javascript and Gon to apply the user's color scheme
(or the default) client-side.
This will make it easier to cache these blocks in the future because
they're no longer state-dependent.
See merge request !1203
|
|
(accidentally) mentioned in a note.
|
|
Update PreferencesHelper specs
|
|
|
|
|
|
Instead of rendering this value server-side, we use Javascript and Gon
to apply the user's color scheme (or the default) to any syntax
highlighted code blocks.
This will make it easier to cache these blocks in the future because
they're no longer state-dependent.
|
|
Very similar to Gitlab::Theme, this contains all of the definitions for
our syntax highlighting schemes.
|
|
Re-enable the "links with adjacent text" UserReferenceFilter spec
See merge request !1194
|