Age | Commit message (Collapse) | Author |
|
Fix 404s for snippet uploads when relative URL root used
Closes #56280
See merge request gitlab-org/gitlab-ce!24588
|
|
Fix import handling errors in Bitbucket Server importer
See merge request gitlab-org/gitlab-ce!24499
|
|
Allow Gitaly to be built from a custom URL
See merge request gitlab-org/gitlab-ce!24616
|
|
Fix 500 errors with legacy appearance logos
Closes gitlab-ee#9357
See merge request gitlab-org/gitlab-ce!24615
|
|
|
|
'52674-api-v4-projects-project_id-jobs-endpoint-hits-statement-timeout' into 'master'
[API] Omit `X-Total` and `X-Total-Pages` headers when items count is more than 10,000
Closes #42194 and #52674
See merge request gitlab-org/gitlab-ce!23931
|
|
Prior to GitLab 9.0, attachments were not tracked the `uploads` table,
so it was possible that the appearance logos were just stored in the
database as a string and mounted via CarrierWave.
https://gitlab.com/gitlab-org/gitlab-ce/issues/29240 implemented in
GitLab 10.3 was supposed to cover populating the `uploads` table for all
attachments, including all the logos from appearances. However, it's
possible that didn't work for logos or the `uploads` entry was orphaned.
GitLab instances that had a customized logo with no associated `uploads`
entry would see Error 500s. The only way to fix this is to delete the
`logo` column from the `appearances` table and re-upload the attachment.
This change makes things more robust by falling back to the original
behavior if the upload is not available.
This is a CE backport of
https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/9277.
Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/9357
|
|
Update Helm to 2.12.2 to address Helm client vulnerability
Closes #56417
See merge request gitlab-org/gitlab-ce!24418
|
|
'25569-changing-wording-to-delete-when-referring-to-removing-a-branch' into 'master'
Resolve "Changing wording to "Delete" when referring to removing a branch"
Closes #25569
See merge request gitlab-org/gitlab-ce!23966
|
|
Fix bug that caused Suggestion Markdown toolbar button to insert snippet with leading +/-/<space>
See merge request gitlab-org/gitlab-ce!24568
|
|
Personal snippet uploads have neither a group nor a project. If a GitLab
instance were configured with a relative URL root (e.g. `/gitlab`), then
the Markdown filter would not include this root in the generated path.
We fix this by adding this root if there is no group or project.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/56280
|
|
Add domain field into Clusters::Cluster
See merge request gitlab-org/gitlab-ce!24368
|
|
This is to match `git branch -D <branchname>`
|
|
Adds inter-service OpenTracing propagation
See merge request gitlab-org/gitlab-ce!24239
|
|
section
|
|
This is the 1st step for moving Auto DevOps domain into cluster
settings, whether is project or group.
Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/52363
|
|
'master'
Removes factories on Cluster background migration
See merge request gitlab-org/gitlab-ce!24536
|
|
Hashed Storage: `AfterRenameService` was not renaming Pages or Uploads folder on legacy storage
Closes #56636
See merge request gitlab-org/gitlab-ce!24526
|
|
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
|
This change allows the GitLab rails and sidekiq components to receive
tracing spans from upstream services such as Workhorse and pass these
spans on to downstream services including Gitaly and Sidekiq.
This change will also emit traces for incoming and outgoing requests
using the propagated trace information. This will allow operators and
engineers to view traces across the Workhorse, GitLab Rails, Sidekiq and
Gitaly components.
Additional intra-service instrumentation will be added in future
changes.
|
|
Before, diff file `higlighted_diff_lines`/`parallel_diff_lines` and
diff discussion `truncated_diff_lines` were inconsistent: `text` and
`rich_text` on the latter included the leading +/-/<space> character,
like on the backend, while the former had no `text` and its `rich_text`
had dropped this char.
This resulted in a bug when the suggestions feature expected these diff
line objects to be identical in format and thus interchangeable, which
was not the case.
|
|
Changed the Caching of User Avatars to be public and to 5 minutes
See merge request gitlab-org/gitlab-ce!24546
|
|
'55966-when-ref-is-ambiguous-createpipelineservice-raises-an-error' into 'master'
Resolve "When ref is ambiguous, `CreatePipelineService` raises an error"
Closes #55966
See merge request gitlab-org/gitlab-ce!24437
|
|
Make favicon tests more fault resistent
Closes #50527
See merge request gitlab-org/gitlab-ce!22686
|
|
'Populate cluster kubernetes namespace' was using factories for their
specs. According to our documentation (see spec/migrations/readme.md),
we should use table helper to create a temproary ActiveRecord::Base
derived model for a table.
|
|
|
|
'master'
Resolve "Related merge requests in issue design - Restyle"
Closes #47007
See merge request gitlab-org/gitlab-ce!24270
|
|
Resolve "Limit sidekiq logging based on argument size"
Closes #56547
See merge request gitlab-org/gitlab-ce!24493
|
|
Fix typos in dev & test docu
See merge request gitlab-org/gitlab-ce!24539
|
|
Resolve "Redirect projects/:id to project page"
Closes #53671
See merge request gitlab-org/gitlab-ce!24467
|
|
We still rely on the Dirty API for project rename (before/after) values,
but we don't access the dirty api from the service class anymore.
The previous value is now part of the initialization, which makes it
easier to test and the behavior is clearer.
The same was done with the `rename_repo` on the Storage classes, we now
provide before and after values as part of the method signature.
|
|
Also removed unnecessary comment
|
|
When logging arguments from Sidekiq to JSON, restrict the size of `args`
to 10 KB (when converted to JSON). This is to avoid blowing up with
excessively large job payloads.
|
|
'53856-changing-group-visibility-does-not-re-enable-save-button' into 'master'
Resolve "Changing group visibility does not re-enable Save button"
Closes #53856
See merge request gitlab-org/gitlab-ce!23022
|
|
Add CSS & JS global flags to represent browser and platform
Closes #50013
See merge request gitlab-org/gitlab-ce!24017
|
|
Fix 404s with snippet uploads in object storage
Closes #52595
See merge request gitlab-org/gitlab-ce!24550
|
|
|
|
|
|
By visiting `projects/:id` you will be redirected to project page with
path in it.
projects/123 => foo/bar
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
|
|
Previously, an HTTP request for
`/uploads/-/system/personal_snippet/:snippet_id/:hash/:filename` would
look for an uploader of `PersonalFileUploader` class and use
`PersonalFileUploader#upload_paths` to search the datbase for one of the
following paths:
1. `:hash/:filename`
2. `uploads/-/system/personal_snippet/:id/:hash/:filename`
However, when the upload were stored in object storage,
`PersonalFileUploader#store_dirs` stored the path as:
`personal_snippet/:snippet_id/:hash`
The extraneous `uploads/-/system` prefix prevented the path from being
matched, and uploads in object storage would return a 404 error. Uploads
in local storage would work fine.
To fix this, we set the `#base_dir` properly so that `#upload_paths`
generates the right value for object storage. Note that this also makes
`#store_dirs` do the right thing in `FileUploader`.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/52595
|
|
Most browsers do not fire the "input" event for checkboxes or radios.
Adds a "change" listener to properly trigger these DirtySubmit updates.
|
|
|
|
|
|
It seems like every new version of Chrome renders the favicon canvas
differently. This reduces the problems with it by creating a more fault
tolerant check, which compares the color values in the pixels and is
okay if they are within a certain threshold.
|
|
Resolve "Don't check confidential issues for spam"
Closes #56371
See merge request gitlab-org/gitlab-ce!24453
|
|
|
|
During a previous refactor on project model, code related to the
hashed storage was extracted into AfterRenameService, see
4b9c17f196bab6075563f62d01f9db65c1a0515c.
The "path_before" was changed from using `previous_changes['path']` to
`path_was`. They are not equivalent. `path_was` exists reliably only
*before* persisting to the database. After database persistence is
confirmed, the value is moved to `previous_changes[:attribute_name]`.
Because the repository/attachments rename or storage upgrade happens
after it was persisted to the database, we were in fact not informing
the right parameters (and therefore not doing what it was supposed to).
|
|
This removes the Protect pipeline chain step and assigns the protected
attribute in the Populate step instead.
|
|
|
|
Eliminate N+1 queries in /api/groups/:id
Closes #49845
See merge request gitlab-org/gitlab-ce!24513
|