From 1f1d0d78a265884b18223e2e1fa6b9cd01ccb415 Mon Sep 17 00:00:00 2001 From: Lin Jen-Shin Date: Fri, 15 Sep 2017 15:50:49 +0800 Subject: Just check ref existence directly --- app/models/merge_request.rb | 4 +--- app/models/repository.rb | 4 ++-- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/app/models/merge_request.rb b/app/models/merge_request.rb index fd722adb156..2a56bab48a3 100644 --- a/app/models/merge_request.rb +++ b/app/models/merge_request.rb @@ -810,13 +810,11 @@ class MergeRequest < ActiveRecord::Base def ref_fetched? super || - if project.repository.exists? + begin computed_value = project.repository.ref_exists?(ref_path) update_column(:ref_fetched, true) if computed_value computed_value - else - false end end diff --git a/app/models/repository.rb b/app/models/repository.rb index 035f85a0b46..6c612f8c5cd 100644 --- a/app/models/repository.rb +++ b/app/models/repository.rb @@ -214,8 +214,8 @@ class Repository end def ref_exists?(ref) - !!raw_repository&.ref_exists?(ref) - rescue ArgumentError + raw_repository.ref_exists?(ref) + rescue Gitlab::Git::Repository::NoRepository, ArgumentError false end -- cgit v1.2.3