From 10b9b95857424609461121233f7d1dca95485b2b Mon Sep 17 00:00:00 2001 From: Bryce Johnson Date: Mon, 27 Feb 2017 18:27:21 +0000 Subject: Document use of AirBnb js styleguide and eslint. --- doc/development/frontend.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/doc/development/frontend.md b/doc/development/frontend.md index ba47998de49..92e4fa50644 100644 --- a/doc/development/frontend.md +++ b/doc/development/frontend.md @@ -238,6 +238,9 @@ readability. See the relevant style guides for our guidelines and for information on linting: - [SCSS][scss-style-guide] +- JavaScript - We defer to [AirBnb][airbnb-js-style-guide] on most style-related +conventions and enforce them with eslint. See [our current .eslintrc][eslistrc] +for specific rules and patterns. ## Testing @@ -434,3 +437,5 @@ Scenario: Developer can approve merge request [state-management]: https://vuejs.org/v2/guide/state-management.html#Simple-State-Management-from-Scratch [vue-resource-repo]: https://github.com/pagekit/vue-resource [issue-boards-service]: https://gitlab.com/gitlab-org/gitlab-ce/blob/master/app/assets/javascripts/boards/services/board_service.js.es6 +[airbnb-js-style-guide]: https://github.com/airbnb/javascript +[eslintrc]: https://gitlab.com/gitlab-org/gitlab-ce/blob/master/.eslintrc \ No newline at end of file -- cgit v1.2.3 From db7c14b599265a5fb3d6a51b1cbb917403d9c6e0 Mon Sep 17 00:00:00 2001 From: Bryce Johnson Date: Tue, 28 Feb 2017 15:09:59 +0000 Subject: Add newline to end of frontend.md. --- doc/development/frontend.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/development/frontend.md b/doc/development/frontend.md index 92e4fa50644..9ba820eaee5 100644 --- a/doc/development/frontend.md +++ b/doc/development/frontend.md @@ -438,4 +438,4 @@ Scenario: Developer can approve merge request [vue-resource-repo]: https://github.com/pagekit/vue-resource [issue-boards-service]: https://gitlab.com/gitlab-org/gitlab-ce/blob/master/app/assets/javascripts/boards/services/board_service.js.es6 [airbnb-js-style-guide]: https://github.com/airbnb/javascript -[eslintrc]: https://gitlab.com/gitlab-org/gitlab-ce/blob/master/.eslintrc \ No newline at end of file +[eslintrc]: https://gitlab.com/gitlab-org/gitlab-ce/blob/master/.eslintrc -- cgit v1.2.3