From 4d3677a52dab1bb5c707ad493dcab8c8bca3dd8b Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Thu, 29 Jun 2023 15:08:00 +0000 Subject: Add latest changes from gitlab-org/gitlab@master --- app/assets/javascripts/google_tag_manager/index.js | 3 + .../sidebar/components/label_filter/index.vue | 31 ++--- .../label_filter/label_dropdown_items.vue | 6 +- .../components/participants/participants.vue | 9 +- .../vue_shared/global_search/constants.js | 20 +++ app/assets/stylesheets/page_bundles/search.scss | 4 +- .../layouts/_google_tag_manager_head.html.haml | 1 + config/feature_flags/ops/gtm_nonce.yml | 2 +- ...10216180232_projects_jira_dvcs_cloud_active.yml | 3 + ...0216180234_projects_jira_dvcs_server_active.yml | 3 + doc/administration/object_storage.md | 2 +- doc/administration/pages/index.md | 144 ++------------------- doc/administration/pages/troubleshooting.md | 4 +- doc/api/groups.md | 4 +- doc/ci/testing/accessibility_testing.md | 22 +--- doc/ci/testing/browser_performance_testing.md | 76 +---------- doc/ci/testing/load_performance_testing.md | 9 +- doc/integration/advanced_search/elasticsearch.md | 7 +- doc/user/admin_area/moderate_users.md | 3 +- doc/user/workspace/index.md | 2 +- lib/gitlab/jwt_authenticatable.rb | 4 +- ...t_projects_with_jira_dvcs_integration_metric.rb | 23 ++++ lib/gitlab/usage_data.rb | 9 +- locale/gitlab.pot | 8 +- qa/qa/runtime/env.rb | 4 + qa/qa/service/docker_run/video.rb | 6 +- rubocop/rubocop-code_reuse.yml | 1 + .../projects/user_sees_user_popover_spec.rb | 2 +- .../search/sidebar/components/label_filter_spec.js | 30 +++++ .../components/participants/participants_spec.js | 13 ++ spec/lib/gitlab/jwt_authenticatable_spec.rb | 26 +++- ...jects_with_jira_dvcs_integration_metric_spec.rb | 50 +++++++ spec/support/helpers/usage_data_helpers.rb | 2 - spec/support/stub_dot_com_check.rb | 2 +- 34 files changed, 246 insertions(+), 289 deletions(-) create mode 100644 lib/gitlab/usage/metrics/instrumentations/count_projects_with_jira_dvcs_integration_metric.rb create mode 100644 spec/lib/gitlab/usage/metrics/instrumentations/count_projects_with_jira_dvcs_integration_metric_spec.rb diff --git a/app/assets/javascripts/google_tag_manager/index.js b/app/assets/javascripts/google_tag_manager/index.js index 0a1a7a74d21..a9ae9a5af82 100644 --- a/app/assets/javascripts/google_tag_manager/index.js +++ b/app/assets/javascripts/google_tag_manager/index.js @@ -129,6 +129,9 @@ export const trackSaasTrialGroup = () => { } const form = document.querySelector('.js-saas-trial-group'); + + if (!form) return; + form.addEventListener('submit', () => { pushEvent('saasTrialGroup'); }); diff --git a/app/assets/javascripts/search/sidebar/components/label_filter/index.vue b/app/assets/javascripts/search/sidebar/components/label_filter/index.vue index 74855482b5d..eb3556ac2cf 100644 --- a/app/assets/javascripts/search/sidebar/components/label_filter/index.vue +++ b/app/assets/javascripts/search/sidebar/components/label_filter/index.vue @@ -14,17 +14,11 @@ import { mapActions, mapState, mapGetters } from 'vuex'; import { uniq } from 'lodash'; import { rgbFromHex } from '@gitlab/ui/dist/utils/utils'; import { slugify } from '~/lib/utils/text_utility'; -import { s__, sprintf } from '~/locale'; +import { sprintf } from '~/locale'; import DropdownKeyboardNavigation from '~/vue_shared/components/dropdown_keyboard_navigation.vue'; -import { - SEARCH_INPUT_DESCRIBE_BY_NO_DROPDOWN, - SEARCH_INPUT_DESCRIBE_BY_WITH_DROPDOWN, - SEARCH_DESCRIBED_BY_DEFAULT, - SEARCH_DESCRIBED_BY_UPDATED, - SEARCH_RESULTS_LOADING, -} from '~/vue_shared/global_search/constants'; +import { I18N } from '~/vue_shared/global_search/constants'; import { HR_DEFAULT_CLASSES, ONLY_SHOW_MD } from '../../constants'; import LabelDropdownItems from './label_dropdown_items.vue'; @@ -60,16 +54,7 @@ export default { isFocused: false, }; }, - i18n: { - SEARCH_LABELS: s__('GlobalSearch|Search labels'), - DROPDOWN_HEADER: s__('GlobalSearch|Label(s)'), - AGGREGATIONS_ERROR_MESSAGE: s__('GlobalSearch|Fetching aggregations error.'), - SEARCH_DESCRIBED_BY_DEFAULT, - SEARCH_RESULTS_LOADING, - SEARCH_DESCRIBED_BY_UPDATED, - SEARCH_INPUT_DESCRIBE_BY_WITH_DROPDOWN, - SEARCH_INPUT_DESCRIBE_BY_NO_DROPDOWN, - }, + i18n: I18N, computed: { ...mapState(['useSidebarNavigation', 'searchLabelString', 'query', 'aggregations']), ...mapGetters([ @@ -260,7 +245,7 @@ export default { :default-index="defaultIndex" :enable-cycle="true" /> -
+
{{ $options.i18n.DROPDOWN_HEADER }} @@ -280,7 +265,13 @@ export default {
- + {{ $options.i18n.NO_LABELS_FOUND }} + {{ $options.i18n.AGGREGATIONS_ERROR_MESSAGE }} diff --git a/app/assets/javascripts/search/sidebar/components/label_filter/label_dropdown_items.vue b/app/assets/javascripts/search/sidebar/components/label_filter/label_dropdown_items.vue index 7a9e6a2e4fc..0b468a60cf0 100644 --- a/app/assets/javascripts/search/sidebar/components/label_filter/label_dropdown_items.vue +++ b/app/assets/javascripts/search/sidebar/components/label_filter/label_dropdown_items.vue @@ -26,15 +26,15 @@ export default { class="gl-px-5 gl-py-3 label-filter-menu-item" > - {{ + {{ label.title }} diff --git a/app/assets/javascripts/sidebar/components/participants/participants.vue b/app/assets/javascripts/sidebar/components/participants/participants.vue index bbd3cda0ad3..bad73273409 100644 --- a/app/assets/javascripts/sidebar/components/participants/participants.vue +++ b/app/assets/javascripts/sidebar/components/participants/participants.vue @@ -1,6 +1,7 @@