From 73af7178a5d5002924603b5688adfaac2d5736eb Mon Sep 17 00:00:00 2001 From: kushalpandya Date: Wed, 31 May 2017 13:50:29 +0530 Subject: Update as per review --- app/views/projects/services/_form.html.haml | 2 +- spec/javascripts/integrations/integration_settings_form_spec.js | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/app/views/projects/services/_form.html.haml b/app/views/projects/services/_form.html.haml index 0f91f08ab10..a51eb4c587e 100644 --- a/app/views/projects/services/_form.html.haml +++ b/app/views/projects/services/_form.html.haml @@ -13,7 +13,7 @@ = render 'shared/service_settings', form: form, subject: @service .footer-block.row-content-block %button.btn.btn-save{ type: 'submit' } - %i.fa.fa-spinner.fa-spin.hidden.js-btn-spinner{ "aria-hidden" => true } + = icon('spinner spin', class: 'hidden js-btn-spinner') %span.js-btn-label Save changes   diff --git a/spec/javascripts/integrations/integration_settings_form_spec.js b/spec/javascripts/integrations/integration_settings_form_spec.js index e2a8259dea9..45909d4e70e 100644 --- a/spec/javascripts/integrations/integration_settings_form_spec.js +++ b/spec/javascripts/integrations/integration_settings_form_spec.js @@ -77,7 +77,6 @@ describe('IntegrationSettingsForm', () => { integrationSettingsForm.toggleSubmitBtnLabel(true); expect(integrationSettingsForm.$submitBtnLabel.text()).toEqual('Save changes'); - integrationSettingsForm.canTestService = true; integrationSettingsForm.toggleSubmitBtnLabel(false); -- cgit v1.2.3