From 74804f8c31491045b62a4b9fed9f819531462ea2 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Thu, 15 Apr 2021 18:09:01 +0000 Subject: Add latest changes from gitlab-org/gitlab@master --- .rubocop_manual_todo.yml | 4 +- GITALY_SERVER_VERSION | 2 +- .../design_management/components/list/item.vue | 3 +- .../edit/components/jira_issues_fields.vue | 50 +- .../edit/components/jira_upgrade_cta.vue | 51 ++ .../projects/commit/components/form_modal.vue | 7 +- .../commit/init_cherry_pick_commit_modal.js | 1 + .../grouped_codequality_reports_app.vue | 2 +- .../components/user_popover/user_popover.vue | 23 +- app/controllers/projects/commit_controller.rb | 2 +- .../projects/merge_requests_controller.rb | 1 - app/controllers/search_controller.rb | 6 +- app/helpers/sidebars_helper.rb | 3 +- app/helpers/workhorse_helper.rb | 12 +- app/models/ci/build.rb | 4 +- app/models/concerns/milestoneish.rb | 2 +- app/models/deployment.rb | 4 +- app/models/environment.rb | 4 +- app/models/merge_request.rb | 4 +- .../sidebars/projects/menus/learn_gitlab/menu.rb | 41 ++ app/models/sidebars/projects/panel.rb | 1 + app/models/user.rb | 2 +- app/serializers/environment_serializer.rb | 54 +- app/services/ci/abort_pipelines_service.rb | 2 +- app/services/ci/drop_pipeline_service.rb | 37 ++ app/views/admin/runners/show.html.haml | 18 +- app/views/groups/runners/edit.html.haml | 9 +- .../layouts/nav/sidebar/_project_menus.html.haml | 8 - app/views/projects/runners/_runner.html.haml | 66 +- app/views/projects/runners/edit.html.haml | 11 +- .../shared/runners/_runner_type_alert.html.haml | 20 + .../shared/runners/_runner_type_badge.html.haml | 10 + app/views/shared/runners/show.html.haml | 15 +- app/workers/all_queues.yml | 8 + app/workers/ci/drop_pipeline_worker.rb | 16 + bin/changelog | 2 +- bin/feature-flag | 2 +- ...letonloading-with-glskeletonloader-in-app-a.yml | 5 + .../323676-add-fk-to-partitioned-web-hook-logs.yml | 5 + ...b-filename-to-attachment-content-dispostion.yml | 5 + ...glicon-size-and-remove-use-deprecated-sizes.yml | 5 + .../326197-project-runners-identifiers.yml | 5 + .../327106-reduce-timeout-on-search-count.yml | 5 + ...icate-runner-type-using-the-alert-component.yml | 5 + .../deprecate_alerts_managed_prometheus.yml | 5 + .../drop-pipelines-async-when-user-blocked.yml | 5 + .../exclude-projects-dropdown-from-revert.yml | 5 + .../unreleased/id-enable-pick-into-project.yml | 5 + .../jl-lower-milestone-issue-display-limit.yml | 5 + .../mo-remove-codequality-backend-ff.yml | 5 + .../optimize-environments-serializer.yml | 5 + .../re-enable-pages-serving-zip-from-disk.yml | 5 + .../development/attachment_with_filename.yml | 8 - .../development/codequality_backend_comparison.yml | 8 - .../pages_serve_with_zip_file_protocol.yml | 2 +- .../development/pick_into_project.yml | 2 +- data/whats_new/202008180003_13_01.yml | 6 +- data/whats_new/202009150001_13_03.yml | 2 +- data/whats_new/202011230001_13_06.yml | 4 +- data/whats_new/202012160001_13_07.yml | 2 +- data/whats_new/202103220001_13_10.yml | 6 +- data/whats_new/templates/YYYYMMDD0001_XX_YY.yml | 2 +- ...210413130011_add_partitioned_web_hook_log_fk.rb | 22 + db/schema_migrations/20210413130011 | 1 + db/structure.sql | 3 + doc/administration/instance_limits.md | 7 +- doc/api/graphql/reference/index.md | 2 +- doc/api/jobs.md | 80 +++ doc/ci/services/gitlab.md | 44 ++ doc/ci/services/index.md | 1 + doc/development/changelog.md | 3 +- doc/development/deprecation_guidelines/index.md | 6 +- doc/development/usage_ping/dictionary.md | 4 +- doc/operations/metrics/alerts.md | 4 + doc/user/application_security/dast/index.md | 6 +- doc/user/group/index.md | 6 + doc/user/packages/dependency_proxy/index.md | 5 + doc/user/project/issues/sorting_issue_lists.md | 6 + doc/user/project/merge_requests/code_quality.md | 5 + doc/user/project/quick_actions.md | 5 +- doc/user/project/time_tracking.md | 15 +- lib/api/entities/clusters/agent.rb | 12 + lib/api/entities/job_request/job_info.rb | 2 +- lib/api/jobs.rb | 30 +- lib/banzai/filter/abstract_reference_filter.rb | 446 ------------- lib/banzai/filter/alert_reference_filter.rb | 29 - lib/banzai/filter/commit_range_reference_filter.rb | 46 -- lib/banzai/filter/commit_reference_filter.rb | 86 --- lib/banzai/filter/design_reference_filter.rb | 107 ---- lib/banzai/filter/epic_reference_filter.rb | 22 - .../filter/external_issue_reference_filter.rb | 118 ---- lib/banzai/filter/feature_flag_reference_filter.rb | 33 - lib/banzai/filter/issuable_reference_filter.rb | 19 - lib/banzai/filter/issue_reference_filter.rb | 57 -- lib/banzai/filter/iteration_reference_filter.rb | 16 - lib/banzai/filter/label_reference_filter.rb | 129 ---- .../filter/merge_request_reference_filter.rb | 97 --- lib/banzai/filter/milestone_reference_filter.rb | 138 ---- lib/banzai/filter/project_reference_filter.rb | 117 ---- lib/banzai/filter/reference_filter.rb | 215 ------- .../filter/references/abstract_reference_filter.rb | 448 +++++++++++++ .../filter/references/alert_reference_filter.rb | 31 + .../references/commit_range_reference_filter.rb | 48 ++ .../filter/references/commit_reference_filter.rb | 88 +++ .../filter/references/design_reference_filter.rb | 109 ++++ .../filter/references/epic_reference_filter.rb | 24 + .../references/external_issue_reference_filter.rb | 120 ++++ .../references/feature_flag_reference_filter.rb | 35 + .../filter/references/issuable_reference_filter.rb | 21 + .../filter/references/issue_reference_filter.rb | 59 ++ .../references/iteration_reference_filter.rb | 18 + .../filter/references/label_reference_filter.rb | 131 ++++ .../references/merge_request_reference_filter.rb | 99 +++ .../references/milestone_reference_filter.rb | 140 ++++ .../filter/references/project_reference_filter.rb | 119 ++++ lib/banzai/filter/references/reference_filter.rb | 217 +++++++ .../filter/references/snippet_reference_filter.rb | 31 + .../filter/references/user_reference_filter.rb | 182 ++++++ .../references/vulnerability_reference_filter.rb | 24 + lib/banzai/filter/snippet_reference_filter.rb | 29 - lib/banzai/filter/user_reference_filter.rb | 180 ------ .../filter/vulnerability_reference_filter.rb | 22 - lib/banzai/pipeline/gfm_pipeline.rb | 26 +- lib/banzai/pipeline/label_pipeline.rb | 2 +- lib/banzai/pipeline/single_line_pipeline.rb | 18 +- lib/gitlab/ci/features.rb | 4 - .../foreign_key_helpers.rb | 74 +++ locale/gitlab.pot | 69 +- scripts/verify-tff-mapping | 2 +- .../designs/raw_images_controller_spec.rb | 11 - spec/db/schema_spec.rb | 3 +- spec/features/runners_spec.rb | 6 +- .../edit/components/jira_issues_fields_spec.js | 49 +- .../edit/components/jira_upgrade_cta_spec.js | 30 + .../projects/commit/components/form_modal_spec.js | 11 +- .../components/user_popover/user_popover_spec.js | 6 +- spec/lib/api/entities/clusters/agent_spec.rb | 16 + .../filter/abstract_reference_filter_spec.rb | 102 --- .../banzai/filter/alert_reference_filter_spec.rb | 223 ------- .../filter/commit_range_reference_filter_spec.rb | 255 -------- .../banzai/filter/commit_reference_filter_spec.rb | 272 -------- .../banzai/filter/design_reference_filter_spec.rb | 287 --------- .../filter/external_issue_reference_filter_spec.rb | 257 -------- .../filter/feature_flag_reference_filter_spec.rb | 223 ------- .../banzai/filter/issue_reference_filter_spec.rb | 549 ---------------- .../banzai/filter/label_reference_filter_spec.rb | 705 --------------------- .../filter/merge_request_reference_filter_spec.rb | 289 --------- .../filter/milestone_reference_filter_spec.rb | 463 -------------- .../banzai/filter/project_reference_filter_spec.rb | 100 --- spec/lib/banzai/filter/reference_filter_spec.rb | 224 ------- .../references/abstract_reference_filter_spec.rb | 102 +++ .../references/alert_reference_filter_spec.rb | 223 +++++++ .../commit_range_reference_filter_spec.rb | 255 ++++++++ .../references/commit_reference_filter_spec.rb | 272 ++++++++ .../references/design_reference_filter_spec.rb | 287 +++++++++ .../external_issue_reference_filter_spec.rb | 257 ++++++++ .../feature_flag_reference_filter_spec.rb | 223 +++++++ .../references/issue_reference_filter_spec.rb | 549 ++++++++++++++++ .../references/label_reference_filter_spec.rb | 705 +++++++++++++++++++++ .../merge_request_reference_filter_spec.rb | 289 +++++++++ .../references/milestone_reference_filter_spec.rb | 463 ++++++++++++++ .../references/project_reference_filter_spec.rb | 100 +++ .../filter/references/reference_filter_spec.rb | 224 +++++++ .../references/snippet_reference_filter_spec.rb | 222 +++++++ .../references/user_reference_filter_spec.rb | 204 ++++++ .../banzai/filter/snippet_reference_filter_spec.rb | 222 ------- .../banzai/filter/user_reference_filter_spec.rb | 204 ------ spec/lib/banzai/pipeline/gfm_pipeline_spec.rb | 2 +- spec/models/merge_request_spec.rb | 20 +- .../projects/menus/learn_gitlab/menu_spec.rb | 31 + spec/models/user_spec.rb | 4 +- .../api/ci/runner/jobs_request_post_spec.rb | 3 +- spec/requests/api/jobs_spec.rb | 12 + spec/serializers/environment_serializer_spec.rb | 50 +- spec/services/ci/drop_pipeline_service_spec.rb | 60 ++ .../controllers/snippet_blob_shared_examples.rb | 10 - .../environment_serializer_shared_examples.rb | 29 + .../layouts/nav/sidebar/_project.html.haml_spec.rb | 10 + spec/views/shared/runners/show.html.haml_spec.rb | 6 +- spec/workers/ci/drop_pipeline_worker_spec.rb | 36 ++ workhorse/_support/changelog | 2 +- 181 files changed, 7429 insertions(+), 6666 deletions(-) create mode 100644 app/assets/javascripts/integrations/edit/components/jira_upgrade_cta.vue create mode 100644 app/models/sidebars/projects/menus/learn_gitlab/menu.rb create mode 100644 app/services/ci/drop_pipeline_service.rb create mode 100644 app/views/shared/runners/_runner_type_alert.html.haml create mode 100644 app/views/shared/runners/_runner_type_badge.html.haml create mode 100644 app/workers/ci/drop_pipeline_worker.rb create mode 100644 changelogs/unreleased/244694-replace-gldeprecatedskeletonloading-with-glskeletonloader-in-app-a.yml create mode 100644 changelogs/unreleased/323676-add-fk-to-partitioned-web-hook-logs.yml create mode 100644 changelogs/unreleased/323714-add-blob-filename-to-attachment-content-dispostion.yml create mode 100644 changelogs/unreleased/324786-update-deprecated-glicon-size-and-remove-use-deprecated-sizes.yml create mode 100644 changelogs/unreleased/326197-project-runners-identifiers.yml create mode 100644 changelogs/unreleased/327106-reduce-timeout-on-search-count.yml create mode 100644 changelogs/unreleased/327199-consistently-indicate-runner-type-using-the-alert-component.yml create mode 100644 changelogs/unreleased/deprecate_alerts_managed_prometheus.yml create mode 100644 changelogs/unreleased/drop-pipelines-async-when-user-blocked.yml create mode 100644 changelogs/unreleased/exclude-projects-dropdown-from-revert.yml create mode 100644 changelogs/unreleased/id-enable-pick-into-project.yml create mode 100644 changelogs/unreleased/jl-lower-milestone-issue-display-limit.yml create mode 100644 changelogs/unreleased/mo-remove-codequality-backend-ff.yml create mode 100644 changelogs/unreleased/optimize-environments-serializer.yml create mode 100644 changelogs/unreleased/re-enable-pages-serving-zip-from-disk.yml delete mode 100644 config/feature_flags/development/attachment_with_filename.yml delete mode 100644 config/feature_flags/development/codequality_backend_comparison.yml create mode 100644 db/post_migrate/20210413130011_add_partitioned_web_hook_log_fk.rb create mode 100644 db/schema_migrations/20210413130011 create mode 100644 doc/ci/services/gitlab.md create mode 100644 lib/api/entities/clusters/agent.rb delete mode 100644 lib/banzai/filter/abstract_reference_filter.rb delete mode 100644 lib/banzai/filter/alert_reference_filter.rb delete mode 100644 lib/banzai/filter/commit_range_reference_filter.rb delete mode 100644 lib/banzai/filter/commit_reference_filter.rb delete mode 100644 lib/banzai/filter/design_reference_filter.rb delete mode 100644 lib/banzai/filter/epic_reference_filter.rb delete mode 100644 lib/banzai/filter/external_issue_reference_filter.rb delete mode 100644 lib/banzai/filter/feature_flag_reference_filter.rb delete mode 100644 lib/banzai/filter/issuable_reference_filter.rb delete mode 100644 lib/banzai/filter/issue_reference_filter.rb delete mode 100644 lib/banzai/filter/iteration_reference_filter.rb delete mode 100644 lib/banzai/filter/label_reference_filter.rb delete mode 100644 lib/banzai/filter/merge_request_reference_filter.rb delete mode 100644 lib/banzai/filter/milestone_reference_filter.rb delete mode 100644 lib/banzai/filter/project_reference_filter.rb delete mode 100644 lib/banzai/filter/reference_filter.rb create mode 100644 lib/banzai/filter/references/abstract_reference_filter.rb create mode 100644 lib/banzai/filter/references/alert_reference_filter.rb create mode 100644 lib/banzai/filter/references/commit_range_reference_filter.rb create mode 100644 lib/banzai/filter/references/commit_reference_filter.rb create mode 100644 lib/banzai/filter/references/design_reference_filter.rb create mode 100644 lib/banzai/filter/references/epic_reference_filter.rb create mode 100644 lib/banzai/filter/references/external_issue_reference_filter.rb create mode 100644 lib/banzai/filter/references/feature_flag_reference_filter.rb create mode 100644 lib/banzai/filter/references/issuable_reference_filter.rb create mode 100644 lib/banzai/filter/references/issue_reference_filter.rb create mode 100644 lib/banzai/filter/references/iteration_reference_filter.rb create mode 100644 lib/banzai/filter/references/label_reference_filter.rb create mode 100644 lib/banzai/filter/references/merge_request_reference_filter.rb create mode 100644 lib/banzai/filter/references/milestone_reference_filter.rb create mode 100644 lib/banzai/filter/references/project_reference_filter.rb create mode 100644 lib/banzai/filter/references/reference_filter.rb create mode 100644 lib/banzai/filter/references/snippet_reference_filter.rb create mode 100644 lib/banzai/filter/references/user_reference_filter.rb create mode 100644 lib/banzai/filter/references/vulnerability_reference_filter.rb delete mode 100644 lib/banzai/filter/snippet_reference_filter.rb delete mode 100644 lib/banzai/filter/user_reference_filter.rb delete mode 100644 lib/banzai/filter/vulnerability_reference_filter.rb create mode 100644 spec/frontend/integrations/edit/components/jira_upgrade_cta_spec.js create mode 100644 spec/lib/api/entities/clusters/agent_spec.rb delete mode 100644 spec/lib/banzai/filter/abstract_reference_filter_spec.rb delete mode 100644 spec/lib/banzai/filter/alert_reference_filter_spec.rb delete mode 100644 spec/lib/banzai/filter/commit_range_reference_filter_spec.rb delete mode 100644 spec/lib/banzai/filter/commit_reference_filter_spec.rb delete mode 100644 spec/lib/banzai/filter/design_reference_filter_spec.rb delete mode 100644 spec/lib/banzai/filter/external_issue_reference_filter_spec.rb delete mode 100644 spec/lib/banzai/filter/feature_flag_reference_filter_spec.rb delete mode 100644 spec/lib/banzai/filter/issue_reference_filter_spec.rb delete mode 100644 spec/lib/banzai/filter/label_reference_filter_spec.rb delete mode 100644 spec/lib/banzai/filter/merge_request_reference_filter_spec.rb delete mode 100644 spec/lib/banzai/filter/milestone_reference_filter_spec.rb delete mode 100644 spec/lib/banzai/filter/project_reference_filter_spec.rb delete mode 100644 spec/lib/banzai/filter/reference_filter_spec.rb create mode 100644 spec/lib/banzai/filter/references/abstract_reference_filter_spec.rb create mode 100644 spec/lib/banzai/filter/references/alert_reference_filter_spec.rb create mode 100644 spec/lib/banzai/filter/references/commit_range_reference_filter_spec.rb create mode 100644 spec/lib/banzai/filter/references/commit_reference_filter_spec.rb create mode 100644 spec/lib/banzai/filter/references/design_reference_filter_spec.rb create mode 100644 spec/lib/banzai/filter/references/external_issue_reference_filter_spec.rb create mode 100644 spec/lib/banzai/filter/references/feature_flag_reference_filter_spec.rb create mode 100644 spec/lib/banzai/filter/references/issue_reference_filter_spec.rb create mode 100644 spec/lib/banzai/filter/references/label_reference_filter_spec.rb create mode 100644 spec/lib/banzai/filter/references/merge_request_reference_filter_spec.rb create mode 100644 spec/lib/banzai/filter/references/milestone_reference_filter_spec.rb create mode 100644 spec/lib/banzai/filter/references/project_reference_filter_spec.rb create mode 100644 spec/lib/banzai/filter/references/reference_filter_spec.rb create mode 100644 spec/lib/banzai/filter/references/snippet_reference_filter_spec.rb create mode 100644 spec/lib/banzai/filter/references/user_reference_filter_spec.rb delete mode 100644 spec/lib/banzai/filter/snippet_reference_filter_spec.rb delete mode 100644 spec/lib/banzai/filter/user_reference_filter_spec.rb create mode 100644 spec/models/sidebars/projects/menus/learn_gitlab/menu_spec.rb create mode 100644 spec/services/ci/drop_pipeline_service_spec.rb create mode 100644 spec/support/shared_examples/serializers/environment_serializer_shared_examples.rb create mode 100644 spec/workers/ci/drop_pipeline_worker_spec.rb diff --git a/.rubocop_manual_todo.yml b/.rubocop_manual_todo.yml index 109d13aa163..dc21c6a62d5 100644 --- a/.rubocop_manual_todo.yml +++ b/.rubocop_manual_todo.yml @@ -1363,8 +1363,8 @@ RSpec/AnyInstanceOf: - 'spec/lib/backup/files_spec.rb' - 'spec/lib/backup/manager_spec.rb' - 'spec/lib/banzai/commit_renderer_spec.rb' - - 'spec/lib/banzai/filter/external_issue_reference_filter_spec.rb' - - 'spec/lib/banzai/filter/issue_reference_filter_spec.rb' + - 'spec/lib/banzai/filter/references/external_issue_reference_filter_spec.rb' + - 'spec/lib/banzai/filter/references/issue_reference_filter_spec.rb' - 'spec/lib/banzai/filter/repository_link_filter_spec.rb' - 'spec/lib/banzai/pipeline/gfm_pipeline_spec.rb' - 'spec/lib/extracts_ref_spec.rb' diff --git a/GITALY_SERVER_VERSION b/GITALY_SERVER_VERSION index 8c745bb4253..1f6f6697a5a 100644 --- a/GITALY_SERVER_VERSION +++ b/GITALY_SERVER_VERSION @@ -1 +1 @@ -6904387a86815c80988d87f23af9d3fe1e2d4c85 +7c28c2a9821c44f3b2115d7fcf74a4816c18dd6c diff --git a/app/assets/javascripts/design_management/components/list/item.vue b/app/assets/javascripts/design_management/components/list/item.vue index 2169c9111d2..b6163491abc 100644 --- a/app/assets/javascripts/design_management/components/list/item.vue +++ b/app/assets/javascripts/design_management/components/list/item.vue @@ -137,8 +137,7 @@ export default { -import { - GlFormGroup, - GlFormCheckbox, - GlFormInput, - GlSprintf, - GlLink, - GlButton, - GlCard, -} from '@gitlab/ui'; +import { GlFormGroup, GlFormCheckbox, GlFormInput, GlSprintf, GlLink } from '@gitlab/ui'; import glFeatureFlagsMixin from '~/vue_shared/mixins/gl_feature_flags_mixin'; import eventHub from '../event_hub'; +import JiraUpgradeCta from './jira_upgrade_cta.vue'; export default { name: 'JiraIssuesFields', @@ -19,8 +12,7 @@ export default { GlFormInput, GlSprintf, GlLink, - GlButton, - GlCard, + JiraUpgradeCta, JiraIssueCreationVulnerabilities: () => import('ee_component/integrations/edit/components/jira_issue_creation_vulnerabilities.vue'), }, @@ -84,11 +76,13 @@ export default { return !this.enableJiraIssues || Boolean(this.projectKey) || !this.validated; }, showJiraVulnerabilitiesOptions() { - return ( - this.enableJiraIssues && - this.showJiraVulnerabilitiesIntegration && - this.glFeatures.jiraForVulnerabilities - ); + return this.showJiraVulnerabilitiesIntegration && this.glFeatures.jiraForVulnerabilities; + }, + showUltimateUpgrade() { + return this.showJiraIssuesIntegration && !this.showJiraVulnerabilitiesIntegration; + }, + showPremiumUpgrade() { + return !this.showJiraIssuesIntegration; }, }, created() { @@ -135,27 +129,23 @@ export default { - - {{ __('This is a Premium feature') }} -

{{ __('Upgrade your plan to enable this feature of the Jira Integration.') }}

- - {{ __('Upgrade your plan') }} - -
+