From cbd81b015621d4ae0076a42e8aa24fd68d36cace Mon Sep 17 00:00:00 2001 From: Mehdi Lahmam Date: Fri, 18 Aug 2017 21:33:59 +0200 Subject: Remove unused `IssuesHelper#bulk_update_milestone_options` Its last usage has been removed at 2e3c082f2a. --- app/helpers/issues_helper.rb | 7 ------- 1 file changed, 7 deletions(-) diff --git a/app/helpers/issues_helper.rb b/app/helpers/issues_helper.rb index 7e1ccb23e9e..2bd5dc9e7aa 100644 --- a/app/helpers/issues_helper.rb +++ b/app/helpers/issues_helper.rb @@ -47,13 +47,6 @@ module IssuesHelper end end - def bulk_update_milestone_options - milestones = @project.milestones.active.reorder(due_date: :asc, title: :asc).to_a - milestones.unshift(Milestone::None) - - options_from_collection_for_select(milestones, 'id', 'title', params[:milestone_id]) - end - def milestone_options(object) milestones = object.project.milestones.active.reorder(due_date: :asc, title: :asc).to_a milestones.unshift(object.milestone) if object.milestone.present? && object.milestone.closed? -- cgit v1.2.3 From fd511639d98962298f4ffb36cb95376bc7c9f19e Mon Sep 17 00:00:00 2001 From: Mehdi Lahmam Date: Fri, 18 Aug 2017 21:53:14 +0200 Subject: Remove unused `IssuesHelper#due_date_options` Its last usage has been removed at 05523b5bd1. --- app/helpers/issues_helper.rb | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/app/helpers/issues_helper.rb b/app/helpers/issues_helper.rb index 2bd5dc9e7aa..02c5911e655 100644 --- a/app/helpers/issues_helper.rb +++ b/app/helpers/issues_helper.rb @@ -141,18 +141,6 @@ module IssuesHelper end.to_h end - def due_date_options - options = [ - Issue::AnyDueDate, - Issue::NoDueDate, - Issue::DueThisWeek, - Issue::DueThisMonth, - Issue::Overdue - ] - - options_from_collection_for_select(options, 'name', 'title', params[:due_date]) - end - def link_to_discussions_to_resolve(merge_request, single_discussion = nil) link_text = merge_request.to_reference link_text += " (discussion #{single_discussion.first_note.id})" if single_discussion -- cgit v1.2.3 From 39b313ba5f22dc265afe33e1f1e2d3d37d373678 Mon Sep 17 00:00:00 2001 From: Mehdi Lahmam Date: Sun, 20 Aug 2017 21:14:24 +0200 Subject: Removed unused `IssuablesHelper#issuable_state_scope` Its last usage has been removed at 260c8da060. --- app/helpers/issuables_helper.rb | 8 -------- 1 file changed, 8 deletions(-) diff --git a/app/helpers/issuables_helper.rb b/app/helpers/issuables_helper.rb index 197c90c4081..00199d065bd 100644 --- a/app/helpers/issuables_helper.rb +++ b/app/helpers/issuables_helper.rb @@ -305,14 +305,6 @@ module IssuablesHelper cookies[:collapsed_gutter] == 'true' end - def issuable_state_scope(issuable) - if issuable.respond_to?(:merged?) && issuable.merged? - :merged - else - issuable.open? ? :opened : :closed - end - end - def issuable_templates(issuable) @issuable_templates ||= case issuable -- cgit v1.2.3 From 9d7971c19b54d0e984c2f38045345f46a7d9d47d Mon Sep 17 00:00:00 2001 From: Mehdi Lahmam Date: Sun, 20 Aug 2017 21:20:50 +0200 Subject: Remove unused `IssuesHelper#merge_requests_sentence` Its last usage has been removed at eb3e7bdfd8. --- app/helpers/issues_helper.rb | 8 -------- spec/helpers/issues_helper_spec.rb | 10 ---------- 2 files changed, 18 deletions(-) diff --git a/app/helpers/issues_helper.rb b/app/helpers/issues_helper.rb index 02c5911e655..1e5339ac9f0 100644 --- a/app/helpers/issues_helper.rb +++ b/app/helpers/issues_helper.rb @@ -86,14 +86,6 @@ module IssuesHelper return 'hidden' if issue.closed? == closed end - def merge_requests_sentence(merge_requests) - # Sorting based on the `!123` or `group/project!123` reference will sort - # local merge requests first. - merge_requests.map do |merge_request| - merge_request.to_reference(@project) - end.sort.to_sentence(last_word_connector: ', or ') - end - def confidential_icon(issue) icon('eye-slash') if issue.confidential? end diff --git a/spec/helpers/issues_helper_spec.rb b/spec/helpers/issues_helper_spec.rb index dc3100311f8..ddf881a7b6f 100644 --- a/spec/helpers/issues_helper_spec.rb +++ b/spec/helpers/issues_helper_spec.rb @@ -58,16 +58,6 @@ describe IssuesHelper do end end - describe "merge_requests_sentence" do - subject { merge_requests_sentence(merge_requests)} - let(:merge_requests) do - [build(:merge_request, iid: 1), build(:merge_request, iid: 2), - build(:merge_request, iid: 3)] - end - - it { is_expected.to eq("!1, !2, or !3") } - end - describe '#award_user_list' do it "returns a comma-separated list of the first X users" do user = build_stubbed(:user, name: 'Joe') -- cgit v1.2.3