From a15c9bc9eb04dcee1369c5fd6248c6352915ad21 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Mon, 6 Dec 2021 18:14:09 +0000 Subject: Add latest changes from gitlab-org/gitlab@master --- .gitlab/ci/rules.gitlab-ci.yml | 3 +- .gitlab/issue_templates/Feature Proposal - lean.md | 2 +- .../notes/components/noteable_discussion.vue | 17 ++--- .../javascripts/notes/components/noteable_note.vue | 13 ++-- .../repository/components/last_commit.vue | 2 +- app/assets/javascripts/repository/index.js | 2 +- .../user_lists/components/add_user_modal.vue | 2 +- app/controllers/projects/forks_controller.rb | 2 + .../google_cloud/service_accounts_controller.rb | 2 +- app/graphql/types/repository/blob_type.rb | 6 ++ app/helpers/sorting_helper.rb | 25 ++++++++ app/models/ci/build.rb | 3 +- app/models/ci/pipeline.rb | 2 +- app/models/commit_status.rb | 4 +- app/models/merge_request.rb | 2 +- app/presenters/blob_presenter.rb | 7 +++ app/presenters/ci/pipeline_presenter.rb | 7 +++ app/presenters/merge_request_presenter.rb | 7 +++ app/serializers/ci/pipeline_entity.rb | 2 +- app/serializers/merge_requests/pipeline_entity.rb | 4 +- app/services/projects/destroy_service.rb | 2 +- app/views/projects/_files.html.haml | 5 +- app/views/projects/forks/index.html.haml | 44 ++++++------- app/views/shared/_milestone_expired.html.haml | 6 +- app/views/shared/milestones/_milestone.html.haml | 6 +- .../package_information/supported_os.md | 6 +- doc/administration/uploads.md | 6 -- doc/api/branches.md | 10 +-- doc/api/graphql/reference/index.md | 1 + doc/api/import.md | 2 +- doc/development/application_slis/index.md | 2 +- doc/development/backend/ruby_style_guide.md | 2 +- doc/development/database/loose_foreign_keys.md | 2 +- doc/development/feature_flags/controls.md | 24 +++---- .../merge_request_performance_guidelines.md | 2 +- doc/development/performance.md | 4 +- doc/development/rails_update.md | 2 +- doc/development/ruby_upgrade.md | 4 +- doc/development/stage_group_dashboards.md | 4 +- doc/development/testing_guide/best_practices.md | 6 +- doc/development/testing_guide/review_apps.md | 1 - doc/install/aws/gitlab_hybrid_on_aws.md | 4 +- doc/install/aws/gitlab_sre_for_aws.md | 6 +- doc/install/aws/manual_install_aws.md | 6 +- doc/install/docker.md | 8 +-- doc/raketasks/backup_restore.md | 11 ++-- doc/update/plan_your_upgrade.md | 2 +- .../container_scanning/index.md | 23 ++++++- lib/gitlab/ci/badge/coverage/report.rb | 2 +- locale/gitlab.pot | 9 ++- package.json | 2 +- qa/qa/resource/base.rb | 14 +++++ qa/spec/resource/base_spec.rb | 11 +++- .../__snapshots__/last_commit_spec.js.snap | 4 +- spec/graphql/types/repository/blob_type_spec.rb | 1 + spec/helpers/sorting_helper_spec.rb | 73 ++++++++++++++++++++++ spec/models/ci/build_spec.rb | 6 ++ spec/models/ci/pipeline_spec.rb | 8 +-- spec/models/merge_request_spec.rb | 2 +- spec/presenters/blob_presenter_spec.rb | 4 ++ spec/presenters/ci/pipeline_presenter_spec.rb | 24 +++++++ spec/presenters/merge_request_presenter_spec.rb | 24 +++++++ spec/serializers/ci/pipeline_entity_spec.rb | 12 ++++ .../merge_requests/pipeline_entity_spec.rb | 5 ++ .../matchers/background_migrations_matchers.rb | 6 +- tooling/bin/qa/check_if_qa_only_spec_changes | 12 ++-- yarn.lock | 8 +-- 67 files changed, 397 insertions(+), 145 deletions(-) diff --git a/.gitlab/ci/rules.gitlab-ci.yml b/.gitlab/ci/rules.gitlab-ci.yml index 19fb8ced4ab..bb937bcc31a 100644 --- a/.gitlab/ci/rules.gitlab-ci.yml +++ b/.gitlab/ci/rules.gitlab-ci.yml @@ -11,7 +11,7 @@ if: '$CI_PROJECT_NAME != "gitlab-foss" && $CI_PROJECT_NAME != "gitlab-ce" && $CI_PROJECT_NAME != "gitlabhq"' .if-jh: &if-jh - if: '$CI_PROJECT_PATH == "gitlab-jh/gitlab"' + if: '$CI_PROJECT_PATH =~ /^gitlab-(jh|cn)\/.*/' .if-default-refs: &if-default-refs if: '$CI_COMMIT_REF_NAME == $CI_DEFAULT_BRANCH || $CI_COMMIT_REF_NAME =~ /^[\d-]+-stable(-ee)?$/ || $CI_COMMIT_REF_NAME =~ /^\d+-\d+-auto-deploy-\d+$/ || $CI_COMMIT_REF_NAME =~ /^security\// || $CI_MERGE_REQUEST_IID || $CI_COMMIT_TAG || $FORCE_GITLAB_CI' @@ -1582,7 +1582,6 @@ allow_failure: true - <<: *if-dot-com-gitlab-org-merge-request changes: *qa-patterns - - <<: *if-dot-com-gitlab-org-schedule .review:rules:review-build-cng: rules: diff --git a/.gitlab/issue_templates/Feature Proposal - lean.md b/.gitlab/issue_templates/Feature Proposal - lean.md index 504bfbb03d8..05376ac60fa 100644 --- a/.gitlab/issue_templates/Feature Proposal - lean.md +++ b/.gitlab/issue_templates/Feature Proposal - lean.md @@ -40,7 +40,7 @@ Personas are described at https://about.gitlab.com/handbook/marketing/product-ma ### Metrics -