From d0f16d56f3716d4a60027eb261f12080094f8db3 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Wed, 22 Feb 2023 18:07:44 +0000 Subject: Add latest changes from gitlab-org/gitlab@master --- .rubocop_todo/gitlab/strong_memoize_attr.yml | 1 - .rubocop_todo/layout/argument_alignment.yml | 1 - .rubocop_todo/layout/line_length.yml | 1 - .rubocop_todo/naming/heredoc_delimiter_naming.yml | 1 - .rubocop_todo/performance/map_compact.yml | 1 - .rubocop_todo/performance/string_include.yml | 9 - .rubocop_todo/rake/require.yml | 2 - .rubocop_todo/rspec/missing_feature_category.yml | 1 - .rubocop_todo/style/if_unless_modifier.yml | 1 - .../search/sidebar/components/checkbox_filter.vue | 16 +- .../search/sidebar/components/language_filter.vue | 40 +++- app/assets/javascripts/search/sidebar/utils.js | 27 ++- app/assets/javascripts/search/store/actions.js | 13 +- app/assets/javascripts/search/store/getters.js | 10 + app/assets/javascripts/search/store/mutations.js | 2 +- app/assets/javascripts/search/store/utils.js | 5 + .../components/approvals/approvals.vue | 49 ++--- .../components/approvals/approvals_summary.vue | 72 ++----- .../approvals/queries/approvals.query.graphql | 18 ++ .../approvals/queries/approved_by.query.graphql | 16 -- .../javascripts/vue_merge_request_widget/index.js | 13 +- .../vue_merge_request_widget/mixins/approvals.js | 27 +++ .../stores/mr_widget_store.js | 3 +- .../ci/runner/common_mutation_arguments.rb | 50 +++++ app/graphql/mutations/ci/runner/create.rb | 44 +++++ app/graphql/mutations/ci/runner/update.rb | 39 +--- app/graphql/types/mutation_type.rb | 1 + app/models/concerns/ci/has_status.rb | 2 +- app/models/namespaces/traversal/linear.rb | 2 - app/services/ci/runners/create_runner_service.rb | 2 +- .../import/validate_remote_git_endpoint_service.rb | 4 +- .../development/set_traversal_ids_on_save.yml | 8 - danger/plugins/sidekiq_args.rb | 10 + danger/sidekiq_args/Dangerfile | 5 + .../templates/_deprecation_template.md.erb | 4 +- doc/administration/lfs/index.md | 12 ++ doc/api/graphql/reference/index.md | 31 +++ doc/subscriptions/gitlab_com/index.md | 2 +- doc/subscriptions/index.md | 21 +- doc/update/deprecations.md | 4 +- lib/gitlab/auth/user_access_denied_reason.rb | 3 +- lib/gitlab/ci/status/composite.rb | 21 +- .../github_import/importer/repository_importer.rb | 15 +- lib/gitlab/legacy_github_import/importer.rb | 47 +++-- lib/gitlab/usage_data.rb | 2 +- lib/tasks/gitlab/terraform/migrate.rake | 2 - lib/tasks/gitlab/tw/codeowners.rake | 2 - locale/gitlab.pot | 3 + rubocop/cop/gitlab/json.rb | 6 +- spec/frontend/approvals/mock_data.js | 10 + spec/frontend/fixtures/merge_requests.rb | 6 +- .../sidebar/components/checkbox_filter_spec.js | 9 +- .../sidebar/components/language_filter_spec.js | 173 +++++++++++++++++ .../sidebar/components/language_filters_spec.js | 152 --------------- spec/frontend/search/store/actions_spec.js | 22 +++ spec/frontend/search/store/getters_spec.js | 37 ++-- spec/frontend/search/store/utils_spec.js | 13 +- .../components/approvals/approvals_spec.js | 215 +++++++-------------- .../components/approvals/approvals_summary_spec.js | 14 +- .../mr_widget_options_spec.js | 3 + .../gitlab/legacy_github_import/importer_spec.rb | 31 +-- spec/models/namespace_spec.rb | 23 --- .../api/graphql/mutations/ci/runner/create_spec.rb | 121 ++++++++++++ .../ci/runners/create_runner_service_spec.rb | 43 +++++ .../validate_remote_git_endpoint_service_spec.rb | 24 ++- spec/tooling/danger/sidekiq_args_spec.rb | 125 ++++++++++++ tooling/danger/sidekiq_args.rb | 59 ++++++ 67 files changed, 1117 insertions(+), 634 deletions(-) delete mode 100644 .rubocop_todo/performance/string_include.yml create mode 100644 app/assets/javascripts/vue_merge_request_widget/components/approvals/queries/approvals.query.graphql delete mode 100644 app/assets/javascripts/vue_merge_request_widget/components/approvals/queries/approved_by.query.graphql create mode 100644 app/graphql/mutations/ci/runner/common_mutation_arguments.rb create mode 100644 app/graphql/mutations/ci/runner/create.rb delete mode 100644 config/feature_flags/development/set_traversal_ids_on_save.yml create mode 100644 danger/plugins/sidekiq_args.rb create mode 100644 danger/sidekiq_args/Dangerfile create mode 100644 spec/frontend/approvals/mock_data.js create mode 100644 spec/frontend/search/sidebar/components/language_filter_spec.js delete mode 100644 spec/frontend/search/sidebar/components/language_filters_spec.js create mode 100644 spec/requests/api/graphql/mutations/ci/runner/create_spec.rb create mode 100644 spec/tooling/danger/sidekiq_args_spec.rb create mode 100644 tooling/danger/sidekiq_args.rb diff --git a/.rubocop_todo/gitlab/strong_memoize_attr.yml b/.rubocop_todo/gitlab/strong_memoize_attr.yml index 1eeb7c69a96..04f76fbe260 100644 --- a/.rubocop_todo/gitlab/strong_memoize_attr.yml +++ b/.rubocop_todo/gitlab/strong_memoize_attr.yml @@ -647,7 +647,6 @@ Gitlab/StrongMemoizeAttr: - 'lib/gitlab/git_access_project.rb' - 'lib/gitlab/gitaly_client/with_feature_flag_actors.rb' - 'lib/gitlab/github_import/client.rb' - - 'lib/gitlab/github_import/importer/repository_importer.rb' - 'lib/gitlab/github_import/representation/diff_notes/suggestion_formatter.rb' - 'lib/gitlab/gl_repository/identifier.rb' - 'lib/gitlab/gpg/commit.rb' diff --git a/.rubocop_todo/layout/argument_alignment.yml b/.rubocop_todo/layout/argument_alignment.yml index 48c39454d8d..be2b77ef81e 100644 --- a/.rubocop_todo/layout/argument_alignment.yml +++ b/.rubocop_todo/layout/argument_alignment.yml @@ -2048,7 +2048,6 @@ Layout/ArgumentAlignment: - 'lib/gitlab/import_export/snippets_repo_restorer.rb' - 'lib/gitlab/import_export/snippets_repo_saver.rb' - 'lib/gitlab/issuable/clone/copy_resource_events_service.rb' - - 'lib/gitlab/legacy_github_import/importer.rb' - 'lib/gitlab/mail_room.rb' - 'lib/gitlab/markdown_cache/redis/store.rb' - 'lib/gitlab/memory/reports_uploader.rb' diff --git a/.rubocop_todo/layout/line_length.yml b/.rubocop_todo/layout/line_length.yml index 772284a6ce7..12683ec3831 100644 --- a/.rubocop_todo/layout/line_length.yml +++ b/.rubocop_todo/layout/line_length.yml @@ -3062,7 +3062,6 @@ Layout/LineLength: - 'lib/gitlab/kubernetes/helm/pod.rb' - 'lib/gitlab/kubernetes/kubectl_cmd.rb' - 'lib/gitlab/kubernetes/pod_cmd.rb' - - 'lib/gitlab/legacy_github_import/importer.rb' - 'lib/gitlab/legacy_github_import/project_creator.rb' - 'lib/gitlab/local_and_remote_storage_migration/base_migrater.rb' - 'lib/gitlab/lograge/custom_options.rb' diff --git a/.rubocop_todo/naming/heredoc_delimiter_naming.yml b/.rubocop_todo/naming/heredoc_delimiter_naming.yml index ae71e06b6d3..b92d316b693 100644 --- a/.rubocop_todo/naming/heredoc_delimiter_naming.yml +++ b/.rubocop_todo/naming/heredoc_delimiter_naming.yml @@ -50,7 +50,6 @@ Naming/HeredocDelimiterNaming: - 'rubocop/cop/default_scope.rb' - 'rubocop/cop/file_decompression.rb' - 'rubocop/cop/gitlab/httparty.rb' - - 'rubocop/cop/gitlab/json.rb' - 'rubocop/cop/gitlab/module_with_instance_variables.rb' - 'rubocop/cop/gitlab/predicate_memoization.rb' - 'spec/controllers/projects/pipelines_controller_spec.rb' diff --git a/.rubocop_todo/performance/map_compact.yml b/.rubocop_todo/performance/map_compact.yml index ca0e8d604fd..c3586b35cf3 100644 --- a/.rubocop_todo/performance/map_compact.yml +++ b/.rubocop_todo/performance/map_compact.yml @@ -116,7 +116,6 @@ Performance/MapCompact: - 'lib/gitlab/jira_import/metadata_collector.rb' - 'lib/gitlab/json_cache.rb' - 'lib/gitlab/language_detection.rb' - - 'lib/gitlab/legacy_github_import/importer.rb' - 'lib/gitlab/private_commit_email.rb' - 'lib/gitlab/sql/pattern.rb' - 'lib/gitlab/url_blocker.rb' diff --git a/.rubocop_todo/performance/string_include.yml b/.rubocop_todo/performance/string_include.yml deleted file mode 100644 index f2e17d3576a..00000000000 --- a/.rubocop_todo/performance/string_include.yml +++ /dev/null @@ -1,9 +0,0 @@ ---- -# Cop supports --autocorrect. -Performance/StringInclude: - Details: grace period - Exclude: - - 'lib/gitlab/github_import/importer/repository_importer.rb' - - 'lib/gitlab/legacy_github_import/importer.rb' - - 'lib/gitlab/usage_data.rb' - - 'rubocop/cop/gitlab/json.rb' diff --git a/.rubocop_todo/rake/require.yml b/.rubocop_todo/rake/require.yml index e3cd483f056..9820ce7d03c 100644 --- a/.rubocop_todo/rake/require.yml +++ b/.rubocop_todo/rake/require.yml @@ -12,8 +12,6 @@ Rake/Require: - 'lib/tasks/gitlab/packages/migrate.rake' - 'lib/tasks/gitlab/pages.rake' - 'lib/tasks/gitlab/refresh_project_statistics_build_artifacts_size.rake' - - 'lib/tasks/gitlab/terraform/migrate.rake' - - 'lib/tasks/gitlab/tw/codeowners.rake' - 'lib/tasks/gitlab/x509/update.rake' - 'lib/tasks/import.rake' - 'lib/tasks/tokens.rake' diff --git a/.rubocop_todo/rspec/missing_feature_category.yml b/.rubocop_todo/rspec/missing_feature_category.yml index 6c5694293f8..5f4d4dda292 100644 --- a/.rubocop_todo/rspec/missing_feature_category.yml +++ b/.rubocop_todo/rspec/missing_feature_category.yml @@ -5057,7 +5057,6 @@ RSpec/MissingFeatureCategory: - 'spec/lib/gitlab/legacy_github_import/branch_formatter_spec.rb' - 'spec/lib/gitlab/legacy_github_import/client_spec.rb' - 'spec/lib/gitlab/legacy_github_import/comment_formatter_spec.rb' - - 'spec/lib/gitlab/legacy_github_import/importer_spec.rb' - 'spec/lib/gitlab/legacy_github_import/issuable_formatter_spec.rb' - 'spec/lib/gitlab/legacy_github_import/issue_formatter_spec.rb' - 'spec/lib/gitlab/legacy_github_import/label_formatter_spec.rb' diff --git a/.rubocop_todo/style/if_unless_modifier.yml b/.rubocop_todo/style/if_unless_modifier.yml index efdb0df8341..cda00940294 100644 --- a/.rubocop_todo/style/if_unless_modifier.yml +++ b/.rubocop_todo/style/if_unless_modifier.yml @@ -891,7 +891,6 @@ Style/IfUnlessModifier: - 'lib/gitlab/jira_import.rb' - 'lib/gitlab/jira_import/base_importer.rb' - 'lib/gitlab/legacy_github_import/client.rb' - - 'lib/gitlab/legacy_github_import/importer.rb' - 'lib/gitlab/legacy_github_import/issuable_formatter.rb' - 'lib/gitlab/legacy_github_import/project_creator.rb' - 'lib/gitlab/lograge/custom_options.rb' diff --git a/app/assets/javascripts/search/sidebar/components/checkbox_filter.vue b/app/assets/javascripts/search/sidebar/components/checkbox_filter.vue index b580d58b21b..36cbe9ce693 100644 --- a/app/assets/javascripts/search/sidebar/components/checkbox_filter.vue +++ b/app/assets/javascripts/search/sidebar/components/checkbox_filter.vue @@ -1,6 +1,6 @@