From d19717cba65ef3ae6f76ec25140ab5c255b27d42 Mon Sep 17 00:00:00 2001 From: Heinrich Lee Yu Date: Thu, 25 Jul 2019 17:29:51 +0800 Subject: Backport Jira issue key regex --- app/models/project_services/jira_service.rb | 2 +- lib/gitlab/regex.rb | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/app/models/project_services/jira_service.rb b/app/models/project_services/jira_service.rb index 7ab79242cc3..d08fcd8954d 100644 --- a/app/models/project_services/jira_service.rb +++ b/app/models/project_services/jira_service.rb @@ -31,7 +31,7 @@ class JiraService < IssueTrackerService # {PROJECT-KEY}-{NUMBER} Examples: JIRA-1, PROJECT-1 def self.reference_pattern(only_long: true) - @reference_pattern ||= /(?\b([A-Z][A-Z0-9_]+-)\d+)/ + @reference_pattern ||= /(?\b#{Gitlab::Regex.jira_issue_key_regex})/ end def initialize_properties diff --git a/lib/gitlab/regex.rb b/lib/gitlab/regex.rb index e43147a3f37..21614ea003e 100644 --- a/lib/gitlab/regex.rb +++ b/lib/gitlab/regex.rb @@ -94,6 +94,12 @@ module Gitlab }mx end + # Based on Jira's project key format + # https://confluence.atlassian.com/adminjiraserver073/changing-the-project-key-format-861253229.html + def jira_issue_key_regex + @jira_issue_key_regex ||= /[A-Z][A-Z_0-9]+-\d+/ + end + def jira_transition_id_regex @jira_transition_id_regex ||= /\d+/ end -- cgit v1.2.3