From f163fc8ce6d7661ccf0ff9aa4561f6e5a708b71b Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Mon, 13 Dec 2021 21:14:32 +0000 Subject: Add latest changes from gitlab-org/gitlab@master --- .gitlab/ci/qa.gitlab-ci.yml | 1 + .gitlab/ci/review.gitlab-ci.yml | 4 +- .gitlab/ci/rules.gitlab-ci.yml | 20 +- .rubocop_todo/style/open_struct_use.yml | 2 - GITALY_SERVER_VERSION | 2 +- .../javascripts/header_search/components/app.vue | 15 +- .../javascripts/header_search/store/actions.js | 4 + .../header_search/store/mutation_types.js | 1 + .../javascripts/header_search/store/mutations.js | 3 + app/controllers/projects/jobs_controller.rb | 4 +- app/mailers/emails/in_product_marketing.rb | 8 +- app/serializers/build_details_entity.rb | 4 +- app/serializers/build_serializer.rb | 10 - app/serializers/ci/job_entity.rb | 96 +++++++++ app/serializers/ci/job_serializer.rb | 12 ++ app/serializers/ci/pipeline_entity.rb | 2 +- app/serializers/deployment_entity.rb | 8 +- app/serializers/job_entity.rb | 94 -------- app/serializers/job_group_entity.rb | 2 +- app/serializers/stage_entity.rb | 4 +- doc/ci/runners/configure_runners.md | 10 +- doc/ci/variables/predefined_variables.md | 2 + .../testing_guide/end_to_end/best_practices.md | 18 +- .../end_to_end/rspec_metadata_tests.md | 2 +- doc/development/testing_guide/review_apps.md | 1 + doc/user/clusters/agent/install/index.md | 3 + lib/gitlab/email/message/account_validation.rb | 96 --------- .../api/1_manage/bulk_import_group_spec.rb | 6 +- .../api/1_manage/import_github_repo_spec.rb | 2 +- .../api/1_manage/import_large_github_repo_spec.rb | 2 +- .../api/1_manage/project_access_token_spec.rb | 8 +- .../features/api/1_manage/rate_limits_spec.rb | 2 +- .../api/1_manage/user_access_termination_spec.rb | 6 +- qa/qa/specs/features/api/1_manage/users_spec.rb | 6 +- .../closes_issue_via_pushing_a_commit_spec.rb | 2 +- .../gitaly/automatic_failover_and_recovery_spec.rb | 4 +- .../3_create/gitaly/backend_node_recovery_spec.rb | 2 +- .../gitaly/changing_repository_storage_spec.rb | 4 +- .../api/3_create/gitaly/distributed_reads_spec.rb | 4 +- .../api/3_create/gitaly/gitaly_mtls_spec.rb | 2 +- .../gitaly/praefect_replication_queue_spec.rb | 2 +- .../api/3_create/gitaly/praefect_repo_sync_spec.rb | 2 +- .../merge_request/push_options_labels_spec.rb | 4 +- .../merge_request/push_options_mwps_spec.rb | 4 +- .../push_options_remove_source_branch_spec.rb | 2 +- .../push_options_target_branch_spec.rb | 2 +- .../push_options_title_description_spec.rb | 2 +- .../repository/default_branch_name_setting_spec.rb | 4 +- .../features/api/3_create/repository/files_spec.rb | 4 +- .../repository/project_archive_compare_spec.rb | 2 +- .../repository/push_postreceive_idempotent_spec.rb | 4 +- .../snippet_repository_storage_move_spec.rb | 2 +- .../cancel_pipeline_when_block_user_spec.rb | 2 +- .../api/5_package/container_registry_spec.rb | 2 +- .../14_non_devops/performance_bar_spec.rb | 2 +- .../1_manage/group/bulk_import_group_spec.rb | 2 +- .../create_group_with_mattermost_team_spec.rb | 2 +- .../1_manage/group/transfer_group_spec.rb | 2 +- .../1_manage/group/transfer_project_spec.rb | 2 +- .../browser_ui/1_manage/login/2fa_recovery_spec.rb | 2 +- .../1_manage/login/2fa_ssh_recovery_spec.rb | 2 +- .../browser_ui/1_manage/login/log_in_spec.rb | 2 +- .../1_manage/login/log_in_with_2fa_spec.rb | 2 +- .../login/log_into_gitlab_via_ldap_spec.rb | 2 +- .../login/log_into_mattermost_via_gitlab_spec.rb | 2 +- .../login/login_via_instance_wide_saml_sso_spec.rb | 2 +- .../login/maintain_log_in_mixed_env_spec.rb | 2 +- .../browser_ui/1_manage/login/register_spec.rb | 8 +- .../1_manage/project/add_project_member_spec.rb | 2 +- .../1_manage/project/create_project_spec.rb | 4 +- .../1_manage/project/dashboard_images_spec.rb | 4 +- .../1_manage/project/import_github_repo_spec.rb | 2 +- .../1_manage/project/project_access_token_spec.rb | 2 +- .../1_manage/project/view_project_activity_spec.rb | 2 +- .../1_manage/user/follow_user_activity_spec.rb | 2 +- .../1_manage/user/user_access_termination_spec.rb | 2 +- .../email/trigger_email_notification_spec.rb | 2 +- .../2_plan/issue/check_mentions_for_xss_spec.rb | 2 +- .../issue/collapse_comments_in_discussions_spec.rb | 2 +- .../browser_ui/2_plan/issue/comment_issue_spec.rb | 2 +- .../browser_ui/2_plan/issue/create_issue_spec.rb | 6 +- .../2_plan/issue/custom_issue_template_spec.rb | 2 +- .../browser_ui/2_plan/issue/export_as_csv_spec.rb | 2 +- .../2_plan/issue/filter_issue_comments_spec.rb | 2 +- .../2_plan/issue/issue_suggestions_spec.rb | 2 +- .../2_plan/issue/jira_issue_import_spec.rb | 2 +- .../browser_ui/2_plan/issue/mentions_spec.rb | 2 +- .../2_plan/issue/real_time_assignee_spec.rb | 2 +- .../2_plan/issue_boards/focus_mode_spec.rb | 2 +- .../milestone/create_group_milestone_spec.rb | 2 +- .../milestone/create_project_milestone_spec.rb | 2 +- .../2_plan/related_issues/related_issues_spec.rb | 2 +- .../2_plan/transient/comment_on_discussion_spec.rb | 2 +- .../design_management/add_design_content_spec.rb | 2 +- .../archive_design_content_spec.rb | 2 +- .../modify_design_content_spec.rb | 2 +- .../3_create/jenkins/jenkins_build_status_spec.rb | 2 +- .../3_create/jira/jira_basic_integration_spec.rb | 4 +- .../cherry_pick/cherry_pick_a_merge_spec.rb | 2 +- .../cherry_pick/cherry_pick_commit_spec.rb | 2 +- .../merge_request/create_merge_request_spec.rb | 4 +- .../create_merge_request_via_template_spec.rb | 2 +- .../merge_merge_request_from_fork_spec.rb | 2 +- .../merge_when_pipeline_succeeds_spec.rb | 4 +- .../merge_request/rebase_merge_request_spec.rb | 2 +- .../merge_request/revert/revert_commit_spec.rb | 2 +- .../revert/reverting_merge_request_spec.rb | 2 +- .../merge_request/squash_merge_request_spec.rb | 2 +- .../suggestions/batch_suggestion_spec.rb | 2 +- .../suggestions/custom_commit_suggestion_spec.rb | 2 +- .../view_merge_request_diff_patch_spec.rb | 4 +- .../view_merge_request_merge_ref_diff_spec.rb | 4 +- .../repository/add_list_delete_branches_spec.rb | 2 +- .../repository/branch_with_unusual_name_spec.rb | 2 +- .../browser_ui/3_create/repository/clone_spec.rb | 4 +- .../repository/file/create_file_via_web_spec.rb | 2 +- .../repository/file/delete_file_via_web_spec.rb | 2 +- .../repository/file/edit_file_via_web_spec.rb | 2 +- .../repository/file/file_with_unusual_name_spec.rb | 2 +- .../repository/move_project_create_fork_spec.rb | 2 +- .../repository/protocol_v2_push_http_spec.rb | 2 +- .../repository/protocol_v2_push_ssh_spec.rb | 2 +- .../repository/push_http_private_token_spec.rb | 2 +- .../push_mirroring_lfs_over_http_spec.rb | 2 +- .../repository/push_mirroring_over_http_spec.rb | 2 +- .../repository/push_over_http_file_size_spec.rb | 4 +- .../3_create/repository/push_over_http_spec.rb | 4 +- .../3_create/repository/push_over_ssh_spec.rb | 4 +- .../repository/push_protected_branch_spec.rb | 4 +- .../3_create/repository/ssh_key_support_spec.rb | 4 +- .../user_views_commit_diff_patch_spec.rb | 4 +- .../clone_push_pull_personal_snippet_spec.rb | 4 +- .../clone_push_pull_project_snippet_spec.rb | 4 +- .../snippet/create_personal_snippet_spec.rb | 2 +- ...te_personal_snippet_with_multiple_files_spec.rb | 2 +- .../snippet/create_project_snippet_spec.rb | 2 +- ...ate_project_snippet_with_multiple_files_spec.rb | 2 +- .../3_create/snippet/share_snippet_spec.rb | 4 +- .../web_ide/add_new_directory_in_web_ide_spec.rb | 4 +- .../web_ide/create_first_file_in_web_ide_spec.rb | 2 +- .../web_ide/link_to_line_in_web_ide_spec.rb | 2 +- .../3_create/web_ide/open_fork_in_web_ide_spec.rb | 4 +- .../web_ide/open_web_ide_from_diff_tab_spec.rb | 2 +- .../3_create/web_ide/review_merge_request_spec.rb | 2 +- .../web_ide/upload_new_file_in_web_ide_spec.rb | 8 +- .../3_create/web_ide/web_terminal_spec.rb | 2 +- .../3_create/wiki/content_editor_spec.rb | 2 +- .../wiki/project_based_content_creation_spec.rb | 8 +- .../project_based_content_manipulation_spec.rb | 4 +- .../project_based_directory_management_spec.rb | 2 +- .../3_create/wiki/project_based_list_spec.rb | 4 +- .../wiki/project_based_page_deletion_spec.rb | 2 +- .../ci_variable/add_remove_ci_variable_spec.rb | 4 +- .../pipeline_with_protected_variable_spec.rb | 4 +- .../pipeline/create_and_process_pipeline_spec.rb | 2 +- ...e_local_config_file_paths_with_wildcard_spec.rb | 2 +- .../include_multiple_files_from_a_project_spec.rb | 2 +- .../4_verify/pipeline/locked_artifacts_spec.rb | 2 +- .../merge_mr_when_pipline_is_blocked_spec.rb | 2 +- .../pipeline/mr_event_rule_pipeline_spec.rb | 2 +- ...tenv_variables_to_downstream_via_bridge_spec.rb | 2 +- .../pipeline_editor_branch_switcher_spec.rb | 2 +- .../pipeline/run_pipeline_via_web_only_spec.rb | 2 +- .../trigger_child_pipeline_with_manual_spec.rb | 2 +- .../4_verify/pipeline/trigger_matrix_spec.rb | 2 +- .../4_verify/runner/register_runner_spec.rb | 2 +- .../4_verify/testing/view_code_coverage_spec.rb | 2 +- .../container_registry_omnibus_spec.rb | 2 +- .../container_registry/container_registry_spec.rb | 2 +- .../online_garbage_collection_spec.rb | 2 +- .../package_registry/composer_registry_spec.rb | 2 +- .../package_registry/conan_repository_spec.rb | 2 +- .../package_registry/generic_repository_spec.rb | 2 +- .../package_registry/pypi_repository_spec.rb | 4 +- .../package_registry/rubygems_registry_spec.rb | 2 +- .../6_release/deploy_key/add_deploy_key_spec.rb | 2 +- .../deploy_token/add_deploy_token_spec.rb | 2 +- .../6_release/pages/pages_pipeline_spec.rb | 2 +- ..._child_pipelines_dependent_relationship_spec.rb | 4 +- ...hild_pipelines_independent_relationship_spec.rb | 4 +- .../create_project_with_auto_devops_spec.rb | 2 +- .../kubernetes/kubernetes_integration_spec.rb | 2 +- .../8_monitor/all_monitor_core_features_spec.rb | 12 +- scripts/trigger-build | 3 +- .../markdown/markdown_golden_master_examples.yml | 2 +- .../content_editor/markdown_processing_spec.js | 25 +-- .../markdown_processing_spec_helper.js | 35 +-- spec/frontend/header_search/components/app_spec.js | 39 +++- spec/frontend/header_search/store/actions_spec.js | 10 + .../frontend/header_search/store/mutations_spec.js | 8 + .../email/message/account_validation_spec.rb | 26 --- spec/mailers/emails/in_product_marketing_spec.rb | 31 --- spec/serializers/build_details_entity_spec.rb | 4 +- spec/serializers/build_serializer_spec.rb | 63 ------ spec/serializers/ci/job_entity_spec.rb | 237 +++++++++++++++++++++ spec/serializers/ci/job_serializer_spec.rb | 63 ++++++ spec/serializers/job_entity_spec.rb | 237 --------------------- spec/tooling/rspec_flaky/flaky_example_spec.rb | 76 +++---- .../rspec_flaky/flaky_examples_collection_spec.rb | 28 ++- spec/tooling/rspec_flaky/listener_spec.rb | 7 +- spec/tooling/rspec_flaky/report_spec.rb | 4 +- tooling/rspec_flaky/example.rb | 10 + tooling/rspec_flaky/flaky_example.rb | 57 +++-- tooling/rspec_flaky/flaky_examples_collection.rb | 2 +- tooling/rspec_flaky/listener.rb | 7 +- tooling/rspec_flaky/report.rb | 9 +- 206 files changed, 896 insertions(+), 945 deletions(-) delete mode 100644 app/serializers/build_serializer.rb create mode 100644 app/serializers/ci/job_entity.rb create mode 100644 app/serializers/ci/job_serializer.rb delete mode 100644 app/serializers/job_entity.rb delete mode 100644 lib/gitlab/email/message/account_validation.rb delete mode 100644 spec/lib/gitlab/email/message/account_validation_spec.rb delete mode 100644 spec/serializers/build_serializer_spec.rb create mode 100644 spec/serializers/ci/job_entity_spec.rb create mode 100644 spec/serializers/ci/job_serializer_spec.rb delete mode 100644 spec/serializers/job_entity_spec.rb diff --git a/.gitlab/ci/qa.gitlab-ci.yml b/.gitlab/ci/qa.gitlab-ci.yml index 7505ae1de68..a7541a613f0 100644 --- a/.gitlab/ci/qa.gitlab-ci.yml +++ b/.gitlab/ci/qa.gitlab-ci.yml @@ -89,6 +89,7 @@ update-qa-cache: CHANGES_FILE: tmp/changed_files.txt ONLY_QA_CHANGES_FILE: tmp/qa_only_changed_files.txt CHANGES_DIFFS_DIR: tmp/diffs + ALLURE_JOB_NAME: $CI_JOB_NAME .package-and-qa-ff-base: script: diff --git a/.gitlab/ci/review.gitlab-ci.yml b/.gitlab/ci/review.gitlab-ci.yml index 232018c2cd0..b08964f26f1 100644 --- a/.gitlab/ci/review.gitlab-ci.yml +++ b/.gitlab/ci/review.gitlab-ci.yml @@ -5,7 +5,7 @@ review-cleanup: image: registry.gitlab.com/gitlab-org/gitlab-build-images:gitlab-helm3-kubectl1.14 stage: prepare environment: - name: review/auto-cleanup + name: review/${CI_COMMIT_REF_SLUG}${FREQUENCY} action: stop before_script: - source scripts/utils.sh @@ -13,6 +13,8 @@ review-cleanup: - install_gitlab_gem - setup_gcp_dependencies script: + - delete_release + - delete_k8s_release_namespace - ruby -rrubygems scripts/review_apps/automated_cleanup.rb - gcp_cleanup diff --git a/.gitlab/ci/rules.gitlab-ci.yml b/.gitlab/ci/rules.gitlab-ci.yml index 3782b0d11dd..e62de4bc6dc 100644 --- a/.gitlab/ci/rules.gitlab-ci.yml +++ b/.gitlab/ci/rules.gitlab-ci.yml @@ -650,8 +650,6 @@ changes: *code-backstage-patterns - <<: *if-security-merge-request changes: *code-backstage-patterns - - <<: *if-default-refs - changes: *backend-patterns - <<: *if-merge-request-not-approved when: never - <<: *if-default-refs @@ -670,9 +668,6 @@ - <<: *if-default-refs changes: *core-frontend-patterns when: never - - <<: *if-default-refs - changes: *backend-patterns - when: never - <<: *if-merge-request changes: *ci-patterns when: never @@ -1623,6 +1618,9 @@ allow_failure: true - <<: *if-dot-com-gitlab-org-merge-request changes: *qa-patterns + - <<: *if-dot-com-gitlab-org-schedule + variables: + KNAPSACK_GENERATE_REPORT: "true" .review:rules:review-build-cng: rules: @@ -1662,10 +1660,6 @@ .review:rules:review-qa-reliable: rules: - - <<: *if-dot-com-ee-2-hourly-schedule - allow_failure: true - variables: - KNAPSACK_GENERATE_REPORT: "true" - when: on_success allow_failure: true @@ -1676,10 +1670,6 @@ changes: *code-patterns when: manual allow_failure: true # manual jobs needs to be allowd to fail, otherwise they block the pipeline - - <<: *if-dot-com-ee-2-hourly-schedule - allow_failure: true - variables: - KNAPSACK_GENERATE_REPORT: "true" - when: on_success allow_failure: true @@ -1699,13 +1689,13 @@ # Reliable suite will pass most of the time so this should yield best distribution .review:rules:knapsack-report-qa-reliable: rules: - - <<: *if-dot-com-ee-2-hourly-schedule + - if: '$KNAPSACK_GENERATE_REPORT == "true"' when: on_success allow_failure: true .review:rules:knapsack-report-qa-all: rules: - - <<: *if-dot-com-ee-2-hourly-schedule + - if: '$KNAPSACK_GENERATE_REPORT == "true"' when: always allow_failure: true diff --git a/.rubocop_todo/style/open_struct_use.yml b/.rubocop_todo/style/open_struct_use.yml index 1a5c8167d6c..c2f0d28575e 100644 --- a/.rubocop_todo/style/open_struct_use.yml +++ b/.rubocop_todo/style/open_struct_use.yml @@ -47,5 +47,3 @@ Style/OpenStructUse: - spec/support/helpers/import_spec_helper.rb - spec/support/helpers/login_helpers.rb - spec/support/helpers/repo_helpers.rb - - spec/tooling/rspec_flaky/flaky_example_spec.rb - - tooling/rspec_flaky/flaky_example.rb diff --git a/GITALY_SERVER_VERSION b/GITALY_SERVER_VERSION index d39801c5c67..8f1b75bbb09 100644 --- a/GITALY_SERVER_VERSION +++ b/GITALY_SERVER_VERSION @@ -1 +1 @@ -15a1323ae16dffd3ba6b078f6cb81e283a96c72d +bba495c8c929b75f8cbcdc6d07d07431736aa8d1 diff --git a/app/assets/javascripts/header_search/components/app.vue b/app/assets/javascripts/header_search/components/app.vue index 67e3998bc97..c22f532d7ac 100644 --- a/app/assets/javascripts/header_search/components/app.vue +++ b/app/assets/javascripts/header_search/components/app.vue @@ -1,7 +1,9 @@