From 289ce60cdc5fe83278ff01f9506db862e6f8e9ac Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Wed, 11 Oct 2023 09:11:29 +0000 Subject: Add latest changes from gitlab-org/gitlab@master --- app/models/merge_request.rb | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'app/models') diff --git a/app/models/merge_request.rb b/app/models/merge_request.rb index 5629baa4f88..72b0632f9fd 100644 --- a/app/models/merge_request.rb +++ b/app/models/merge_request.rb @@ -1257,7 +1257,6 @@ class MergeRequest < ApplicationRecord [ ::MergeRequests::Mergeability::CheckOpenStatusService, ::MergeRequests::Mergeability::CheckDraftStatusService, - ::MergeRequests::Mergeability::CheckNotPreparingService, ::MergeRequests::Mergeability::CheckBrokenStatusService, ::MergeRequests::Mergeability::CheckDiscussionsStatusService, ::MergeRequests::Mergeability::CheckCiStatusService @@ -1559,7 +1558,7 @@ class MergeRequest < ApplicationRecord def mergeable_ci_state? return true unless project.only_allow_merge_if_pipeline_succeeds?(inherit_group_setting: true) - return true unless actual_head_pipeline + return false unless actual_head_pipeline return true if project.allow_merge_on_skipped_pipeline?(inherit_group_setting: true) && actual_head_pipeline.skipped? actual_head_pipeline.success? -- cgit v1.2.3