From 2039c8280db1646845c33d6c5a74e5f23ca6f4de Mon Sep 17 00:00:00 2001
From: Yorick Peterse <yorickpeterse@gmail.com>
Date: Mon, 27 Aug 2018 17:31:01 +0200
Subject: Disable existing offenses for the CodeReuse cops

This whitelists all existing offenses for the various CodeReuse cops, of
which most are triggered by the CodeReuse/ActiveRecord cop.
---
 .../conversational_development_index/metric_presenter.rb          | 2 ++
 app/presenters/merge_request_presenter.rb                         | 4 ++++
 app/presenters/project_presenter.rb                               | 2 +-
 app/presenters/projects/settings/deploy_keys_presenter.rb         | 8 +++++++-
 4 files changed, 14 insertions(+), 2 deletions(-)

(limited to 'app/presenters')

diff --git a/app/presenters/conversational_development_index/metric_presenter.rb b/app/presenters/conversational_development_index/metric_presenter.rb
index e0312c6f431..9639b84cf56 100644
--- a/app/presenters/conversational_development_index/metric_presenter.rb
+++ b/app/presenters/conversational_development_index/metric_presenter.rb
@@ -139,8 +139,10 @@ module ConversationalDevelopmentIndex
       ]
     end
 
+    # rubocop: disable CodeReuse/ActiveRecord
     def average_percentage_score
       cards.sum(&:percentage_score) / cards.size.to_f
     end
+    # rubocop: enable CodeReuse/ActiveRecord
   end
 end
diff --git a/app/presenters/merge_request_presenter.rb b/app/presenters/merge_request_presenter.rb
index 8c4eac3c31d..3f565b826dd 100644
--- a/app/presenters/merge_request_presenter.rb
+++ b/app/presenters/merge_request_presenter.rb
@@ -142,6 +142,7 @@ class MergeRequestPresenter < Gitlab::View::Presenter::Delegated
   end
 
   def assign_to_closing_issues_link
+    # rubocop: disable CodeReuse/ServiceClass
     issues = MergeRequests::AssignIssuesService.new(project,
                                                     current_user,
                                                     merge_request: merge_request,
@@ -152,6 +153,7 @@ class MergeRequestPresenter < Gitlab::View::Presenter::Delegated
       pluralize_this_issue = issues.count > 1 ? "these issues" : "this issue"
       link_to "Assign yourself to #{pluralize_this_issue}", path, method: :post
     end
+    # rubocop: enable CodeReuse/ServiceClass
   end
 
   def can_revert_on_current_merge_request?
@@ -202,7 +204,9 @@ class MergeRequestPresenter < Gitlab::View::Presenter::Delegated
   end
 
   def conflicts
+    # rubocop: disable CodeReuse/ServiceClass
     @conflicts ||= MergeRequests::Conflicts::ListService.new(merge_request)
+    # rubocop: enable CodeReuse/ServiceClass
   end
 
   def closing_issues
diff --git a/app/presenters/project_presenter.rb b/app/presenters/project_presenter.rb
index 6a54054badc..d2434d96fd7 100644
--- a/app/presenters/project_presenter.rb
+++ b/app/presenters/project_presenter.rb
@@ -319,7 +319,7 @@ class ProjectPresenter < Gitlab::View::Presenter::Delegated
   end
 
   def tags_to_show
-    project.tag_list.take(MAX_TAGS_TO_SHOW)
+    project.tag_list.take(MAX_TAGS_TO_SHOW) # rubocop: disable CodeReuse/ActiveRecord
   end
 
   def count_of_extra_tags_not_shown
diff --git a/app/presenters/projects/settings/deploy_keys_presenter.rb b/app/presenters/projects/settings/deploy_keys_presenter.rb
index 28eaef00a12..85518c9a3a4 100644
--- a/app/presenters/projects/settings/deploy_keys_presenter.rb
+++ b/app/presenters/projects/settings/deploy_keys_presenter.rb
@@ -12,9 +12,11 @@ module Projects
         @key ||= DeployKey.new.tap { |dk| dk.deploy_keys_projects.build }
       end
 
+      # rubocop: disable CodeReuse/ActiveRecord
       def enabled_keys
         @enabled_keys ||= project.deploy_keys.includes(:projects)
       end
+      # rubocop: enable CodeReuse/ActiveRecord
 
       def any_keys_enabled?
         enabled_keys.any?
@@ -24,14 +26,17 @@ module Projects
         @available_keys ||= current_user.accessible_deploy_keys - enabled_keys
       end
 
+      # rubocop: disable CodeReuse/ActiveRecord
       def available_project_keys
         @available_project_keys ||= current_user.project_deploy_keys.includes(:projects) - enabled_keys
       end
+      # rubocop: enable CodeReuse/ActiveRecord
 
       def key_available?(deploy_key)
         available_keys.include?(deploy_key)
       end
 
+      # rubocop: disable CodeReuse/ActiveRecord
       def available_public_keys
         return @available_public_keys if defined?(@available_public_keys)
 
@@ -41,9 +46,10 @@ module Projects
         # in @available_project_keys.
         @available_public_keys -= available_project_keys
       end
+      # rubocop: enable CodeReuse/ActiveRecord
 
       def as_json
-        serializer = DeployKeySerializer.new
+        serializer = DeployKeySerializer.new # rubocop: disable CodeReuse/Serializer
         opts = { user: current_user }
 
         {
-- 
cgit v1.2.3