From 56a5fc0cd331143c9a2b4215db3dba6cefd6cc3e Mon Sep 17 00:00:00 2001 From: Douglas Barbosa Alexandre Date: Wed, 17 Feb 2016 14:33:30 -0200 Subject: Move common behavior to to IssuableBaseService --- app/services/issuable_base_service.rb | 13 +++++++++++++ 1 file changed, 13 insertions(+) (limited to 'app/services/issuable_base_service.rb') diff --git a/app/services/issuable_base_service.rb b/app/services/issuable_base_service.rb index 63025c10fb0..fef96639ace 100644 --- a/app/services/issuable_base_service.rb +++ b/app/services/issuable_base_service.rb @@ -71,6 +71,19 @@ class IssuableBaseService < BaseService end end + def have_changes?(issuable, options = {}) + valid_attrs = [:title, :description, :assignee_id, :milestone_id, :target_branch] + + attrs_changed = valid_attrs.any? do |attr| + issuable.previous_changes.include?(attr.to_s) + end + + old_labels = options[:old_labels] + labels_changed = old_labels && issuable.labels != old_labels + + attrs_changed || labels_changed + end + def handle_common_system_notes(issuable, options = {}) if issuable.previous_changes.include?('title') create_title_change_note(issuable, issuable.previous_changes['title'].first) -- cgit v1.2.3