From 2332bf34ac417bb8a0aaba9482379bcfadb6d26e Mon Sep 17 00:00:00 2001 From: mhasbini Date: Sun, 2 Apr 2017 20:48:58 +0300 Subject: Remove unnecessary ORDER BY clause when updating todos --- app/services/todo_service.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'app/services/todo_service.rb') diff --git a/app/services/todo_service.rb b/app/services/todo_service.rb index 2c56cb4c680..b6e88b0280f 100644 --- a/app/services/todo_service.rb +++ b/app/services/todo_service.rb @@ -204,7 +204,7 @@ class TodoService # Only update those that are not really on that state todos = todos.where.not(state: state) todos_ids = todos.pluck(:id) - todos.update_all(state: state) + todos.unscope(:order).update_all(state: state) current_user.update_todos_count_cache todos_ids end -- cgit v1.2.3