From 79dd92c8189600f24a29fe2da8d391cdb021f8fd Mon Sep 17 00:00:00 2001 From: Sean McGivern Date: Sat, 11 May 2019 07:06:44 -0500 Subject: Optimise upload path calls String#underscore isn't particularly slow, but it's possible for us to call it many times in a users autocomplete request, with mostly-static values ('User', 'Group', etc.). We can memoise this and save a surprising amount of time (around 10% of the total request time in some cases). --- app/uploaders/avatar_uploader.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'app/uploaders/avatar_uploader.rb') diff --git a/app/uploaders/avatar_uploader.rb b/app/uploaders/avatar_uploader.rb index c0165759203..9af59b0aceb 100644 --- a/app/uploaders/avatar_uploader.rb +++ b/app/uploaders/avatar_uploader.rb @@ -25,6 +25,6 @@ class AvatarUploader < GitlabUploader private def dynamic_segment - File.join(model.class.to_s.underscore, mounted_as.to_s, model.id.to_s) + File.join(model.class.underscore, mounted_as.to_s, model.id.to_s) end end -- cgit v1.2.3