From 6accad69e214f44ac84f3ceac4159c712aa9af2e Mon Sep 17 00:00:00 2001 From: Ezekiel Kigbo Date: Fri, 19 Apr 2019 10:36:16 +0200 Subject: Added blank lines to meet style guide Un-nest title variable output Update spec test names Rename sort_value_most_stars -> sort_value_stars_desc Rename sorted_by_stars -> sorted_by_stars_desc Renname sort_value_most_stars_asc -> sort_value_stars_asc Invert feature check, assign feature condition to a variable Inline conditional nav bar rendering Invert conditional label Added follow up task Fix filters returning 0 projects show the wrong view Move click action out of test expectation Use proper variable name for project in before block Rename projects_sort_admin_options_hash Renamed projects_sort_admin_options_has to old_projects_sort_options_hash as its not only used on the admin screen Fix extra whitespace errors Stub project_list_filter_bar in the projects_helper specs Added follow up task for `show_projects?` Removed url test expectations --- app/views/explore/projects/_filter.html.haml | 3 ++- app/views/explore/projects/_nav.html.haml | 1 - 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'app/views/explore') diff --git a/app/views/explore/projects/_filter.html.haml b/app/views/explore/projects/_filter.html.haml index 4606f3ec674..ebc3f6b85ce 100644 --- a/app/views/explore/projects/_filter.html.haml +++ b/app/views/explore/projects/_filter.html.haml @@ -1,8 +1,9 @@ - has_label = local_assigns.fetch(:has_label, false) + - if current_user .dropdown.js-project-filter-dropdown-wrap %button.dropdown-menu-toggle{ href: '#', "data-toggle" => "dropdown", 'data-display' => 'static' } - - if !has_label + - unless has_label = icon('globe', class: 'mt-1') %span.light.ml-3= _("Visibility:") - if params[:visibility_level].present? diff --git a/app/views/explore/projects/_nav.html.haml b/app/views/explore/projects/_nav.html.haml index 9ec2122d5a3..bf65c19b720 100644 --- a/app/views/explore/projects/_nav.html.haml +++ b/app/views/explore/projects/_nav.html.haml @@ -15,4 +15,3 @@ = render 'shared/projects/search_form' = render 'shared/projects/dropdown' = render 'filter' - -- cgit v1.2.3