From 1c807d01d461e391d1d0ef56d198784c1884eacc Mon Sep 17 00:00:00 2001 From: Markus Doits Date: Mon, 5 Nov 2018 19:36:51 +0100 Subject: amend method description a little bit --- app/models/ci/build.rb | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) (limited to 'app') diff --git a/app/models/ci/build.rb b/app/models/ci/build.rb index 9d6bfbb0db7..045228b4226 100644 --- a/app/models/ci/build.rb +++ b/app/models/ci/build.rb @@ -893,12 +893,11 @@ module Ci options&.dig(:environment, :url) || persisted_environment&.external_url end - # The format of the retry option changed in GitLab 11.5. Before it was an - # integer only, after it is a hash. New builds always created have the - # correct format, but builds created before GitLab 11.5 and saved in - # database still have the old integer only format. This helper method makes - # sure that the format is always correct when accessing the retry options, - # even on old builds. + # The format of the retry option changed in GitLab 11.5: Before it was + # integer only, after it is a hash. New builds are created with the new + # format, but builds created before GitLab 11.5 and saved in database still + # have the old integer only format. This method returns the retry option + # normalized as a hash in 11.5+ format. def normalized_retry value = options&.dig(:retry) value.is_a?(Integer) ? { max: value } : value.to_h -- cgit v1.2.3